| Submitter | Kumar Gala |
|---|---|
| Date | Aug. 2, 2011, 7:18 p.m. |
| Message ID | <1312312720-20828-1-git-send-email-galak@kernel.crashing.org> |
| Download | mbox | patch |
| Permalink | /patch/9081/ |
| State | New, archived |
| Headers | show |
Comments
On Tue, 2011-08-02 at 14:18 -0500, Kumar Gala wrote: > * Add DEFAULTTUNE setting > * Sync TUNE_PKGARCH with: > commit 20f285728219c1efcc23d8e861902c212893c68d > Author: Richard Purdie <richard.purdie@linuxfoundation.org> > Date: Tue Aug 2 12:40:06 2011 +0100 > > tune/ppc: Fix various TUNE_PKGARCH issues Quick question, are all ppc64 cores ppc32 capable or not? Cheers, Richard > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > .../machine/include/powerpc/arch-powerpc64.inc | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/meta/conf/machine/include/powerpc/arch-powerpc64.inc b/meta/conf/machine/include/powerpc/arch-powerpc64.inc > index a965d59..daad355 100644 > --- a/meta/conf/machine/include/powerpc/arch-powerpc64.inc > +++ b/meta/conf/machine/include/powerpc/arch-powerpc64.inc > @@ -1,8 +1,13 @@ > +DEFAULTTUNE ?= "powerpc64" > + > TUNEVALID[m64] = "Power ELF64 standard ABI" > TUNE_CONFLICTS[m64] = "m32 nf" > TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m64", "-m64", "", d)}" > TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", [ "m64" ], "powerpc64", "", d)}" > > +PPCPKGARCH = "${TUNE_ARCH}" > +TUNE_PKGARCH ?= "${PPCPKGARCH}" > + > AVAILTUNES += "powerpc64" > TUNE_FEATURES_tune-powerpc64 ?= "m64 fpu-hard" > BASE_LIB_tune-powerpc64 = "lib64"
On Aug 2, 2011, at 3:39 PM, Richard Purdie wrote: > On Tue, 2011-08-02 at 14:18 -0500, Kumar Gala wrote: >> * Add DEFAULTTUNE setting >> * Sync TUNE_PKGARCH with: >> commit 20f285728219c1efcc23d8e861902c212893c68d >> Author: Richard Purdie <richard.purdie@linuxfoundation.org> >> Date: Tue Aug 2 12:40:06 2011 +0100 >> >> tune/ppc: Fix various TUNE_PKGARCH issues > > Quick question, are all ppc64 cores ppc32 capable or not? > > Cheers, > > Richard yes - k > >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> >> --- >> .../machine/include/powerpc/arch-powerpc64.inc | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc64.inc b/meta/conf/machine/include/powerpc/arch-powerpc64.inc >> index a965d59..daad355 100644 >> --- a/meta/conf/machine/include/powerpc/arch-powerpc64.inc >> +++ b/meta/conf/machine/include/powerpc/arch-powerpc64.inc >> @@ -1,8 +1,13 @@ >> +DEFAULTTUNE ?= "powerpc64" >> + >> TUNEVALID[m64] = "Power ELF64 standard ABI" >> TUNE_CONFLICTS[m64] = "m32 nf" >> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m64", "-m64", "", d)}" >> TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", [ "m64" ], "powerpc64", "", d)}" >> >> +PPCPKGARCH = "${TUNE_ARCH}" >> +TUNE_PKGARCH ?= "${PPCPKGARCH}" >> + >> AVAILTUNES += "powerpc64" >> TUNE_FEATURES_tune-powerpc64 ?= "m64 fpu-hard" >> BASE_LIB_tune-powerpc64 = "lib64" > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Tue, 2011-08-02 at 16:00 -0500, Kumar Gala wrote: > On Aug 2, 2011, at 3:39 PM, Richard Purdie wrote: > > > On Tue, 2011-08-02 at 14:18 -0500, Kumar Gala wrote: > >> * Add DEFAULTTUNE setting > >> * Sync TUNE_PKGARCH with: > >> commit 20f285728219c1efcc23d8e861902c212893c68d > >> Author: Richard Purdie <richard.purdie@linuxfoundation.org> > >> Date: Tue Aug 2 12:40:06 2011 +0100 > >> > >> tune/ppc: Fix various TUNE_PKGARCH issues > > > > Quick question, are all ppc64 cores ppc32 capable or not? > > > > Cheers, > > > > Richard > > yes Should we make the 64 bit include file automatically include the 32 bit one then? That would take care of the >> +PPCPKGARCH = "${TUNE_ARCH}" >> +TUNE_PKGARCH ?= "${PPCPKGARCH}" part but we probably should set the DEFAULTTUNE still... Cheers, Richard
On Aug 3, 2011, at 11:49 AM, Richard Purdie wrote: > On Tue, 2011-08-02 at 16:00 -0500, Kumar Gala wrote: >> On Aug 2, 2011, at 3:39 PM, Richard Purdie wrote: >> >>> On Tue, 2011-08-02 at 14:18 -0500, Kumar Gala wrote: >>>> * Add DEFAULTTUNE setting >>>> * Sync TUNE_PKGARCH with: >>>> commit 20f285728219c1efcc23d8e861902c212893c68d >>>> Author: Richard Purdie <richard.purdie@linuxfoundation.org> >>>> Date: Tue Aug 2 12:40:06 2011 +0100 >>>> >>>> tune/ppc: Fix various TUNE_PKGARCH issues >>> >>> Quick question, are all ppc64 cores ppc32 capable or not? >>> >>> Cheers, >>> >>> Richard >> >> yes > > Should we make the 64 bit include file automatically include the 32 bit > one then? > > That would take care of the > >>> +PPCPKGARCH = "${TUNE_ARCH}" >>> +TUNE_PKGARCH ?= "${PPCPKGARCH}" > > part but we probably should set the DEFAULTTUNE still... Not a bad idea, I'll look at doing that. - k
Patch
diff --git a/meta/conf/machine/include/powerpc/arch-powerpc64.inc b/meta/conf/machine/include/powerpc/arch-powerpc64.inc index a965d59..daad355 100644 --- a/meta/conf/machine/include/powerpc/arch-powerpc64.inc +++ b/meta/conf/machine/include/powerpc/arch-powerpc64.inc @@ -1,8 +1,13 @@ +DEFAULTTUNE ?= "powerpc64" + TUNEVALID[m64] = "Power ELF64 standard ABI" TUNE_CONFLICTS[m64] = "m32 nf" TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m64", "-m64", "", d)}" TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", [ "m64" ], "powerpc64", "", d)}" +PPCPKGARCH = "${TUNE_ARCH}" +TUNE_PKGARCH ?= "${PPCPKGARCH}" + AVAILTUNES += "powerpc64" TUNE_FEATURES_tune-powerpc64 ?= "m64 fpu-hard" BASE_LIB_tune-powerpc64 = "lib64"
* Add DEFAULTTUNE setting * Sync TUNE_PKGARCH with: commit 20f285728219c1efcc23d8e861902c212893c68d Author: Richard Purdie <richard.purdie@linuxfoundation.org> Date: Tue Aug 2 12:40:06 2011 +0100 tune/ppc: Fix various TUNE_PKGARCH issues Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- .../machine/include/powerpc/arch-powerpc64.inc | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)