Patchwork [meta-oe] iceauth: Import from oe-dev and minor cleanup

login
register
mail settings
Submitter Andreas Müller
Date July 29, 2011, 5:31 p.m.
Message ID <1311960660-7876-1-git-send-email-schnitzeltony@gmx.de>
Download mbox | patch
Permalink /patch/8869/
State Superseded
Headers show

Comments

Andreas Müller - July 29, 2011, 5:31 p.m.
Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
---
 meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
Paul Menzel - July 29, 2011, 6:22 p.m.
Dear Andreas,


thank you for your patch.

Am Freitag, den 29.07.2011, 19:31 +0200 schrieb Andreas Mueller:

When importing from somewhere please always reference the used commit id
as requested in the guidelines [1]. Also mentioning the version in the
summary would be nice.

	iceauth: Import 1.0.4 from oe.dev

> Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
> ---
>  meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> 
> diff --git a/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> new file mode 100644
> index 0000000..e98c0cb
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> @@ -0,0 +1,10 @@
> +DESCRIPTION = "Tool for manipulating ICE protocol authorization records"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=13f70acf3c27f5f834bbc954df775f8e"

What license is it?

> +PR = "${INC_PR}.0"
> +
> +DEPENDS += " libice"

This should go in front of PR according to the style guide [2].

> +
> +require xorg-app-common.inc
> +
> +SRC_URI[md5sum] = "bb2e4d2611047f7c5a1a82ec956a9de4"
> +SRC_URI[sha256sum] = "0ee6fd4554f0131b1ed526ee00b9cf643e7dc97eb70fb51448848ef2f349938d"

I will try to make the updates in oe.dev and maybe you can resync
afterward.


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines
[2] http://wiki.openembedded.org/index.php/Styleguide
Andreas Müller - Aug. 1, 2011, 8:26 p.m.
On Friday, July 29, 2011 08:22:04 PM Paul Menzel wrote:
> Dear Andreas,
> 
> 
> thank you for your patch.
> 
> Am Freitag, den 29.07.2011, 19:31 +0200 schrieb Andreas Mueller:
> 
> When importing from somewhere please always reference the used commit id
> as requested in the guidelines [1]. Also mentioning the version in the
> summary would be nice.
> 
> 	iceauth: Import 1.0.4 from oe.dev
> 
> > Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
> > ---
> > 
> >  meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> >  create mode 100644 meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> > 
> > diff --git a/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> > b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb new file mode
> > 100644
> > index 0000000..e98c0cb
> > --- /dev/null
> > +++ b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> > @@ -0,0 +1,10 @@
> > +DESCRIPTION = "Tool for manipulating ICE protocol authorization records"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=13f70acf3c27f5f834bbc954df775f8e"
> 
> What license is it?
As you said: MIT-X is included by xorg-app-common.inc
> 
> > +PR = "${INC_PR}.0"
> > +
> > +DEPENDS += " libice"
> 
> This should go in front of PR according to the style guide [2].
Do you want V2 with different sequence?
> 
> > +
> > +require xorg-app-common.inc
> > +
> > +SRC_URI[md5sum] = "bb2e4d2611047f7c5a1a82ec956a9de4"
> > +SRC_URI[sha256sum] =
> > "0ee6fd4554f0131b1ed526ee00b9cf643e7dc97eb70fb51448848ef2f349938d"
> 
> I will try to make the updates in oe.dev and maybe you can resync
> afterward.
Sorry for the impatience, but I am about to send out a patch series for xfce48 
and xfce4-session RDEPENDs on iceauth to work properly.

Andreas
Paul Menzel - Aug. 1, 2011, 11:06 p.m.
Am Montag, den 01.08.2011, 22:26 +0200 schrieb Andreas Mueller:
> On Friday, July 29, 2011 08:22:04 PM Paul Menzel wrote:

> > Am Freitag, den 29.07.2011, 19:31 +0200 schrieb Andreas Mueller:
> > 
> > When importing from somewhere please always reference the used commit id
> > as requested in the guidelines [1]. Also mentioning the version in the
> > summary would be nice.
> > 
> > 	iceauth: Import 1.0.4 from oe.dev
> > 
> > > Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
> > > ---
> > > 
> > >  meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb |   10 ++++++++++
> > >  1 files changed, 10 insertions(+), 0 deletions(-)
> > >  create mode 100644 meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> > > 
> > > diff --git a/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> > > b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb new file mode
> > > 100644
> > > index 0000000..e98c0cb
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
> > > @@ -0,0 +1,10 @@
> > > +DESCRIPTION = "Tool for manipulating ICE protocol authorization records"
> > > +LIC_FILES_CHKSUM = "file://COPYING;md5=13f70acf3c27f5f834bbc954df775f8e"
> > 
> > What license is it?
> As you said: MIT-X is included by xorg-app-common.inc
> > 
> > > +PR = "${INC_PR}.0"
> > > +
> > > +DEPENDS += " libice"
> > 
> > This should go in front of PR according to the style guide [2].
> Do you want V2 with different sequence?

Well please send a patch iteration (v2) with the commit message changes
(commit summary and reference of oe.dev revision) but without the change
in the sequence. I left it that way since all other recipes in
`recipes/xorg-apps/` do it this way and that should be changed in one
run.

> > > +
> > > +require xorg-app-common.inc
> > > +
> > > +SRC_URI[md5sum] = "bb2e4d2611047f7c5a1a82ec956a9de4"
> > > +SRC_URI[sha256sum] =
> > > "0ee6fd4554f0131b1ed526ee00b9cf643e7dc97eb70fb51448848ef2f349938d"
> > 
> > I will try to make the updates in oe.dev and maybe you can resync
> > afterward.
>
> Sorry for the impatience, but I am about to send out a patch series for xfce48 
> and xfce4-session RDEPENDs on iceauth to work properly.

Unfortunately nobody of the “core” developers answered. (License issues
are boring after all. ;-)) I pushed a tiny cleanup to oe.dev in 033af22d
[1].

I am sorry for the inconvenience.


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=033af22d565adabc05303f88e76e31e7d239756c

Patch

diff --git a/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
new file mode 100644
index 0000000..e98c0cb
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-app/iceauth_1.0.4.bb
@@ -0,0 +1,10 @@ 
+DESCRIPTION = "Tool for manipulating ICE protocol authorization records"
+LIC_FILES_CHKSUM = "file://COPYING;md5=13f70acf3c27f5f834bbc954df775f8e"
+PR = "${INC_PR}.0"
+
+DEPENDS += " libice"
+
+require xorg-app-common.inc
+
+SRC_URI[md5sum] = "bb2e4d2611047f7c5a1a82ec956a9de4"
+SRC_URI[sha256sum] = "0ee6fd4554f0131b1ed526ee00b9cf643e7dc97eb70fb51448848ef2f349938d"