Patchwork [2/9] tcl: Add tcl_cv_api_serial to siteinfo

login
register
mail settings
Submitter Tom Rini
Date July 27, 2011, 10:56 p.m.
Message ID <d8f714075dcbe37ef21b17639f91a8faeb868bf1.1311807353.git.tom_rini@mentor.com>
Download mbox | patch
Permalink /patch/8749/
State New, archived
Headers show

Comments

Tom Rini - July 27, 2011, 10:56 p.m.
This comes from oe.dev which had this set for arm-linux only.  Bump PR
since this changes how builds happen.

Signed-off-by: Tom Rini <tom_rini@mentor.com>
---
 meta/recipes-devtools/tcltk/tcl_8.5.9.bb |    2 +-
 meta/site/common-glibc                   |    2 ++
 meta/site/common-uclibc                  |    3 +++
 3 files changed, 6 insertions(+), 1 deletions(-)
Khem Raj - July 30, 2011, 5:33 p.m.
On Wednesday, July 27, 2011 03:56:46 PM Tom Rini wrote:
> This comes from oe.dev which had this set for arm-linux only.  Bump PR
> since this changes how builds happen.

if you are clubbing them in right site files then this variable is for
deciding what serial API(termios or termio or sgtty) to use its not dependent 
on libc imo.

> 
> Signed-off-by: Tom Rini <tom_rini@mentor.com>
> ---
>  meta/recipes-devtools/tcltk/tcl_8.5.9.bb |    2 +-
>  meta/site/common-glibc                   |    2 ++
>  meta/site/common-uclibc                  |    3 +++
>  3 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb index 12e2bd0..7dcaeb3 100644
> --- a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> +++ b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM =
> "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
> file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \ "
> 
> -PR = "r0"
> +PR = "r1"
> 
>  BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
>                  file://tcl-add-soname.patch"
> diff --git a/meta/site/common-glibc b/meta/site/common-glibc
> index 8cfa695..baca5f8 100644
> --- a/meta/site/common-glibc
> +++ b/meta/site/common-glibc
> @@ -69,3 +69,5 @@
> gl_cv_func_mbrtowc_null_arg=${gl_cv_func_mbrtowc_null_arg=yes}
> gl_cv_func_mbrtowc_retval=${gl_cv_func_mbrtowc_retval=yes}
>  gl_cv_func_mbrtowc_nul_retval=${gl_cv_func_mbrtowc_nul_retval=yes}
> 
> +# TCL
> +tcl_cv_api_serial=${tcl_cv_api_serial=termios}
> diff --git a/meta/site/common-uclibc b/meta/site/common-uclibc
> index 093f60e..002a559 100644
> --- a/meta/site/common-uclibc
> +++ b/meta/site/common-uclibc
> @@ -26,3 +26,6 @@
> ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes} # bash
>  bash_cv_under_sys_siglist=${bash_cv_under_sys_siglist=no}
>  bash_cv_sys_siglist=${bash_cv_sys_siglist=no}
> +
> +# TCL
> +tcl_cv_api_serial=${tcl_cv_api_serial=termios}
Tom Rini - July 30, 2011, 11:42 p.m.
On 07/30/2011 10:33 AM, Khem Raj wrote:
> On Wednesday, July 27, 2011 03:56:46 PM Tom Rini wrote:
>> This comes from oe.dev which had this set for arm-linux only.  Bump PR
>> since this changes how builds happen.
> 
> if you are clubbing them in right site files then this variable is for
> deciding what serial API(termios or termio or sgtty) to use its not dependent 
> on libc imo.

Where do you think it should go?  common-linux?
Khem Raj - July 31, 2011, 12:56 a.m.
On Saturday, July 30, 2011 04:42:51 PM Tom Rini wrote:
> On 07/30/2011 10:33 AM, Khem Raj wrote:
> > On Wednesday, July 27, 2011 03:56:46 PM Tom Rini wrote:
> >> This comes from oe.dev which had this set for arm-linux only.  Bump PR
> >> since this changes how builds happen.
> > 
> > if you are clubbing them in right site files then this variable is for
> > deciding what serial API(termios or termio or sgtty) to use its not
> > dependent on libc imo.
> 
> Where do you think it should go?  common-linux?
yes
Tom Rini - July 31, 2011, 7:16 p.m.
On 07/30/2011 05:56 PM, Khem Raj wrote:
> On Saturday, July 30, 2011 04:42:51 PM Tom Rini wrote:
>> On 07/30/2011 10:33 AM, Khem Raj wrote:
>>> On Wednesday, July 27, 2011 03:56:46 PM Tom Rini wrote:
>>>> This comes from oe.dev which had this set for arm-linux only.  Bump PR
>>>> since this changes how builds happen.
>>>
>>> if you are clubbing them in right site files then this variable is for
>>> deciding what serial API(termios or termio or sgtty) to use its not
>>> dependent on libc imo.
>>
>> Where do you think it should go?  common-linux?
> yes

k, I'll v2 just this patch, tomorrow.
Tom Rini - Aug. 1, 2011, 5:14 p.m.
On 07/31/2011 12:16 PM, Tom Rini wrote:
> On 07/30/2011 05:56 PM, Khem Raj wrote:
>> On Saturday, July 30, 2011 04:42:51 PM Tom Rini wrote:
>>> On 07/30/2011 10:33 AM, Khem Raj wrote:
>>>> On Wednesday, July 27, 2011 03:56:46 PM Tom Rini wrote:
>>>>> This comes from oe.dev which had this set for arm-linux only.  Bump PR
>>>>> since this changes how builds happen.
>>>>
>>>> if you are clubbing them in right site files then this variable is for
>>>> deciding what serial API(termios or termio or sgtty) to use its not
>>>> dependent on libc imo.
>>>
>>> Where do you think it should go?  common-linux?
>> yes
> 
> k, I'll v2 just this patch, tomorrow.

OK,
http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=trini/update-siteinfo-round-2-v2
and
http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/commit/?h=trini/update-siteinfo-round-2-v2&id=d8f714075dcbe37ef21b17639f91a8faeb868bf1
in particular.
Khem Raj - Aug. 1, 2011, 5:23 p.m.
On (01/08/11 10:14), Tom Rini wrote:
> On 07/31/2011 12:16 PM, Tom Rini wrote:
> > On 07/30/2011 05:56 PM, Khem Raj wrote:
> >> On Saturday, July 30, 2011 04:42:51 PM Tom Rini wrote:
> >>> On 07/30/2011 10:33 AM, Khem Raj wrote:
> >>>> On Wednesday, July 27, 2011 03:56:46 PM Tom Rini wrote:
> >>>>> This comes from oe.dev which had this set for arm-linux only.  Bump PR
> >>>>> since this changes how builds happen.
> >>>>
> >>>> if you are clubbing them in right site files then this variable is for
> >>>> deciding what serial API(termios or termio or sgtty) to use its not
> >>>> dependent on libc imo.
> >>>
> >>> Where do you think it should go?  common-linux?
> >> yes
> > 
> > k, I'll v2 just this patch, tomorrow.
> 
> OK,
> http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=trini/update-siteinfo-round-2-v2
> and
> http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/commit/?h=trini/update-siteinfo-round-2-v2&id=d8f714075dcbe37ef21b17639f91a8faeb868bf1
> in particular.

looks good


> 
> -- 
> Tom Rini
> Mentor Graphics Corporation
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Tom Rini - Aug. 3, 2011, 9:10 p.m.
On 08/01/2011 10:14 AM, Tom Rini wrote:
> On 07/31/2011 12:16 PM, Tom Rini wrote:
>> On 07/30/2011 05:56 PM, Khem Raj wrote:
>>> On Saturday, July 30, 2011 04:42:51 PM Tom Rini wrote:
>>>> On 07/30/2011 10:33 AM, Khem Raj wrote:
>>>>> On Wednesday, July 27, 2011 03:56:46 PM Tom Rini wrote:
>>>>>> This comes from oe.dev which had this set for arm-linux only.  Bump PR
>>>>>> since this changes how builds happen.
>>>>>
>>>>> if you are clubbing them in right site files then this variable is for
>>>>> deciding what serial API(termios or termio or sgtty) to use its not
>>>>> dependent on libc imo.
>>>>
>>>> Where do you think it should go?  common-linux?
>>> yes
>>
>> k, I'll v2 just this patch, tomorrow.
> 
> OK,
> http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=trini/update-siteinfo-round-2-v2
> and
> http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/commit/?h=trini/update-siteinfo-round-2-v2&id=d8f714075dcbe37ef21b17639f91a8faeb868bf1
> in particular.

Due to not paying enough attention, I had pushed only a partial branch
to the v2 branch.  v3 has everything, really.

Patch

diff --git a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
index 12e2bd0..7dcaeb3 100644
--- a/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
+++ b/meta/recipes-devtools/tcltk/tcl_8.5.9.bb
@@ -11,7 +11,7 @@  LIC_FILES_CHKSUM = "file://../license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11
     file://../win/license.terms;md5=a47a9be26d03f925fc1fbd2784f27e11 \
     "
 
-PR = "r0"
+PR = "r1"
 
 BASE_SRC_URI = "${SOURCEFORGE_MIRROR}/tcl/tcl${PV}-src.tar.gz \
                 file://tcl-add-soname.patch"
diff --git a/meta/site/common-glibc b/meta/site/common-glibc
index 8cfa695..baca5f8 100644
--- a/meta/site/common-glibc
+++ b/meta/site/common-glibc
@@ -69,3 +69,5 @@  gl_cv_func_mbrtowc_null_arg=${gl_cv_func_mbrtowc_null_arg=yes}
 gl_cv_func_mbrtowc_retval=${gl_cv_func_mbrtowc_retval=yes}
 gl_cv_func_mbrtowc_nul_retval=${gl_cv_func_mbrtowc_nul_retval=yes}
 
+# TCL
+tcl_cv_api_serial=${tcl_cv_api_serial=termios}
diff --git a/meta/site/common-uclibc b/meta/site/common-uclibc
index 093f60e..002a559 100644
--- a/meta/site/common-uclibc
+++ b/meta/site/common-uclibc
@@ -26,3 +26,6 @@  ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}
 # bash
 bash_cv_under_sys_siglist=${bash_cv_under_sys_siglist=no}
 bash_cv_sys_siglist=${bash_cv_sys_siglist=no}
+
+# TCL
+tcl_cv_api_serial=${tcl_cv_api_serial=termios}