| Submitter | Tom Rini |
|---|---|
| Date | July 27, 2011, 10:56 p.m. |
| Message ID | <13ae8210a401f000beaf5ab54523e07c5b113831.1311807353.git.tom_rini@mentor.com> |
| Download | mbox | patch |
| Permalink | /patch/8741/ |
| State | New, archived |
| Headers | show |
Comments
On Wednesday, July 27, 2011 03:56:45 PM Tom Rini wrote: > We were just setting this to the assumed default. If anything, this > belongs in the libc files if we must set it. uid_t is not a libc controlled define. Its kernel controlled (though kernel- headers) > > Signed-off-by: Tom Rini <tom_rini@mentor.com> > --- > meta/site/arm-common | 3 --- > meta/site/ix86-common | 3 --- > meta/site/mips-linux | 3 --- > meta/site/mips-linux-uclibc | 3 --- > meta/site/mipsel-linux | 5 +---- > meta/site/powerpc32-linux | 3 --- > meta/site/sh-common | 3 --- > meta/site/x86_64-linux | 1 - > 8 files changed, 1 insertions(+), 23 deletions(-) > > diff --git a/meta/site/arm-common b/meta/site/arm-common > index 04d1164..2129298 100644 > --- a/meta/site/arm-common > +++ b/meta/site/arm-common > @@ -191,9 +191,6 @@ > ac_cv_have_openpty_ctty_bug=${ac_cv_have_openpty_ctty_bug=yes} # > startup-notification > lf_cv_sane_realloc=yes > > -# sudo > -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} > - > # xffm > jm_cv_func_working_readdir=yes > > diff --git a/meta/site/ix86-common b/meta/site/ix86-common > index 7a7e253..122eb14 100644 > --- a/meta/site/ix86-common > +++ b/meta/site/ix86-common > @@ -211,9 +211,6 @@ > ac_cv_have_openpty_ctty_bug=${ac_cv_have_openpty_ctty_bug=yes} # > startup-notification > lf_cv_sane_realloc=yes > > -# sudo > -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} > - > # xffm > jm_cv_func_working_readdir=yes > > diff --git a/meta/site/mips-linux b/meta/site/mips-linux > index 807e552..212c3ad 100644 > --- a/meta/site/mips-linux > +++ b/meta/site/mips-linux > @@ -76,9 +76,6 @@ > samba_cv_HAVE_GETTIMEOFDAY_TZ=${samba_cv_HAVE_GETTIMEOFDAY_TZ=yes} # vim > ac_cv_sizeof_int=${ac_cv_sizeof_int=4} > > -# sudo > -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} > - > # intercom > ac_cv_func_fnmatch_works=${ac_cv_func_fnmatch_works=yes} > > diff --git a/meta/site/mips-linux-uclibc b/meta/site/mips-linux-uclibc > index 807e552..212c3ad 100644 > --- a/meta/site/mips-linux-uclibc > +++ b/meta/site/mips-linux-uclibc > @@ -76,9 +76,6 @@ > samba_cv_HAVE_GETTIMEOFDAY_TZ=${samba_cv_HAVE_GETTIMEOFDAY_TZ=yes} # vim > ac_cv_sizeof_int=${ac_cv_sizeof_int=4} > > -# sudo > -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} > - > # intercom > ac_cv_func_fnmatch_works=${ac_cv_func_fnmatch_works=yes} > > diff --git a/meta/site/mipsel-linux b/meta/site/mipsel-linux > index c59d85f..a9032ac 100644 > --- a/meta/site/mipsel-linux > +++ b/meta/site/mipsel-linux > @@ -77,10 +77,7 @@ > samba_cv_HAVE_GETTIMEOFDAY_TZ=${samba_cv_HAVE_GETTIMEOFDAY_TZ=yes} # vim > ac_cv_sizeof_int=${ac_cv_sizeof_int=4} > > -# sudo > -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} > - > -#intercom > +# intercom > ac_cv_func_fnmatch_works=${ac_cv_func_fnmatch_works=yes} > > #lmbench > diff --git a/meta/site/powerpc32-linux b/meta/site/powerpc32-linux > index 46b64eb..8a10111 100644 > --- a/meta/site/powerpc32-linux > +++ b/meta/site/powerpc32-linux > @@ -280,9 +280,6 @@ ac_cv_sync_with_stdio_2=${ac_cv_sync_with_stdio_2=yes} > mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no} > mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no} > > -# sudo > -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} > - > # dpkg > dpkg_cv_va_copy=${ac_cv_va_copy=yes} > dpkg_cv___va_copy=${ac_cv___va_copy=yes} > diff --git a/meta/site/sh-common b/meta/site/sh-common > index 26a612a..63abe57 100644 > --- a/meta/site/sh-common > +++ b/meta/site/sh-common > @@ -231,9 +231,6 @@ > rsync_cv_HAVE_SECURE_MKSTEMP=${rsync_cv_HAVE_SECURE_MKSTEMP=yes} > rsync_cv_REPLACE_INET_NTOA=${rsync_cv_REPLACE_INET_NTOA=no} > rsync_cv_REPLACE_INET_ATON=${rsync_cv_REPLACE_INET_ATON=no} > > -# sudo > -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} > - > # ipsec-tools > ac_cv_va_copy=${ac_cv_va_copy=no} > ac_cv_va_val_copy=${ac_cv_va_val_copy=yes} > diff --git a/meta/site/x86_64-linux b/meta/site/x86_64-linux > index 968dedc..91965b9 100644 > --- a/meta/site/x86_64-linux > +++ b/meta/site/x86_64-linux > @@ -92,7 +92,6 @@ ac_cv_alignof_CORBA_short=2 > ac_cv_alignof_CORBA_struct=1 > ac_cv_alignof_CORBA_wchar=2 > > -sudo_cv_uid_t=${sudo_cv_uid_t_len=10} > lf_cv_sane_realloc=yes > as_cv_unaligned_access=${as_cv_unaligned_access=yes}
On Sat, 2011-07-30 at 10:25 -0700, Khem Raj wrote: > On Wednesday, July 27, 2011 03:56:45 PM Tom Rini wrote: > > We were just setting this to the assumed default. If anything, this > > belongs in the libc files if we must set it. > > uid_t is not a libc controlled define. Its kernel controlled (though kernel- > headers) No, that's incorrect. The uid_t that applications see is controlled by libc and decoupled from __kernel_uid_t. There is logic in glibc to convert between types if necessary. p.
On Saturday, July 30, 2011 07:39:47 PM Phil Blundell wrote: > On Sat, 2011-07-30 at 10:25 -0700, Khem Raj wrote: > > On Wednesday, July 27, 2011 03:56:45 PM Tom Rini wrote: > > > We were just setting this to the assumed default. If anything, this > > > belongs in the libc files if we must set it. > > > > uid_t is not a libc controlled define. Its kernel controlled (though > > kernel- headers) > > No, that's incorrect. The uid_t that applications see is controlled by > libc and decoupled from __kernel_uid_t. There is logic in glibc to > convert between types if necessary. uclibc passes on whatever kernel defines it to. rethinking, probably libc is ok for it. > > p. > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On 07/30/2011 02:03 PM, Khem Raj wrote: > On Saturday, July 30, 2011 07:39:47 PM Phil Blundell wrote: >> On Sat, 2011-07-30 at 10:25 -0700, Khem Raj wrote: >>> On Wednesday, July 27, 2011 03:56:45 PM Tom Rini wrote: >>>> We were just setting this to the assumed default. If anything, this >>>> belongs in the libc files if we must set it. >>> >>> uid_t is not a libc controlled define. Its kernel controlled (though >>> kernel- headers) >> >> No, that's incorrect. The uid_t that applications see is controlled by >> libc and decoupled from __kernel_uid_t. There is logic in glibc to >> convert between types if necessary. > > uclibc passes on whatever kernel defines it to. rethinking, probably libc is > ok for it. And again, this is a "if we feel we must". This patch just drops it from the files.
Patch
diff --git a/meta/site/arm-common b/meta/site/arm-common index 04d1164..2129298 100644 --- a/meta/site/arm-common +++ b/meta/site/arm-common @@ -191,9 +191,6 @@ ac_cv_have_openpty_ctty_bug=${ac_cv_have_openpty_ctty_bug=yes} # startup-notification lf_cv_sane_realloc=yes -# sudo -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} - # xffm jm_cv_func_working_readdir=yes diff --git a/meta/site/ix86-common b/meta/site/ix86-common index 7a7e253..122eb14 100644 --- a/meta/site/ix86-common +++ b/meta/site/ix86-common @@ -211,9 +211,6 @@ ac_cv_have_openpty_ctty_bug=${ac_cv_have_openpty_ctty_bug=yes} # startup-notification lf_cv_sane_realloc=yes -# sudo -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} - # xffm jm_cv_func_working_readdir=yes diff --git a/meta/site/mips-linux b/meta/site/mips-linux index 807e552..212c3ad 100644 --- a/meta/site/mips-linux +++ b/meta/site/mips-linux @@ -76,9 +76,6 @@ samba_cv_HAVE_GETTIMEOFDAY_TZ=${samba_cv_HAVE_GETTIMEOFDAY_TZ=yes} # vim ac_cv_sizeof_int=${ac_cv_sizeof_int=4} -# sudo -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} - # intercom ac_cv_func_fnmatch_works=${ac_cv_func_fnmatch_works=yes} diff --git a/meta/site/mips-linux-uclibc b/meta/site/mips-linux-uclibc index 807e552..212c3ad 100644 --- a/meta/site/mips-linux-uclibc +++ b/meta/site/mips-linux-uclibc @@ -76,9 +76,6 @@ samba_cv_HAVE_GETTIMEOFDAY_TZ=${samba_cv_HAVE_GETTIMEOFDAY_TZ=yes} # vim ac_cv_sizeof_int=${ac_cv_sizeof_int=4} -# sudo -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} - # intercom ac_cv_func_fnmatch_works=${ac_cv_func_fnmatch_works=yes} diff --git a/meta/site/mipsel-linux b/meta/site/mipsel-linux index c59d85f..a9032ac 100644 --- a/meta/site/mipsel-linux +++ b/meta/site/mipsel-linux @@ -77,10 +77,7 @@ samba_cv_HAVE_GETTIMEOFDAY_TZ=${samba_cv_HAVE_GETTIMEOFDAY_TZ=yes} # vim ac_cv_sizeof_int=${ac_cv_sizeof_int=4} -# sudo -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} - -#intercom +# intercom ac_cv_func_fnmatch_works=${ac_cv_func_fnmatch_works=yes} #lmbench diff --git a/meta/site/powerpc32-linux b/meta/site/powerpc32-linux index 46b64eb..8a10111 100644 --- a/meta/site/powerpc32-linux +++ b/meta/site/powerpc32-linux @@ -280,9 +280,6 @@ ac_cv_sync_with_stdio_2=${ac_cv_sync_with_stdio_2=yes} mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no} mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no} -# sudo -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} - # dpkg dpkg_cv_va_copy=${ac_cv_va_copy=yes} dpkg_cv___va_copy=${ac_cv___va_copy=yes} diff --git a/meta/site/sh-common b/meta/site/sh-common index 26a612a..63abe57 100644 --- a/meta/site/sh-common +++ b/meta/site/sh-common @@ -231,9 +231,6 @@ rsync_cv_HAVE_SECURE_MKSTEMP=${rsync_cv_HAVE_SECURE_MKSTEMP=yes} rsync_cv_REPLACE_INET_NTOA=${rsync_cv_REPLACE_INET_NTOA=no} rsync_cv_REPLACE_INET_ATON=${rsync_cv_REPLACE_INET_ATON=no} -# sudo -sudo_cv_uid_t_len=${sudo_cv_uid_t_len=10} - # ipsec-tools ac_cv_va_copy=${ac_cv_va_copy=no} ac_cv_va_val_copy=${ac_cv_va_val_copy=yes} diff --git a/meta/site/x86_64-linux b/meta/site/x86_64-linux index 968dedc..91965b9 100644 --- a/meta/site/x86_64-linux +++ b/meta/site/x86_64-linux @@ -92,7 +92,6 @@ ac_cv_alignof_CORBA_short=2 ac_cv_alignof_CORBA_struct=1 ac_cv_alignof_CORBA_wchar=2 -sudo_cv_uid_t=${sudo_cv_uid_t_len=10} lf_cv_sane_realloc=yes as_cv_unaligned_access=${as_cv_unaligned_access=yes}
We were just setting this to the assumed default. If anything, this belongs in the libc files if we must set it. Signed-off-by: Tom Rini <tom_rini@mentor.com> --- meta/site/arm-common | 3 --- meta/site/ix86-common | 3 --- meta/site/mips-linux | 3 --- meta/site/mips-linux-uclibc | 3 --- meta/site/mipsel-linux | 5 +---- meta/site/powerpc32-linux | 3 --- meta/site/sh-common | 3 --- meta/site/x86_64-linux | 1 - 8 files changed, 1 insertions(+), 23 deletions(-)