| Submitter | Tom Rini |
|---|---|
| Date | July 27, 2011, 10:56 p.m. |
| Message ID | <d395c1bac934913af1ed7c8fc3a09601c823339b.1311807353.git.tom_rini@mentor.com> |
| Download | mbox | patch |
| Permalink | /patch/8735/ |
| State | New, archived |
| Headers | show |
Comments
On Wed, 2011-07-27 at 15:56 -0700, Tom Rini wrote: > Not in oe-core nor meta-oe and based on oe.dev, possibly incomplete. > > Signed-off-by: Tom Rini <tom_rini@mentor.com> > --- > meta/site/arm-common | 3 --- > meta/site/arm-linux | 3 --- > meta/site/common-glibc | 3 --- > meta/site/ix86-common | 3 --- > meta/site/mips-linux | 5 ----- > meta/site/mips-linux-uclibc | 5 ----- > meta/site/mipsel-linux | 5 ----- > meta/site/powerpc32-linux | 4 ---- > meta/site/sh-common | 3 --- > 9 files changed, 0 insertions(+), 34 deletions(-) > > diff --git a/meta/site/arm-common b/meta/site/arm-common > index 2129298..7317a13 100644 > --- a/meta/site/arm-common > +++ b/meta/site/arm-common > @@ -116,9 +116,6 @@ with_broken_putenv=${with_broken_putenv=no} > # links > ac_cv_lib_png_png_create_info_struct=${ac_cv_lib_png_png_create_info_struct=yes} > > -# mono > -cv_mono_sizeof_sunpath=108 > - > # mysql > mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no} > mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no} Isn't mono different from monotone? We don't have mono in OE.core either so the patch is probably fine but I just wanted to mention it... Cheers, Richard
On Thursday, August 04, 2011 02:52:22 PM Richard Purdie wrote: > On Wed, 2011-07-27 at 15:56 -0700, Tom Rini wrote: > > Not in oe-core nor meta-oe and based on oe.dev, possibly incomplete. > > > > Signed-off-by: Tom Rini <tom_rini@mentor.com> > > --- > > > > meta/site/arm-common | 3 --- > > meta/site/arm-linux | 3 --- > > meta/site/common-glibc | 3 --- > > meta/site/ix86-common | 3 --- > > meta/site/mips-linux | 5 ----- > > meta/site/mips-linux-uclibc | 5 ----- > > meta/site/mipsel-linux | 5 ----- > > meta/site/powerpc32-linux | 4 ---- > > meta/site/sh-common | 3 --- > > 9 files changed, 0 insertions(+), 34 deletions(-) > > > > diff --git a/meta/site/arm-common b/meta/site/arm-common > > index 2129298..7317a13 100644 > > --- a/meta/site/arm-common > > +++ b/meta/site/arm-common > > @@ -116,9 +116,6 @@ with_broken_putenv=${with_broken_putenv=no} > > > > # links > > ac_cv_lib_png_png_create_info_struct=${ac_cv_lib_png_png_create_info_s > > truct=yes}> > > -# mono > > -cv_mono_sizeof_sunpath=108 > > - > > > > # mysql > > mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no} > > mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no} > > Isn't mono different from monotone? yes its for mono. I think we should keep it since there are many users of mono from oe.dev world who would want mono in future may be from future meta-mono > > We don't have mono in OE.core either so the patch is probably fine but I > just wanted to mention it... > > Cheers, > > Richard > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Thu, 2011-08-04 at 08:08 -0700, Khem Raj wrote: > On Thursday, August 04, 2011 02:52:22 PM Richard Purdie wrote: > > On Wed, 2011-07-27 at 15:56 -0700, Tom Rini wrote: > > > # links > > > ac_cv_lib_png_png_create_info_struct=${ac_cv_lib_png_png_create_info_s > > > truct=yes}> > > > -# mono > > > -cv_mono_sizeof_sunpath=108 > > > - > > > > > Isn't mono different from monotone? > > yes its for mono. I think we should keep it since there are many users of mono > from oe.dev world who would want mono in future may be from future meta-mono Why couldn't the site entry just go in meta-mono too, if that's where the recipes are living? I don't think it makes much/any sense (for testability reasons as much as anything else) to have a load of siteinfo entries lying around that no oe-core recipe actually uses. p.
On 08/04/2011 08:14 AM, Phil Blundell wrote: > On Thu, 2011-08-04 at 08:08 -0700, Khem Raj wrote: >> On Thursday, August 04, 2011 02:52:22 PM Richard Purdie wrote: >>> On Wed, 2011-07-27 at 15:56 -0700, Tom Rini wrote: >>>> # links >>>> ac_cv_lib_png_png_create_info_struct=${ac_cv_lib_png_png_create_info_s >>>> truct=yes}> >>>> -# mono >>>> -cv_mono_sizeof_sunpath=108 >>>> - >>>> >>> Isn't mono different from monotone? >> >> yes its for mono. I think we should keep it since there are many users of mono >> from oe.dev world who would want mono in future may be from future meta-mono > > Why couldn't the site entry just go in meta-mono too, if that's where > the recipes are living? I don't think it makes much/any sense (for > testability reasons as much as anything else) to have a load of siteinfo > entries lying around that no oe-core recipe actually uses. yes it could. Infact having this variable exported during mono configure would be better solution. > > p. > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Patch
diff --git a/meta/site/arm-common b/meta/site/arm-common index 2129298..7317a13 100644 --- a/meta/site/arm-common +++ b/meta/site/arm-common @@ -116,9 +116,6 @@ with_broken_putenv=${with_broken_putenv=no} # links ac_cv_lib_png_png_create_info_struct=${ac_cv_lib_png_png_create_info_struct=yes} -# mono -cv_mono_sizeof_sunpath=108 - # mysql mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no} mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no} diff --git a/meta/site/arm-linux b/meta/site/arm-linux index 22b455a..87b45eb 100644 --- a/meta/site/arm-linux +++ b/meta/site/arm-linux @@ -154,9 +154,6 @@ ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes} # lftp ac_cv_file___dev_ptc_=yes -#mono -mono_cv_uscore=${mono_cv_uscore=no} - # guile ac_cv_func_pthread_attr_getstack=${ac_cv_func_pthread_attr_getstack=yes} diff --git a/meta/site/common-glibc b/meta/site/common-glibc index baca5f8..258f9ad 100644 --- a/meta/site/common-glibc +++ b/meta/site/common-glibc @@ -38,9 +38,6 @@ ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes} # gnucash am_cv_scanf_lld=${am_cv_scanf_lld=yes} -# mono -mono_cv_uscore=${mono_cv_uscore=no} - # guile ac_cv_func_pthread_attr_getstack=${ac_cv_func_pthread_attr_getstack=yes} diff --git a/meta/site/ix86-common b/meta/site/ix86-common index 122eb14..141ef3a 100644 --- a/meta/site/ix86-common +++ b/meta/site/ix86-common @@ -137,9 +137,6 @@ ac_libnet_have_packet_socket=${ac_libnet_have_packet_socket=yes} # libxfce4util with_broken_putenv=${with_broken_putenv=no} -# mono -cv_mono_sizeof_sunpath=108 - # mysql mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=yes} mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=yes} diff --git a/meta/site/mips-linux b/meta/site/mips-linux index 212c3ad..b99633b 100644 --- a/meta/site/mips-linux +++ b/meta/site/mips-linux @@ -85,11 +85,6 @@ ac_cv_uint=${ac_cv_unit=yes} # D-BUS ac_cv_func_posix_getpwnam_r=${ac_cv_func_posix_getpwnam_r=yes} -# mono -cv_mono_sizeof_sunpath=108 -mono_cv_sizeof_sunpath=108 -mono_cv_uscore=${mono_cv_uscore=no} - # popt ac_cv_va_copy=${ac_cv_va_copy=yes} ac_cv___va_copy=${ac_cv___va_copy=yes} diff --git a/meta/site/mips-linux-uclibc b/meta/site/mips-linux-uclibc index 212c3ad..b99633b 100644 --- a/meta/site/mips-linux-uclibc +++ b/meta/site/mips-linux-uclibc @@ -85,11 +85,6 @@ ac_cv_uint=${ac_cv_unit=yes} # D-BUS ac_cv_func_posix_getpwnam_r=${ac_cv_func_posix_getpwnam_r=yes} -# mono -cv_mono_sizeof_sunpath=108 -mono_cv_sizeof_sunpath=108 -mono_cv_uscore=${mono_cv_uscore=no} - # popt ac_cv_va_copy=${ac_cv_va_copy=yes} ac_cv___va_copy=${ac_cv___va_copy=yes} diff --git a/meta/site/mipsel-linux b/meta/site/mipsel-linux index a9032ac..3347914 100644 --- a/meta/site/mipsel-linux +++ b/meta/site/mipsel-linux @@ -85,11 +85,6 @@ ac_cv_uint=${ac_cv_unit=yes} # D-BUS ac_cv_func_posix_getpwnam_r=${ac_cv_func_posix_getpwnam_r=yes} - -#mono -cv_mono_sizeof_sunpath=108 -mono_cv_uscore=${mono_cv_uscore=no} - # popt ac_cv_va_copy=${ac_cv_va_copy=yes} ac_cv___va_copy=${ac_cv___va_copy=yes} diff --git a/meta/site/powerpc32-linux b/meta/site/powerpc32-linux index 8a10111..c0e3804 100644 --- a/meta/site/powerpc32-linux +++ b/meta/site/powerpc32-linux @@ -272,10 +272,6 @@ samba_cv_have_longlong=${samba_cv_have_longlong=yes} samba_cv_have_setresgid=${samba_cv_have_setresgid=yes} samba_cv_have_setresuid=${samba_cv_have_setresuid=yes} -#monotone -ac_cv_sync_with_stdio=${ac_cv_sync_with_stdio=yes} -ac_cv_sync_with_stdio_2=${ac_cv_sync_with_stdio_2=yes} - # mysql mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no} mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no} diff --git a/meta/site/sh-common b/meta/site/sh-common index 63abe57..bbf98a5 100644 --- a/meta/site/sh-common +++ b/meta/site/sh-common @@ -201,9 +201,6 @@ cvs_cv_func_printf_ptr=${cvs_cv_func_printf_ptr=yes} ac_cv_c_long_double=${ac_cv_c_long_double=yes} bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing} -# mono -cv_mono_sizeof_sunpath=108 - # mysql mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no} mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no}
Not in oe-core nor meta-oe and based on oe.dev, possibly incomplete. Signed-off-by: Tom Rini <tom_rini@mentor.com> --- meta/site/arm-common | 3 --- meta/site/arm-linux | 3 --- meta/site/common-glibc | 3 --- meta/site/ix86-common | 3 --- meta/site/mips-linux | 5 ----- meta/site/mips-linux-uclibc | 5 ----- meta/site/mipsel-linux | 5 ----- meta/site/powerpc32-linux | 4 ---- meta/site/sh-common | 3 --- 9 files changed, 0 insertions(+), 34 deletions(-)