Patchwork connman_test.sh: Rework for busybox 'ps'

login
register
mail settings
Submitter Tom Rini
Date July 27, 2011, 10:01 p.m.
Message ID <1311804095-3244-1-git-send-email-tom_rini@mentor.com>
Download mbox | patch
Permalink /patch/8731/
State New, archived
Headers show

Comments

Tom Rini - July 27, 2011, 10:01 p.m.
This script has two problems today.  First, it does 'ps -ef cmd'
in failure which real ps doesn't grok and busybox ps just ignores
the argument on.  Switch that to 'ps -ef'.  Second, busybox ps -o
doesn't understand cmd but does understand comm.  Using comm lets
us simplify the test logic as well, so switch to that.

Signed-off-by: Tom Rini <tom_rini@mentor.com>
---
 scripts/qemuimage-tests/tools/connman_test.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Saul Wold - Aug. 4, 2011, 2:32 p.m.
On 07/27/2011 03:01 PM, Tom Rini wrote:
> This script has two problems today.  First, it does 'ps -ef cmd'
> in failure which real ps doesn't grok and busybox ps just ignores
> the argument on.  Switch that to 'ps -ef'.  Second, busybox ps -o
> doesn't understand cmd but does understand comm.  Using comm lets
> us simplify the test logic as well, so switch to that.
>
> Signed-off-by: Tom Rini<tom_rini@mentor.com>
> ---
>   scripts/qemuimage-tests/tools/connman_test.sh |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/qemuimage-tests/tools/connman_test.sh b/scripts/qemuimage-tests/tools/connman_test.sh
> index d7e63e7..dd5554c 100644
> --- a/scripts/qemuimage-tests/tools/connman_test.sh
> +++ b/scripts/qemuimage-tests/tools/connman_test.sh
> @@ -27,21 +27,21 @@ if [ ! -f /usr/sbin/connmand ]; then
>   fi
>
>   # Check if connmand is running in background
> -count=`ps -eo cmd | cut -d " " -f 1 | grep -c connmand`
> +count=`ps -eo comm | grep -c connmand`
>
>   if [ $count -ne 1 ]; then
>   	Target_Info "connmand has issue when running in background, Pls, check the output of ps"
> -	ps -ef cmd | grep connmand
> +	ps -ef | grep connmand
>   	exit 1
>   fi
>
>   # Check if there is always only one connmand running in background
>   if [ connmand>  /dev/null 2>&1 ]; then
>   	Target_Info "connmand command run without problem"
> -	count=`ps -eo cmd | cut -d " " -f 1 | grep -c connmand`
> +	count=`ps -eo comm | grep -c connmand`
>   	if [ $count -ne 1 ]; then
>   		Target_Info "There are more than one connmand running in background, Pls, check the output of ps"
> -		ps -ef cmd | grep connmand
> +		ps -ef | grep connmand
>   		exit 1
>   	else
>   		Target_Info "There is always one connmand running in background, test pass"

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/scripts/qemuimage-tests/tools/connman_test.sh b/scripts/qemuimage-tests/tools/connman_test.sh
index d7e63e7..dd5554c 100644
--- a/scripts/qemuimage-tests/tools/connman_test.sh
+++ b/scripts/qemuimage-tests/tools/connman_test.sh
@@ -27,21 +27,21 @@  if [ ! -f /usr/sbin/connmand ]; then
 fi
 
 # Check if connmand is running in background
-count=`ps -eo cmd | cut -d " " -f 1 | grep -c connmand`
+count=`ps -eo comm | grep -c connmand`
 
 if [ $count -ne 1 ]; then
 	Target_Info "connmand has issue when running in background, Pls, check the output of ps"
-	ps -ef cmd | grep connmand
+	ps -ef | grep connmand
 	exit 1
 fi
 
 # Check if there is always only one connmand running in background
 if [ connmand > /dev/null 2>&1 ]; then
 	Target_Info "connmand command run without problem"
-	count=`ps -eo cmd | cut -d " " -f 1 | grep -c connmand`
+	count=`ps -eo comm | grep -c connmand`
 	if [ $count -ne 1 ]; then
 		Target_Info "There are more than one connmand running in background, Pls, check the output of ps"
-		ps -ef cmd | grep connmand
+		ps -ef | grep connmand
 		exit 1
 	else
 		Target_Info "There is always one connmand running in background, test pass"