Patchwork [Consolidated,&,Tested,24/35] siteinfo: Move certain bash entries to common-linux

login
register
mail settings
Submitter Saul Wold
Date July 27, 2011, 7:47 a.m.
Message ID <4adc1ac758823bf95ef5259ecf90a7906b38afc9.1311752531.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/8703/
State New, archived
Headers show

Comments

Saul Wold - July 27, 2011, 7:47 a.m.
From: Tom Rini <tom_rini@mentor.com>

More re-sync with oe.dev

Signed-off-by: Tom Rini <tom_rini@mentor.com>
---
 meta/site/arm-common          |   14 --------------
 meta/site/common-linux        |   16 ++++++++++++++++
 meta/site/ix86-common         |   14 --------------
 meta/site/mips-linux          |    3 ---
 meta/site/mips-linux-uclibc   |    3 ---
 meta/site/mipsel-linux        |   14 --------------
 meta/site/mipsel-linux-uclibc |   14 --------------
 meta/site/powerpc-linux       |    3 ---
 meta/site/powerpc32-linux     |   13 -------------
 meta/site/sh-common           |   14 --------------
 meta/site/sparc-linux         |    3 ---
 meta/site/x86_64-linux        |    1 -
 meta/site/x86_64-linux-uclibc |    1 -
 13 files changed, 16 insertions(+), 97 deletions(-)
Phil Blundell - July 27, 2011, 9:44 a.m.
On Wed, 2011-07-27 at 00:47 -0700, Saul Wold wrote:
> diff --git a/meta/site/arm-common b/meta/site/arm-common
> index 5d3e68a..39eb30b 100644
> --- a/meta/site/arm-common
> +++ b/meta/site/arm-common
> @@ -14,21 +14,7 @@ apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}
>  
>  # bash
>  ac_cv_c_long_double=${ac_cv_c_long_double=yes}
> -bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
>  bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}

That sigsetjmp thing looks pretty bogus to me.  sigsetjmp() is POSIX.1;
it isn't (shouldn't be) architecture specific in any way, and both
eglibc and uclibc implement it nowadays.  I think you should probably
have sigsetjmp=present in linux-common.

p.
Richard Purdie - July 27, 2011, 10:47 a.m.
On Wed, 2011-07-27 at 10:44 +0100, Phil Blundell wrote:
> On Wed, 2011-07-27 at 00:47 -0700, Saul Wold wrote:
> > diff --git a/meta/site/arm-common b/meta/site/arm-common
> > index 5d3e68a..39eb30b 100644
> > --- a/meta/site/arm-common
> > +++ b/meta/site/arm-common
> > @@ -14,21 +14,7 @@ apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}
> >  
> >  # bash
> >  ac_cv_c_long_double=${ac_cv_c_long_double=yes}
> > -bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
> >  bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}
> 
> That sigsetjmp thing looks pretty bogus to me.  sigsetjmp() is POSIX.1;
> it isn't (shouldn't be) architecture specific in any way, and both
> eglibc and uclibc implement it nowadays.  I think you should probably
> have sigsetjmp=present in linux-common.

This is tangential to this patch, could you send one handling that issue
please? :)

Cheers,

Richard
Tom Rini - July 27, 2011, 3:35 p.m.
On 07/27/2011 02:44 AM, Phil Blundell wrote:
> On Wed, 2011-07-27 at 00:47 -0700, Saul Wold wrote:
>> diff --git a/meta/site/arm-common b/meta/site/arm-common
>> index 5d3e68a..39eb30b 100644
>> --- a/meta/site/arm-common
>> +++ b/meta/site/arm-common
>> @@ -14,21 +14,7 @@ apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}
>>  
>>  # bash
>>  ac_cv_c_long_double=${ac_cv_c_long_double=yes}
>> -bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
>>  bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}
> 
> That sigsetjmp thing looks pretty bogus to me.  sigsetjmp() is POSIX.1;
> it isn't (shouldn't be) architecture specific in any way, and both
> eglibc and uclibc implement it nowadays.  I think you should probably
> have sigsetjmp=present in linux-common.

Agreed that we're far from complete here.  oe.dev has this one done and
once I've got the rest of the oe.dev re-sync done I'm just going to wipe
the site files clean and see what's needed anywhere, really.
Phil Blundell - July 27, 2011, 3:52 p.m.
On Wed, 2011-07-27 at 08:35 -0700, Tom Rini wrote:
> Agreed that we're far from complete here.  oe.dev has this one done and
> once I've got the rest of the oe.dev re-sync done I'm just going to wipe
> the site files clean and see what's needed anywhere, really.

Out of interest, why are you doing the resync first?  It seems like it
would be a better use of time to wipe the site files clean and see which
bits we need before spending time on syncing them up.

p.
Tom Rini - July 27, 2011, 3:55 p.m.
On 07/27/2011 08:52 AM, Phil Blundell wrote:
> On Wed, 2011-07-27 at 08:35 -0700, Tom Rini wrote:
>> Agreed that we're far from complete here.  oe.dev has this one done and
>> once I've got the rest of the oe.dev re-sync done I'm just going to wipe
>> the site files clean and see what's needed anywhere, really.
> 
> Out of interest, why are you doing the resync first?  It seems like it
> would be a better use of time to wipe the site files clean and see which
> bits we need before spending time on syncing them up.

Partly to go from something working to something working better and
partly since I didn't realize just how bad things were until I started
digging.

Patch

diff --git a/meta/site/arm-common b/meta/site/arm-common
index 5d3e68a..39eb30b 100644
--- a/meta/site/arm-common
+++ b/meta/site/arm-common
@@ -14,21 +14,7 @@  apr_cv_tcp_nodelay_with_cork=${apr_cv_tcp_nodelay_with_cork=yes}
 
 # bash
 ac_cv_c_long_double=${ac_cv_c_long_double=yes}
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
 bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}
-bash_cv_must_reinstall_sighandlers=${bash_cv_must_reinstall_sighandlers=no}
-bash_cv_func_strcoll_broken=${bash_cv_func_strcoll_broken=no}
-bash_cv_dup2_broken=${bash_cv_dup2_broken=no}
-bash_cv_opendir_not_robust=${bash_cv_opendir_not_robust=no}
-bash_cv_type_rlimit=${bash_cv_type_rlimit=rlim_t}
-bash_cv_getenv_redef=${bash_cv_getenv_redef=yes}
-bash_cv_ulimit_maxfds=${bash_cv_ulimit_maxfds=yes}
-bash_cv_getcwd_calls_popen=${bash_cv_getcwd_calls_popen=no}
-bash_cv_printf_a_format=${bash_cv_printf_a_format=yes}
-bash_cv_pgrp_pipe=${bash_cv_pgrp_pipe=no}
-bash_cv_job_control_missing=${bash_cv_job_control_missing=present}
-bash_cv_sys_named_pipes=${bash_cv_sys_named_pipes=present}
-bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
 
 # coreutils
 utils_cv_sys_open_max=${utils_cv_sys_open_max=1019}
diff --git a/meta/site/common-linux b/meta/site/common-linux
index c37c76a..74a822d 100644
--- a/meta/site/common-linux
+++ b/meta/site/common-linux
@@ -3,3 +3,19 @@  samba_cv_HAVE_IFACE_AIX=${samba_cv_HAVE_IFACE_AIX=no}
 samba_cv_HAVE_IFACE_IFCONF=${samba_cv_HAVE_IFACE_IFCONF=yes}
 samba_cv_HAVE_IFACE_IFREQ=${samba_cv_HAVE_IFACE_IFREQ=yes}
 samba_cv_HAVE_IRIX_SPECIFIC_CAPABILITIES=${samba_cv_HAVE_IRIX_SPECIFIC_CAPABILITIES=no}
+
+# bash
+bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
+bash_cv_must_reinstall_sighandlers=${bash_cv_must_reinstall_sighandlers=no}
+bash_cv_func_strcoll_broken=${bash_cv_func_strcoll_broken=no}
+bash_cv_dup2_broken=${bash_cv_dup2_broken=no}
+bash_cv_opendir_not_robust=${bash_cv_opendir_not_robust=no}
+bash_cv_type_rlimit=${bash_cv_type_rlimit=rlim_t}
+bash_cv_getenv_redef=${bash_cv_getenv_redef=yes}
+bash_cv_ulimit_maxfds=${bash_cv_ulimit_maxfds=yes}
+bash_cv_getcwd_calls_popen=${bash_cv_getcwd_calls_popen=no}
+bash_cv_printf_a_format=${bash_cv_printf_a_format=yes}
+bash_cv_pgrp_pipe=${bash_cv_pgrp_pipe=no}
+bash_cv_job_control_missing=${bash_cv_job_control_missing=present}
+bash_cv_sys_named_pipes=${bash_cv_sys_named_pipes=present}
+bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
diff --git a/meta/site/ix86-common b/meta/site/ix86-common
index 4a4442a..267d59f 100644
--- a/meta/site/ix86-common
+++ b/meta/site/ix86-common
@@ -58,21 +58,7 @@  ac_cv_file_lib_src_libmad_frame_h=${ac_cv_file_lib_src_libmad_frame_h=no}
 
 # bash
 ac_cv_c_long_double=${ac_cv_c_long_double=yes}
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
 bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}
-bash_cv_must_reinstall_sighandlers=${bash_cv_must_reinstall_sighandlers=no}
-bash_cv_func_strcoll_broken=${bash_cv_func_strcoll_broken=no}
-bash_cv_dup2_broken=${bash_cv_dup2_broken=no}
-bash_cv_opendir_not_robust=${bash_cv_opendir_not_robust=no}
-bash_cv_type_rlimit=${bash_cv_type_rlimit=rlim_t}
-bash_cv_getenv_redef=${bash_cv_getenv_redef=yes}
-bash_cv_ulimit_maxfds=${bash_cv_ulimit_maxfds=yes}
-bash_cv_getcwd_calls_popen=${bash_cv_getcwd_calls_popen=no}
-bash_cv_printf_a_format=${bash_cv_printf_a_format=yes}
-bash_cv_pgrp_pipe=${bash_cv_pgrp_pipe=no}
-bash_cv_job_control_missing=${bash_cv_job_control_missing=present}
-bash_cv_sys_named_pipes=${bash_cv_sys_named_pipes=present}
-bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
 
 # clamav
 clamav_av_func_working_snprintf_long=${clamav_av_func_working_snprintf_long=yes}
diff --git a/meta/site/mips-linux b/meta/site/mips-linux
index 074cb09..495df5f 100644
--- a/meta/site/mips-linux
+++ b/meta/site/mips-linux
@@ -118,9 +118,6 @@  mono_cv_uscore=${mono_cv_uscore=no}
 ac_cv_va_copy=${ac_cv_va_copy=yes}
 ac_cv___va_copy=${ac_cv___va_copy=yes}
 
-# readline
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
-
 # eds-dbus
 ac_cv_libiconv_utf8=${ac_cv_libiconv_utf8=yes}
 
diff --git a/meta/site/mips-linux-uclibc b/meta/site/mips-linux-uclibc
index 074cb09..495df5f 100644
--- a/meta/site/mips-linux-uclibc
+++ b/meta/site/mips-linux-uclibc
@@ -118,9 +118,6 @@  mono_cv_uscore=${mono_cv_uscore=no}
 ac_cv_va_copy=${ac_cv_va_copy=yes}
 ac_cv___va_copy=${ac_cv___va_copy=yes}
 
-# readline
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
-
 # eds-dbus
 ac_cv_libiconv_utf8=${ac_cv_libiconv_utf8=yes}
 
diff --git a/meta/site/mipsel-linux b/meta/site/mipsel-linux
index c20e5ee..0959883 100644
--- a/meta/site/mipsel-linux
+++ b/meta/site/mipsel-linux
@@ -8,21 +8,7 @@  ac_cv_func_malloc_0_nonnull=${ac_cv_func_malloc_0_nonnull=yes}
 
 # bash
 ac_cv_c_long_double=${ac_cv_c_long_double=no}
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
 bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=present}
-bash_cv_must_reinstall_sighandlers=${bash_cv_must_reinstall_sighandlers=no}
-bash_cv_func_strcoll_broken=${bash_cv_func_strcoll_broken=no}
-bash_cv_dup2_broken=${bash_cv_dup2_broken=no}
-bash_cv_opendir_not_robust=${bash_cv_opendir_not_robust=no}
-bash_cv_type_rlimit=${bash_cv_type_rlimit=rlim_t}
-bash_cv_getenv_redef=${bash_cv_getenv_redef=yes}
-bash_cv_ulimit_maxfds=${bash_cv_ulimit_maxfds=yes}
-bash_cv_getcwd_calls_popen=${bash_cv_getcwd_calls_popen=no}
-bash_cv_printf_a_format=${bash_cv_printf_a_format=yes}
-bash_cv_pgrp_pipe=${bash_cv_pgrp_pipe=no}
-bash_cv_job_control_missing=${bash_cv_job_control_missing=present}
-bash_cv_sys_named_pipes=${bash_cv_sys_named_pipes=present}
-bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
 
 # openssh
 ac_cv_have_accrights_in_msghdr=${ac_cv_have_accrights_in_msghdr=no}
diff --git a/meta/site/mipsel-linux-uclibc b/meta/site/mipsel-linux-uclibc
index 9545fea..25fa8b5 100644
--- a/meta/site/mipsel-linux-uclibc
+++ b/meta/site/mipsel-linux-uclibc
@@ -8,21 +8,7 @@  ac_cv_func_malloc_0_nonnull=${ac_cv_func_malloc_0_nonnull=yes}
 
 # bash
 ac_cv_c_long_double=${ac_cv_c_long_double=no}
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
 bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=present}
-bash_cv_must_reinstall_sighandlers=${bash_cv_must_reinstall_sighandlers=no}
-bash_cv_func_strcoll_broken=${bash_cv_func_strcoll_broken=no}
-bash_cv_dup2_broken=${bash_cv_dup2_broken=no}
-bash_cv_opendir_not_robust=${bash_cv_opendir_not_robust=no}
-bash_cv_type_rlimit=${bash_cv_type_rlimit=rlim_t}
-bash_cv_getenv_redef=${bash_cv_getenv_redef=yes}
-bash_cv_ulimit_maxfds=${bash_cv_ulimit_maxfds=yes}
-bash_cv_getcwd_calls_popen=${bash_cv_getcwd_calls_popen=no}
-bash_cv_printf_a_format=${bash_cv_printf_a_format=yes}
-bash_cv_pgrp_pipe=${bash_cv_pgrp_pipe=no}
-bash_cv_job_control_missing=${bash_cv_job_control_missing=present}
-bash_cv_sys_named_pipes=${bash_cv_sys_named_pipes=present}
-bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
 
 # openssh
 ac_cv_have_accrights_in_msghdr=${ac_cv_have_accrights_in_msghdr=no}
diff --git a/meta/site/powerpc-linux b/meta/site/powerpc-linux
index 9498b8a..399a58e 100644
--- a/meta/site/powerpc-linux
+++ b/meta/site/powerpc-linux
@@ -4,9 +4,6 @@  ac_cv_func_setgrent_void=yes
 ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getpwuid_r=yes}
 ac_cv_func_posix_getgrgid_r=${ac_cv_func_posix_getgrgid_r=yes}
 
-# bash
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
-
 # startup-notification
 lf_cv_sane_realloc=yes
 
diff --git a/meta/site/powerpc32-linux b/meta/site/powerpc32-linux
index 5d92ecf..9d89f73 100644
--- a/meta/site/powerpc32-linux
+++ b/meta/site/powerpc32-linux
@@ -205,19 +205,6 @@  cvs_cv_func_printf_ptr=${cvs_cv_func_printf_ptr=yes}
 # bash
 ac_cv_c_long_double=${ac_cv_c_long_double=yes}
 bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}
-bash_cv_must_reinstall_sighandlers=${bash_cv_must_reinstall_sighandlers=no}
-bash_cv_func_strcoll_broken=${bash_cv_func_strcoll_broken=no}
-bash_cv_dup2_broken=${bash_cv_dup2_broken=no}
-bash_cv_opendir_not_robust=${bash_cv_opendir_not_robust=no}
-bash_cv_type_rlimit=${bash_cv_type_rlimit=rlim_t}
-bash_cv_getenv_redef=${bash_cv_getenv_redef=yes}
-bash_cv_ulimit_maxfds=${bash_cv_ulimit_maxfds=yes}
-bash_cv_getcwd_calls_popen=${bash_cv_getcwd_calls_popen=no}
-bash_cv_printf_a_format=${bash_cv_printf_a_format=yes}
-bash_cv_pgrp_pipe=${bash_cv_pgrp_pipe=no}
-bash_cv_job_control_missing=${bash_cv_job_control_missing=present}
-bash_cv_sys_named_pipes=${bash_cv_sys_named_pipes=present}
-bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
 
 # openssh
 ac_cv_have_broken_dirname=${ac_cv_have_broken_dirname='yes'}
diff --git a/meta/site/sh-common b/meta/site/sh-common
index 9368444..196af11 100644
--- a/meta/site/sh-common
+++ b/meta/site/sh-common
@@ -222,21 +222,7 @@  cvs_cv_func_printf_ptr=${cvs_cv_func_printf_ptr=yes}
 
 # bash
 ac_cv_c_long_double=${ac_cv_c_long_double=yes}
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
 bash_cv_func_sigsetjmp=${bash_cv_func_sigsetjmp=missing}
-bash_cv_must_reinstall_sighandlers=${bash_cv_must_reinstall_sighandlers=no}
-bash_cv_func_strcoll_broken=${bash_cv_func_strcoll_broken=no}
-bash_cv_dup2_broken=${bash_cv_dup2_broken=no}
-bash_cv_opendir_not_robust=${bash_cv_opendir_not_robust=no}
-bash_cv_type_rlimit=${bash_cv_type_rlimit=rlim_t}
-bash_cv_getenv_redef=${bash_cv_getenv_redef=yes}
-bash_cv_ulimit_maxfds=${bash_cv_ulimit_maxfds=yes}
-bash_cv_getcwd_calls_popen=${bash_cv_getcwd_calls_popen=no}
-bash_cv_printf_a_format=${bash_cv_printf_a_format=yes}
-bash_cv_pgrp_pipe=${bash_cv_pgrp_pipe=no}
-bash_cv_job_control_missing=${bash_cv_job_control_missing=present}
-bash_cv_sys_named_pipes=${bash_cv_sys_named_pipes=present}
-bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
 
 # mono
 cv_mono_sizeof_sunpath=108
diff --git a/meta/site/sparc-linux b/meta/site/sparc-linux
index 491dc74..ea6386b 100644
--- a/meta/site/sparc-linux
+++ b/meta/site/sparc-linux
@@ -53,6 +53,3 @@  glib_cv_stack_grows=${glib_cv_stack_grows=no}
 
 #linux
 ac_cv_linux_vers=${ac_cv_linux_vers=2}
-
-#bash
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
diff --git a/meta/site/x86_64-linux b/meta/site/x86_64-linux
index 9c9e0f8..ba6e57c 100644
--- a/meta/site/x86_64-linux
+++ b/meta/site/x86_64-linux
@@ -32,7 +32,6 @@  ac_cv_sizeof_ino_t=${ac_cv_sizeof_ino_t=8}
 ac_cv_sizeof_dev_t=${ac_cv_sizeof_dev_t=8}
 ac_cv_sizeof_void_p=${ac_cv_sizeof_void_p=8}
 ac_cv_strerror_r_SUSv3=${ac_cv_strerror_r_SUSv3=no}
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
 db_cv_alignp_t=${db_cv_alignp_t='unsigned long long'}
 db_cv_align_t=${db_cv_align_t='unsigned long long'}
 db_cv_fcntl_f_setfd=${db_cv_fcntl_f_setfd=yes}
diff --git a/meta/site/x86_64-linux-uclibc b/meta/site/x86_64-linux-uclibc
index d0d0f32..771e725 100644
--- a/meta/site/x86_64-linux-uclibc
+++ b/meta/site/x86_64-linux-uclibc
@@ -24,7 +24,6 @@  ac_cv_sizeof_short_int=${ac_cv_sizeof_short_int=2}
 ac_cv_sizeof_size_t=${ac_cv_sizeof_size_t=8}
 ac_cv_sizeof_void_p=${ac_cv_sizeof_void_p=8}
 ac_cv_strerror_r_SUSv3=${ac_cv_strerror_r_SUSv3=no}
-bash_cv_have_mbstate_t=${bash_cv_have_mbstate_t=yes}
 db_cv_alignp_t=${db_cv_alignp_t='unsigned long long'}
 db_cv_align_t=${db_cv_align_t='unsigned long long'}
 db_cv_fcntl_f_setfd=${db_cv_fcntl_f_setfd=yes}