Patchwork enhance lib/oe/unpack.py for ".tar.lzma" files

login
register
mail settings
Submitter Dick Hollenbeck
Date July 26, 2011, 5:59 p.m.
Message ID <4E2F0089.2020103@softplc.com>
Download mbox | patch
Permalink /patch/8573/
State New, archived
Headers show

Comments

Dick Hollenbeck - July 26, 2011, 5:59 p.m.
The boys a mingw started packaging binutils as .tar.lzma files.
This is the only trick I found to unpack them.  It works.
(I am trying to revitalize canadian-sdk at newer component versions.)
Paul Menzel - July 26, 2011, 9:45 p.m.
Am Dienstag, den 26.07.2011, 12:59 -0500 schrieb Dick Hollenbeck:
> The boys a mingw started packaging binutils as .tar.lzma files.
> This is the only trick I found to unpack them.  It works.
> (I am trying to revitalize canadian-sdk at newer component versions.)

Please follow the commit policy [1][2]. At least your Signed-off-by line
is missing and the commit summary does not follow the pattern(?).

Please resend your patch as »v2« [3] and update the state of your patch
in the patch queue [4].

Otherwise your patch looks fine. Is it guaranteed that `tar` supports
`lzma`?


Thanks,

Paul


[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/Commit_log_example
[3] http://openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded
[4] http://openembedded.org/index.php/Patchwork

Patch

diff --git a/lib/oe/unpack.py b/lib/oe/unpack.py
index 8e8bf36..d7e34a7 100644
--- a/lib/oe/unpack.py
+++ b/lib/oe/unpack.py
@@ -88,6 +88,8 @@  def unpack_file(file, destdir, parameters, env=None):
             cmd = 'xz -dc %s > %s' % (file, os.path.basename(root))
         elif file.endswith('.tar.lz'):
             cmd = 'lzip -dc %s | tar x --no-same-owner -f -' % file
+        elif file.endswith('.tar.lzma'):
+            cmd = 'tar --lzma --no-same-owner -xf %s' % file
         elif file.endswith('.lz'):
             root, ext = os.path.splitext(file)
             cmd = 'lzip -dc %s > %s' % (file, os.path.basename(root))