Patchwork [RFCv2,meta-efl] e(fl).bbclass: don't override PACKAGES, but add to it

login
register
mail settings
Submitter Koen Kooi
Date July 26, 2011, 7:46 a.m.
Message ID <1311666362-4023-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/8523/
State New, archived
Headers show

Comments

Koen Kooi - July 26, 2011, 7:46 a.m.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta-efl/classes/e.bbclass   |    6 +++---
 meta-efl/classes/efl.bbclass |    4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)
Martin Jansa - July 26, 2011, 7:55 a.m.
On Tue, Jul 26, 2011 at 09:46:02AM +0200, Koen Kooi wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>

Acked-by:  Martin Jansa <Martin.Jansa@gmail.com>

> ---
>  meta-efl/classes/e.bbclass   |    6 +++---
>  meta-efl/classes/efl.bbclass |    4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta-efl/classes/e.bbclass b/meta-efl/classes/e.bbclass
> index 88a1f6a..c803399 100644
> --- a/meta-efl/classes/e.bbclass
> +++ b/meta-efl/classes/e.bbclass
> @@ -18,9 +18,9 @@ do_configure_append() {
>  export CURL_CONFIG = "${STAGING_BINDIR_CROSS}/curl-config"
>  export FREETYPE_CONFIG = "${STAGING_BINDIR_CROSS}/freetype-config"
>  
> -# This construction is stupid, someone with more E knowledge should change it to =+ or something
> -# And it's in efl.bbclass as well....
> -PACKAGES = "${PN}-dbg ${PN}-themes ${PN} ${PN}-dev ${PN}-doc ${PN}-lib ${PN}-static"
> +PACKAGES =+ "${PN}-themes"
> +PACKAGES += "${PN}-lib"
> +
>  FILES_${PN}-lib = "${libdir}/lib*.so.*"
>  FILES_${PN}-themes = "${datadir}/${PN}/themes ${datadir}/${PN}/data ${datadir}/${PN}/fonts ${datadir}/${PN}/pointers ${datadir}/${PN}/images ${datadir}/${PN}/users ${datadir}/${PN}/images ${datadir}/${PN}/styles"
>  FILES_${PN}-dev += "${includedir} ${libdir}/lib*.so"
> diff --git a/meta-efl/classes/efl.bbclass b/meta-efl/classes/efl.bbclass
> index 2dc6fc2..f90dc1c 100644
> --- a/meta-efl/classes/efl.bbclass
> +++ b/meta-efl/classes/efl.bbclass
> @@ -19,8 +19,8 @@ do_install_prepend () {
>  	done
>  }
>  
> -# This construction is stupid, someone with more E knowledge should change it to =+ or something
> -PACKAGES = "${PN}-dbg ${PN} ${PN}-themes ${PN}-dev ${PN}-doc ${PN}-tests ${PN}-static"
> +PACKAGES =+ "${PN}-themes"
> +PACKAGES += "${PN}-tests"
>  
>  FILES_${PN} = "${libdir}/*.so.* \
>                 ${libdir}/edje/modules/${PN}/*/module.so \
> -- 
> 1.6.6.1
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-efl/classes/e.bbclass b/meta-efl/classes/e.bbclass
index 88a1f6a..c803399 100644
--- a/meta-efl/classes/e.bbclass
+++ b/meta-efl/classes/e.bbclass
@@ -18,9 +18,9 @@  do_configure_append() {
 export CURL_CONFIG = "${STAGING_BINDIR_CROSS}/curl-config"
 export FREETYPE_CONFIG = "${STAGING_BINDIR_CROSS}/freetype-config"
 
-# This construction is stupid, someone with more E knowledge should change it to =+ or something
-# And it's in efl.bbclass as well....
-PACKAGES = "${PN}-dbg ${PN}-themes ${PN} ${PN}-dev ${PN}-doc ${PN}-lib ${PN}-static"
+PACKAGES =+ "${PN}-themes"
+PACKAGES += "${PN}-lib"
+
 FILES_${PN}-lib = "${libdir}/lib*.so.*"
 FILES_${PN}-themes = "${datadir}/${PN}/themes ${datadir}/${PN}/data ${datadir}/${PN}/fonts ${datadir}/${PN}/pointers ${datadir}/${PN}/images ${datadir}/${PN}/users ${datadir}/${PN}/images ${datadir}/${PN}/styles"
 FILES_${PN}-dev += "${includedir} ${libdir}/lib*.so"
diff --git a/meta-efl/classes/efl.bbclass b/meta-efl/classes/efl.bbclass
index 2dc6fc2..f90dc1c 100644
--- a/meta-efl/classes/efl.bbclass
+++ b/meta-efl/classes/efl.bbclass
@@ -19,8 +19,8 @@  do_install_prepend () {
 	done
 }
 
-# This construction is stupid, someone with more E knowledge should change it to =+ or something
-PACKAGES = "${PN}-dbg ${PN} ${PN}-themes ${PN}-dev ${PN}-doc ${PN}-tests ${PN}-static"
+PACKAGES =+ "${PN}-themes"
+PACKAGES += "${PN}-tests"
 
 FILES_${PN} = "${libdir}/*.so.* \
                ${libdir}/edje/modules/${PN}/*/module.so \