Patchwork [1/1] classes/image_types: IMAGE_TYPES was missing some entries

login
register
mail settings
Submitter Joshua Lock
Date July 26, 2011, 4:21 a.m.
Message ID <ecf0ccbec73c85ee2e5bbbe9828468fcd995c88c.1311653945.git.josh@linux.intel.com>
Download mbox | patch
Permalink /patch/8499/
State New, archived
Headers show

Comments

Joshua Lock - July 26, 2011, 4:21 a.m.
Some of these entries are required by the GUI to enable the expected workflow
of the ADT, namely a compressed rootfs image.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Tom Rini - July 26, 2011, 2:06 p.m.
On 07/25/2011 09:21 PM, Joshua Lock wrote:
> Some of these entries are required by the GUI to enable the expected workflow
> of the ADT, namely a compressed rootfs image.
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  meta/classes/image_types.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 1108802..f1aef86 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -103,4 +103,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
>  IMAGE_DEPENDS_ubifs = "mtd-utils-native"
>  
>  # This variable is available to request which values are suitable for IMAGE_FSTYPES
> -IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi"
> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

So, is there some way we can do this dynamically?  Either oe-core is
missing ext4, or we'll have to add that and all it's permutations.  And
then there's u-boot signed copies of all of the ext* compressed versions.
Richard Purdie - July 26, 2011, 2:30 p.m.
On Tue, 2011-07-26 at 07:06 -0700, Tom Rini wrote:
> On 07/25/2011 09:21 PM, Joshua Lock wrote:
> > Some of these entries are required by the GUI to enable the expected workflow
> > of the ADT, namely a compressed rootfs image.
> > 
> > Signed-off-by: Joshua Lock <josh@linux.intel.com>
> > ---
> >  meta/classes/image_types.bbclass |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> > index 1108802..f1aef86 100644
> > --- a/meta/classes/image_types.bbclass
> > +++ b/meta/classes/image_types.bbclass
> > @@ -103,4 +103,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
> >  IMAGE_DEPENDS_ubifs = "mtd-utils-native"
> >  
> >  # This variable is available to request which values are suitable for IMAGE_FSTYPES
> > -IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi"
> > +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
> 
> So, is there some way we can do this dynamically?  Either oe-core is
> missing ext4, or we'll have to add that and all it's permutations.  And
> then there's u-boot signed copies of all of the ext* compressed versions.

The configs for the image types could do something like:

IMAGE_TYPE += "jffs2"
IMAGE_CMD_jffs2 = "xxx"

or we could switch to the syntax:

IMAGE_CMD[jffs2] = "xxx"

?

Cheers,

Richard
Richard Purdie - July 26, 2011, 2:53 p.m.
On Mon, 2011-07-25 at 21:21 -0700, Joshua Lock wrote:
> Some of these entries are required by the GUI to enable the expected workflow
> of the ADT, namely a compressed rootfs image.
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  meta/classes/image_types.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

I've merged this since its obviously correct, we probably do need to
think about better ways to generate it though as Tom mentions...

Cheers,

Richard
Joshua Lock - July 26, 2011, 4:03 p.m.
On Tue, 2011-07-26 at 15:53 +0100, Richard Purdie wrote:
> On Mon, 2011-07-25 at 21:21 -0700, Joshua Lock wrote:
> > Some of these entries are required by the GUI to enable the expected workflow
> > of the ADT, namely a compressed rootfs image.
> > 
> > Signed-off-by: Joshua Lock <josh@linux.intel.com>
> > ---
> >  meta/classes/image_types.bbclass |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> I've merged this since its obviously correct, we probably do need to
> think about better ways to generate it though as Tom mentions...

Agreed, I'll add this to my to do list.

Thanks,
Joshua
Tom Rini - July 26, 2011, 4:09 p.m.
On 07/26/2011 09:03 AM, Joshua Lock wrote:
> On Tue, 2011-07-26 at 15:53 +0100, Richard Purdie wrote:
>> On Mon, 2011-07-25 at 21:21 -0700, Joshua Lock wrote:
>>> Some of these entries are required by the GUI to enable the expected workflow
>>> of the ADT, namely a compressed rootfs image.
>>>
>>> Signed-off-by: Joshua Lock <josh@linux.intel.com>
>>> ---
>>>  meta/classes/image_types.bbclass |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> I've merged this since its obviously correct, we probably do need to
>> think about better ways to generate it though as Tom mentions...
> 
> Agreed, I'll add this to my to do list.

Thanks!

Patch

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 1108802..f1aef86 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -103,4 +103,4 @@  IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"