Patchwork beagleboard-test-scripts: userbutton state detection: Remove userspace scripts

login
register
mail settings
Submitter Joel A Fernandes
Date July 26, 2011, 1:07 a.m.
Message ID <1311642479-11502-1-git-send-email-agnel.joel@gmail.com>
Download mbox | patch
Permalink /patch/8477/
State New, archived
Headers show

Comments

Joel A Fernandes - July 26, 2011, 1:07 a.m.
Have U-boot detect if user button was pressed and set a boot argument
so that user space can use this information

This solves a couple of problems:
* The user-button doesn't have to be held when userspace loads
* Eliminate the need for userspace scripts that check for the state of the button

Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
I know recently these updates have become fairly noisy and maybe even a chore for
maintainers to keep applying. Moving to AUTOREV checkout for this recipe (from a
stable branch I maintain) would reduce or eliminate this (I'm not sure how to trigger
rebuilds though without a PR bump)

If not, I'm sorry for the noise, hopefully this should be the last change as this script
hasn't moved for a few days now.

 .../beagleboard/beagleboard-test-scripts_git.bb    |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)
Koen Kooi - July 26, 2011, 4:58 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 26-07-11 03:07, Joel A Fernandes schreef:
> Have U-boot detect if user button was pressed and set a boot argument so that user space can use this information

Where's the matching u-boot patch?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOLkl9MkyGM64RGpERArk6AJsHcmx77q5fklqrPKgMjDgb6PPpAwCfWPzc
SwoZ/9fpCoWU8vC+IJEV9yc=
=l2Ht
-----END PGP SIGNATURE-----
Joel A Fernandes - July 26, 2011, 6:48 a.m.
On Mon, Jul 25, 2011 at 11:58 PM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 26-07-11 03:07, Joel A Fernandes schreef:
>> Have U-boot detect if user button was pressed and set a boot argument so that user space can use this information
>
> Where's the matching u-boot patch?

There's no U-boot patch, the user.txt file installed by this recipe
will contain the extra boot argument.

Thanks,
Joel

[1]

Patch

diff --git a/recipes/beagleboard/beagleboard-test-scripts_git.bb b/recipes/beagleboard/beagleboard-test-scripts_git.bb
index bb0e6e4..6b676de 100644
--- a/recipes/beagleboard/beagleboard-test-scripts_git.bb
+++ b/recipes/beagleboard/beagleboard-test-scripts_git.bb
@@ -1,22 +1,18 @@ 
 ## Reminder:  The correct spacing for a variable is FOO = "BAR"  in : PR="r1"
 DESCRIPTION = "BeagleBoard test scripts"
 HOMEPAGE = "http://beagleboad.org/support"
-PR = "r4"
+PR = "r5"
 
 SRC_URI = "git://gitorious.org/~joelf/beagleboard-validation/validation-scripts.git;protocol=git \
 "
 
-SRCREV = "f7ba1b49190003af524f1a768ec887955a9994a0"
+SRCREV = "4c129ee73698bfb14cfa4c77c2796e871b255551"
 S = "${WORKDIR}/git"
 
 inherit update-rc.d
 INITSCRIPT_NAME = "flash-nand-fs.sh"
 INITSCRIPT_PARAMS = "start 99 2 3 4 5 ."
 
-do_compile() {
-    ${CC} -o userbutton-pressed ${CFLAGS} ${LDFLAGS} flashing/userbutton-pressed.c
-}
-
 do_install() {
   TEST_FILES=" \
     testaudio \
@@ -40,7 +36,6 @@  do_install() {
   # We also register it as an init script so that the SD Card auto-flashes to NAND during boot.
   install -d ${D}/${sysconfdir}/init.d/
   install -m 0755 ${S}/flashing/flash-nand-fs.sh ${D}/${sysconfdir}/init.d/flash-nand-fs.sh
-  install -m 0755 userbutton-pressed ${D}/${bindir}/userbutton-pressed
   install -d ${D}/boot/
   install -m 0755 ${S}/flashing/user.txt ${D}/boot/user.txt
   install -m 0755 ${S}/flashing/uEnv.txt ${D}/boot/uEnv.txt