Patchwork [v2,5/8] siteinfo: Move the rp-pppoe entry to common-linux

login
register
mail settings
Submitter Tom Rini
Date July 22, 2011, 5:10 p.m.
Message ID <c0c3e475a5fe98d61d0b92dca026486b955c2812.1311354521.git.tom_rini@mentor.com>
Download mbox | patch
Permalink /patch/8363/
State New, archived
Headers show

Comments

Tom Rini - July 22, 2011, 5:10 p.m.
More oe.dev re-sync.

Signed-off-by: Tom Rini <tom_rini@mentor.com>
---
 meta/site/arm-linux           |    3 ---
 meta/site/common-linux        |    3 +++
 meta/site/ix86-common         |    3 ---
 meta/site/mips-linux          |    3 ---
 meta/site/mips-linux-uclibc   |    3 ---
 meta/site/mipsel-linux        |    3 ---
 meta/site/mipsel-linux-uclibc |    2 --
 meta/site/sh-common           |    3 ---
 8 files changed, 3 insertions(+), 20 deletions(-)
Phil Blundell - July 25, 2011, 3:57 p.m.
On Fri, 2011-07-22 at 10:10 -0700, Tom Rini wrote:
> --- a/meta/site/common-linux
> +++ b/meta/site/common-linux
> @@ -23,3 +23,6 @@ bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
>  # mysql
>  ac_cv_sys_restartable_syscalls=${ac_cv_sys_restartable_syscalls=yes}
>  ac_cv_conv_longlong_to_float=${ac_cv_conv_longlong_to_float=yes}
> +
> +# rp-pppoe
> +rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}

Is that really correct?  Bitfield packing isn't an OS issue, it's
primarily a question of compiler choice.  For GCC I think it correlates
with endianness; looking at what that test is doing, I'd expect you to
get "reversed" on little-endian and "normal" on big-endian.

p.
Tom Rini - July 25, 2011, 4 p.m.
On 07/25/2011 08:57 AM, Phil Blundell wrote:
> On Fri, 2011-07-22 at 10:10 -0700, Tom Rini wrote:
>> --- a/meta/site/common-linux
>> +++ b/meta/site/common-linux
>> @@ -23,3 +23,6 @@ bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
>>  # mysql
>>  ac_cv_sys_restartable_syscalls=${ac_cv_sys_restartable_syscalls=yes}
>>  ac_cv_conv_longlong_to_float=${ac_cv_conv_longlong_to_float=yes}
>> +
>> +# rp-pppoe
>> +rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
> 
> Is that really correct?  Bitfield packing isn't an OS issue, it's
> primarily a question of compiler choice.  For GCC I think it correlates
> with endianness; looking at what that test is doing, I'd expect you to
> get "reversed" on little-endian and "normal" on big-endian.

It's possible we're getting this, and have been getting this wrong on
big-endian targets but I haven't heard from Freescale this is failing
for them.  I'm OK with dropping this bit out for now until we can
confirm this test on a BE machine.
Phil Blundell - July 25, 2011, 4:40 p.m.
On Mon, 2011-07-25 at 09:00 -0700, Tom Rini wrote:
> On 07/25/2011 08:57 AM, Phil Blundell wrote:
> > On Fri, 2011-07-22 at 10:10 -0700, Tom Rini wrote:
> >> --- a/meta/site/common-linux
> >> +++ b/meta/site/common-linux
> >> @@ -23,3 +23,6 @@ bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
> >>  # mysql
> >>  ac_cv_sys_restartable_syscalls=${ac_cv_sys_restartable_syscalls=yes}
> >>  ac_cv_conv_longlong_to_float=${ac_cv_conv_longlong_to_float=yes}
> >> +
> >> +# rp-pppoe
> >> +rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
> > 
> > Is that really correct?  Bitfield packing isn't an OS issue, it's
> > primarily a question of compiler choice.  For GCC I think it correlates
> > with endianness; looking at what that test is doing, I'd expect you to
> > get "reversed" on little-endian and "normal" on big-endian.
> 
> It's possible we're getting this, and have been getting this wrong on
> big-endian targets but I haven't heard from Freescale this is failing
> for them.  I'm OK with dropping this bit out for now until we can
> confirm this test on a BE machine.

That's probably best.  In any case, as far as I can tell rp-pppoe is
(despite what you might expect from the name) not actually in oe-core
itself, so perhaps its definitions don't belong in oe-core's site files
either.

p.
Tom Rini - July 25, 2011, 4:55 p.m.
On 07/25/2011 09:40 AM, Phil Blundell wrote:
> On Mon, 2011-07-25 at 09:00 -0700, Tom Rini wrote:
>> On 07/25/2011 08:57 AM, Phil Blundell wrote:
>>> On Fri, 2011-07-22 at 10:10 -0700, Tom Rini wrote:
>>>> --- a/meta/site/common-linux
>>>> +++ b/meta/site/common-linux
>>>> @@ -23,3 +23,6 @@ bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
>>>>  # mysql
>>>>  ac_cv_sys_restartable_syscalls=${ac_cv_sys_restartable_syscalls=yes}
>>>>  ac_cv_conv_longlong_to_float=${ac_cv_conv_longlong_to_float=yes}
>>>> +
>>>> +# rp-pppoe
>>>> +rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
>>>
>>> Is that really correct?  Bitfield packing isn't an OS issue, it's
>>> primarily a question of compiler choice.  For GCC I think it correlates
>>> with endianness; looking at what that test is doing, I'd expect you to
>>> get "reversed" on little-endian and "normal" on big-endian.
>>
>> It's possible we're getting this, and have been getting this wrong on
>> big-endian targets but I haven't heard from Freescale this is failing
>> for them.  I'm OK with dropping this bit out for now until we can
>> confirm this test on a BE machine.
> 
> That's probably best.  In any case, as far as I can tell rp-pppoe is
> (despite what you might expect from the name) not actually in oe-core
> itself, so perhaps its definitions don't belong in oe-core's site files
> either.

Yeah.  At one point I was going to try and move the bits that oe-core
doesn't use to meta-oe where they are or likely will be, but possibly
after consolidation (and then just not adding in brand new ones, eg
postgresql).
Tom Rini - July 26, 2011, 6:55 p.m.
On 07/25/2011 09:55 AM, Tom Rini wrote:
> On 07/25/2011 09:40 AM, Phil Blundell wrote:
>> On Mon, 2011-07-25 at 09:00 -0700, Tom Rini wrote:
>>> On 07/25/2011 08:57 AM, Phil Blundell wrote:
>>>> On Fri, 2011-07-22 at 10:10 -0700, Tom Rini wrote:
>>>>> --- a/meta/site/common-linux
>>>>> +++ b/meta/site/common-linux
>>>>> @@ -23,3 +23,6 @@ bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
>>>>>  # mysql
>>>>>  ac_cv_sys_restartable_syscalls=${ac_cv_sys_restartable_syscalls=yes}
>>>>>  ac_cv_conv_longlong_to_float=${ac_cv_conv_longlong_to_float=yes}
>>>>> +
>>>>> +# rp-pppoe
>>>>> +rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
>>>>
>>>> Is that really correct?  Bitfield packing isn't an OS issue, it's
>>>> primarily a question of compiler choice.  For GCC I think it correlates
>>>> with endianness; looking at what that test is doing, I'd expect you to
>>>> get "reversed" on little-endian and "normal" on big-endian.
>>>
>>> It's possible we're getting this, and have been getting this wrong on
>>> big-endian targets but I haven't heard from Freescale this is failing
>>> for them.  I'm OK with dropping this bit out for now until we can
>>> confirm this test on a BE machine.
>>
>> That's probably best.  In any case, as far as I can tell rp-pppoe is
>> (despite what you might expect from the name) not actually in oe-core
>> itself, so perhaps its definitions don't belong in oe-core's site files
>> either.
> 
> Yeah.  At one point I was going to try and move the bits that oe-core
> doesn't use to meta-oe where they are or likely will be, but possibly
> after consolidation (and then just not adding in brand new ones, eg
> postgresql).

As you suspected, this is normal on BE and rev on LE.  I'll fix this for
meta-oe.

Patch

diff --git a/meta/site/arm-linux b/meta/site/arm-linux
index 96a1dde..1211ad4 100644
--- a/meta/site/arm-linux
+++ b/meta/site/arm-linux
@@ -171,6 +171,3 @@  ac_cv_func_pthread_attr_getstack=${ac_cv_func_pthread_attr_getstack=yes}
 ac_cv_member_struct_sockaddr_sa_len=${ac_cv_member_struct_sockaddr_sa_len=no}
 ac_cv_gnet_have_abstract_sockets=${ac_cv_gnet_have_abstract_sockets=no}
 gnet_sockaddr_family_field_name=${gnet_sockaddr_family_field_name=ss_family}
-
-# rp-pppoe
-rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
diff --git a/meta/site/common-linux b/meta/site/common-linux
index 7cdfb63..981100c 100644
--- a/meta/site/common-linux
+++ b/meta/site/common-linux
@@ -23,3 +23,6 @@  bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
 # mysql
 ac_cv_sys_restartable_syscalls=${ac_cv_sys_restartable_syscalls=yes}
 ac_cv_conv_longlong_to_float=${ac_cv_conv_longlong_to_float=yes}
+
+# rp-pppoe
+rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
diff --git a/meta/site/ix86-common b/meta/site/ix86-common
index cacf7ee..fa32bb2 100644
--- a/meta/site/ix86-common
+++ b/meta/site/ix86-common
@@ -187,9 +187,6 @@  ac_cv_pread=${ac_cv_pread=no}
 ac_cv_pwrite=${ac_cv_pwrite=no}
 php_cv_lib_cookie_io_functions_use_off64_t=${php_cv_lib_cookie_io_functions_use_off64_t=yes}
 
-# rp-pppoe
-rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
-
 # rsync
 rsync_cv_HAVE_BROKEN_LARGEFILE=${rsync_cv_HAVE_BROKEN_LARGEFILE=no}
 rsync_cv_HAVE_SOCKETPAIR=${rsync_cv_HAVE_SOCKETPAIR=yes}
diff --git a/meta/site/mips-linux b/meta/site/mips-linux
index 495df5f..f6442ce 100644
--- a/meta/site/mips-linux
+++ b/meta/site/mips-linux
@@ -63,9 +63,6 @@  wi_cv_struct_timeval_tv_sec=${wi_cv_struct_timeval_tv_sec=long}
 wi_cv_struct_timeval_tv_usec=${wi_cv_struct_timeval_tv_usec=long}
 wi_cv_unix_domain_sockets=${wi_cv_unix_domain_sockets=yes}
 
-# rp-pppoe
-rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
-
 # db3
 db_cv_align_t=${db_cv_align_t='unsigned long long'}
 db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
diff --git a/meta/site/mips-linux-uclibc b/meta/site/mips-linux-uclibc
index 495df5f..f6442ce 100644
--- a/meta/site/mips-linux-uclibc
+++ b/meta/site/mips-linux-uclibc
@@ -63,9 +63,6 @@  wi_cv_struct_timeval_tv_sec=${wi_cv_struct_timeval_tv_sec=long}
 wi_cv_struct_timeval_tv_usec=${wi_cv_struct_timeval_tv_usec=long}
 wi_cv_unix_domain_sockets=${wi_cv_unix_domain_sockets=yes}
 
-# rp-pppoe
-rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
-
 # db3
 db_cv_align_t=${db_cv_align_t='unsigned long long'}
 db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
diff --git a/meta/site/mipsel-linux b/meta/site/mipsel-linux
index 0959883..76c0dc0 100644
--- a/meta/site/mipsel-linux
+++ b/meta/site/mipsel-linux
@@ -64,9 +64,6 @@  wi_cv_struct_timeval_tv_sec=${wi_cv_struct_timeval_tv_sec=long}
 wi_cv_struct_timeval_tv_usec=${wi_cv_struct_timeval_tv_usec=long}
 wi_cv_unix_domain_sockets=${wi_cv_unix_domain_sockets=yes}
 
-# rp-pppoe
-rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
-
 # db3
 db_cv_align_t=${db_cv_align_t='unsigned long long'}
 db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
diff --git a/meta/site/mipsel-linux-uclibc b/meta/site/mipsel-linux-uclibc
index 25fa8b5..838bdff 100644
--- a/meta/site/mipsel-linux-uclibc
+++ b/meta/site/mipsel-linux-uclibc
@@ -113,5 +113,3 @@  samba_cv_sysquotas_file=${samba_cv_sysquotas_file=lib/sysquotas_4A.c}
 # doesn't cache it.
 samba_cv_LINUX_LFS_SUPPORT=${samba_cv_LINUX_LFS_SUPPORT=yes}
 
-# rp-pppoe
-rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
diff --git a/meta/site/sh-common b/meta/site/sh-common
index 7fe36cc..b6b0bf5 100644
--- a/meta/site/sh-common
+++ b/meta/site/sh-common
@@ -230,9 +230,6 @@  cv_mono_sizeof_sunpath=108
 mysql_cv_func_atomic_sub=${mysql_cv_func_atomic_sub=no}
 mysql_cv_func_atomic_add=${mysql_cv_func_atomic_add=no}
 
-# rp-pppoe
-rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
-
 # gettext
 am_cv_func_working_getline=${am_cv_func_working_getline=yes}