Patchwork [v3] ] dbus-glib-native and dbus-glib were not compiling. This patch corrects dbus-glib-native to install required files in order to let dbus-glib to compile on target.

login
register
mail settings
Submitter Alessandro Sappia
Date July 22, 2011, 5:05 p.m.
Message ID <1311354305-24120-1-git-send-email-a.sappia@biotechware.com>
Download mbox | patch
Permalink /patch/8361/
State New, archived
Headers show

Comments

Alessandro Sappia - July 22, 2011, 5:05 p.m.
Signed-off-by: Alessandro Sappia <a.sappia@biotechware.com>
---
 recipes/dbus/dbus-glib.inc     |    8 ++++----
 recipes/dbus/dbus-glib_0.86.bb |    7 +------
 2 files changed, 5 insertions(+), 10 deletions(-)
Paul Menzel - July 22, 2011, 5:33 p.m.
Dear Alessandro,


Am Freitag, den 22.07.2011, 19:05 +0200 schrieb Alessandro Sappia:

unfortunately your commit message does not follow the commit policy [1].
Please take a look at the commit log example [2].

Could you please send a v4 with the proper returns included and style
followed.

> Signed-off-by: Alessandro Sappia <a.sappia@biotechware.com>
> ---
>  recipes/dbus/dbus-glib.inc     |    8 ++++----
>  recipes/dbus/dbus-glib_0.86.bb |    7 +------
>  2 files changed, 5 insertions(+), 10 deletions(-)

[…]


Thanks,

Paul


[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/Commit_log_example

Patch

diff --git a/recipes/dbus/dbus-glib.inc b/recipes/dbus/dbus-glib.inc
index c1c1813..7208e91 100644
--- a/recipes/dbus/dbus-glib.inc
+++ b/recipes/dbus/dbus-glib.inc
@@ -21,19 +21,19 @@  inherit autotools pkgconfig gettext
 
 BBCLASSEXTEND = "native"
 
-do_configure_prepend() {
+do_configure() {
         install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-bus-introspect.xml ${S}/tools/
         install -m 0644 ${STAGING_DATADIR_NATIVE}/dbus/dbus-glib-bindings.h ${S}/tools/
-
+        autotools_do_configure
 }
 
 do_configure_virtclass-native() {
         autotools_do_configure
 }
 
-do_install_virtclass-native() {
-        autotools_do_install
+do_install_append_virtclass-native() {
         install -d ${D}${datadir}/dbus
+        install -m 0644 dbus-bus-introspect.xml ${D}${datadir}/dbus
         install -m 0644 tools/dbus-glib-bindings.h ${D}${datadir}/dbus
 }
 
diff --git a/recipes/dbus/dbus-glib_0.86.bb b/recipes/dbus/dbus-glib_0.86.bb
index ce87d5d..ff9a2d6 100644
--- a/recipes/dbus/dbus-glib_0.86.bb
+++ b/recipes/dbus/dbus-glib_0.86.bb
@@ -1,14 +1,9 @@ 
 require dbus-glib.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 SRC_URI_virtclass-native += "file://run-with-tmp-session-bus.patch"
 
-do_install_virtclass-native_prepend() {
-        install -d ${D}${datadir}/dbus
-        install -m 0644 dbus-bus-introspect.xml ${D}${datadir}/dbus
-}
-
 SRC_URI[md5sum] = "cd0ab148fb0c786fc88be49d19971f50"
 SRC_URI[sha256sum] = "5351a6e7f38ffc641c34b4a4cdd9bed1c1dc7043a501096bac00a2876ea90bdc"