Patchwork gcc-4.6: Fix packaging of native toolchains

login
mail settings
Submitter Kumar Gala
Date July 22, 2011, 1:57 p.m.
Message ID <1311343068-942-1-git-send-email-galak@kernel.crashing.org>
Download mbox | patch
Permalink /patch/8335/
State New, archived
Headers show

Comments

Kumar Gala - July 22, 2011, 1:57 p.m.
The base gcc package is missing liblto_plugin.so.  If we try a simple
hello world compile we get something like:

root@p5020-ds:~# gcc hello.c
gcc: fatal error: -fuse-linker-plugin, but liblto_plugin.so not found
compilation terminated.

We need to include liblto_plugin.so in the base gcc package and not
gcc-dev.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 meta/recipes-devtools/gcc/gcc-4.6.inc            |    2 +-
 meta/recipes-devtools/gcc/gcc-package-target.inc |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)
Khem Raj - July 25, 2011, 1:33 a.m.
On Jul 22, 2011, at 6:57 AM, Kumar Gala <galak@kernel.crashing.org> wrote:

> The base gcc package is missing liblto_plugin.so.  If we try a simple
> hello world compile we get something like:
> 
> root@p5020-ds:~# gcc hello.c
> gcc: fatal error: -fuse-linker-plugin, but liblto_plugin.so not found
> compilation terminated.
> 
> We need to include liblto_plugin.so in the base gcc package and not
> gcc-dev.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Acked-by: Khem Raj <raj.khem@gmail.com>

> ---
> meta/recipes-devtools/gcc/gcc-4.6.inc            |    2 +-
> meta/recipes-devtools/gcc/gcc-package-target.inc |    1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
> index a724594..4c1e1e1 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
> @@ -1,6 +1,6 @@
> require gcc-common.inc
> 
> -PR = "r1"
> +PR = "r2"
> 
> # Third digit in PV should be incremented after a minor release
> # happens from this branch on gcc e.g. currently its 4.6.0
> diff --git a/meta/recipes-devtools/gcc/gcc-package-target.inc b/meta/recipes-devtools/gcc/gcc-package-target.inc
> index e6105da..a0e5da4 100644
> --- a/meta/recipes-devtools/gcc/gcc-package-target.inc
> +++ b/meta/recipes-devtools/gcc/gcc-package-target.inc
> @@ -17,6 +17,7 @@ FILES_${PN} = "\
>   ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/cc* \
>   ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/lto* \
>   ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/lib*${SOLIBS} \
> +  ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/liblto*${SOLIBSDEV} \
>   ${gcclibdir}/${TARGET_SYS}/${BINV}/*.o \
>   ${gcclibdir}/${TARGET_SYS}/${BINV}/specs \
>   ${gcclibdir}/${TARGET_SYS}/${BINV}/lib*${SOLIBS} \
> -- 
> 1.7.3.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Koen Kooi - July 25, 2011, 12:25 p.m.
Op 22 jul. 2011, om 15:57 heeft Kumar Gala het volgende geschreven:

> The base gcc package is missing liblto_plugin.so.  If we try a simple
> hello world compile we get something like:
> 
> root@p5020-ds:~# gcc hello.c
> gcc: fatal error: -fuse-linker-plugin, but liblto_plugin.so not found
> compilation terminated.
> 
> We need to include liblto_plugin.so in the base gcc package and not
> gcc-dev.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> meta/recipes-devtools/gcc/gcc-4.6.inc            |    2 +-
> meta/recipes-devtools/gcc/gcc-package-target.inc |    1 +
> 2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
> index a724594..4c1e1e1 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
> @@ -1,6 +1,6 @@
> require gcc-common.inc
> 
> -PR = "r1"
> +PR = "r2"

Doesn't this need a PR bump in gcc-4.5 as well?
Saul Wold - July 25, 2011, 4:27 p.m.
On 07/22/2011 06:57 AM, Kumar Gala wrote:
> The base gcc package is missing liblto_plugin.so.  If we try a simple
> hello world compile we get something like:
>
> root@p5020-ds:~# gcc hello.c
> gcc: fatal error: -fuse-linker-plugin, but liblto_plugin.so not found
> compilation terminated.
>
> We need to include liblto_plugin.so in the base gcc package and not
> gcc-dev.
>
> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
> ---
>   meta/recipes-devtools/gcc/gcc-4.6.inc            |    2 +-
>   meta/recipes-devtools/gcc/gcc-package-target.inc |    1 +
>   2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
> index a724594..4c1e1e1 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
> @@ -1,6 +1,6 @@
>   require gcc-common.inc
>
> -PR = "r1"
> +PR = "r2"
>
>   # Third digit in PV should be incremented after a minor release
>   # happens from this branch on gcc e.g. currently its 4.6.0
> diff --git a/meta/recipes-devtools/gcc/gcc-package-target.inc b/meta/recipes-devtools/gcc/gcc-package-target.inc
> index e6105da..a0e5da4 100644
> --- a/meta/recipes-devtools/gcc/gcc-package-target.inc
> +++ b/meta/recipes-devtools/gcc/gcc-package-target.inc
> @@ -17,6 +17,7 @@ FILES_${PN} = "\
>     ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/cc* \
>     ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/lto* \
>     ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/lib*${SOLIBS} \
> +  ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/liblto*${SOLIBSDEV} \
>     ${gcclibdir}/${TARGET_SYS}/${BINV}/*.o \
>     ${gcclibdir}/${TARGET_SYS}/${BINV}/specs \
>     ${gcclibdir}/${TARGET_SYS}/${BINV}/lib*${SOLIBS} \

Merged into OE-Core

Thanks
	Sau!
Khem Raj - July 25, 2011, 6 p.m.
On Mon, Jul 25, 2011 at 5:25 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 22 jul. 2011, om 15:57 heeft Kumar Gala het volgende geschreven:
>
>> The base gcc package is missing liblto_plugin.so.  If we try a simple
>> hello world compile we get something like:
>>
>> root@p5020-ds:~# gcc hello.c
>> gcc: fatal error: -fuse-linker-plugin, but liblto_plugin.so not found
>> compilation terminated.
>>
>> We need to include liblto_plugin.so in the base gcc package and not
>> gcc-dev.
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> meta/recipes-devtools/gcc/gcc-4.6.inc            |    2 +-
>> meta/recipes-devtools/gcc/gcc-package-target.inc |    1 +
>> 2 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
>> index a724594..4c1e1e1 100644
>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>> @@ -1,6 +1,6 @@
>> require gcc-common.inc
>>
>> -PR = "r1"
>> +PR = "r2"
>
> Doesn't this need a PR bump in gcc-4.5 as well?

yes indeed it does


> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
index a724594..4c1e1e1 100644
--- a/meta/recipes-devtools/gcc/gcc-4.6.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
@@ -1,6 +1,6 @@ 
 require gcc-common.inc
 
-PR = "r1"
+PR = "r2"
 
 # Third digit in PV should be incremented after a minor release
 # happens from this branch on gcc e.g. currently its 4.6.0
diff --git a/meta/recipes-devtools/gcc/gcc-package-target.inc b/meta/recipes-devtools/gcc/gcc-package-target.inc
index e6105da..a0e5da4 100644
--- a/meta/recipes-devtools/gcc/gcc-package-target.inc
+++ b/meta/recipes-devtools/gcc/gcc-package-target.inc
@@ -17,6 +17,7 @@  FILES_${PN} = "\
   ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/cc* \
   ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/lto* \
   ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/lib*${SOLIBS} \
+  ${libexecdir}/gcc/${TARGET_SYS}/${BINV}/liblto*${SOLIBSDEV} \
   ${gcclibdir}/${TARGET_SYS}/${BINV}/*.o \
   ${gcclibdir}/${TARGET_SYS}/${BINV}/specs \
   ${gcclibdir}/${TARGET_SYS}/${BINV}/lib*${SOLIBS} \