Patchwork [v2,1/1] gettext: Add depends to gettext to avoid host contamination

login
register
mail settings
Submitter Saul Wold
Date July 21, 2011, 7:15 a.m.
Message ID <bbc5129ecdec37a4ebf62f3b43e0f0e0a64210f9.1311232435.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/8137/
State New, archived
Headers show

Comments

Saul Wold - July 21, 2011, 7:15 a.m.
[YOCTO #1242]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/gettext/gettext_0.18.1.1.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Phil Blundell - Sept. 25, 2012, 2:25 p.m.
Can you clarify what exactly is the host contamination issue here?  I
don't quite understand why it's appropriate for the target gettext to be
depending on libxml2-native (which it presumably can't be linking
against).  Also, since gettext-native is configured --with-included-xml,
it doesn't seem as though that one is going to be using libxml2-native
in any meaningful sense either.

thanks

p.

On Thu, 2011-07-21 at 00:15 -0700, Saul Wold wrote:
> [YOCTO #1242]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-core/gettext/gettext_0.18.1.1.bb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/gettext/gettext_0.18.1.1.bb b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
> index 0b11a90..cc0129f 100644
> --- a/meta/recipes-core/gettext/gettext_0.18.1.1.bb
> +++ b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
> @@ -5,9 +5,9 @@ SECTION = "libs"
>  LICENSE = "GPLv3"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>  
> -PR = "r1"
> -DEPENDS = "gettext-native virtual/libiconv ncurses expat"
> -DEPENDS_virtclass-native = ""
> +PR = "r2"
> +DEPENDS = "libxml2-native gettext-native virtual/libiconv ncurses expat"
> +DEPENDS_virtclass-native = "libxml2-native"
>  PROVIDES = "virtual/libintl virtual/gettext"
>  PROVIDES_virtclass-native = ""
>  CONFLICTS_${PN} = "proxy-libintl"
Richard Purdie - Sept. 26, 2012, 11:01 a.m.
On Tue, 2012-09-25 at 15:25 +0100, Phil Blundell wrote:
> Can you clarify what exactly is the host contamination issue here?  I
> don't quite understand why it's appropriate for the target gettext to be
> depending on libxml2-native (which it presumably can't be linking
> against).  Also, since gettext-native is configured --with-included-xml,
> it doesn't seem as though that one is going to be using libxml2-native
> in any meaningful sense either.

I tried to unravel this a bit. I think:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e5e6e761d15e42d94836a2153eda13bdbc4f915e

which added the --with-included-xml came later and should have removed
the DEPENDS but didn't.

(the earlier commit being
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=a0abef4533337faeb2fd991d7ab67f0a94f59568)

So this should be ok to go in and does some nice dependency unravelling.

Cheers,

Richard

Patch

diff --git a/meta/recipes-core/gettext/gettext_0.18.1.1.bb b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
index 0b11a90..cc0129f 100644
--- a/meta/recipes-core/gettext/gettext_0.18.1.1.bb
+++ b/meta/recipes-core/gettext/gettext_0.18.1.1.bb
@@ -5,9 +5,9 @@  SECTION = "libs"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
-PR = "r1"
-DEPENDS = "gettext-native virtual/libiconv ncurses expat"
-DEPENDS_virtclass-native = ""
+PR = "r2"
+DEPENDS = "libxml2-native gettext-native virtual/libiconv ncurses expat"
+DEPENDS_virtclass-native = "libxml2-native"
 PROVIDES = "virtual/libintl virtual/gettext"
 PROVIDES_virtclass-native = ""
 CONFLICTS_${PN} = "proxy-libintl"