Patchwork insane: improve diagnostic for redundant rpath

login
register
mail settings
Submitter Koen Kooi
Date July 20, 2011, 2:57 p.m.
Message ID <1311173838-12349-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/8057/
State New, archived
Headers show

Comments

Koen Kooi - July 20, 2011, 2:57 p.m.
From: Phil Blundell <philb@gnu.org>

Make it more obvious which file, and which recipe, are at issue.

Signed-off-by: Phil Blundell <philb@gnu.org>
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/classes/insane.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index c45f2cb..65eda9e 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -142,7 +142,7 @@  def package_qa_check_rpath(file,name, d, elf, messages):
                 messages.append("package %s contains bad RPATH %s in file %s" % (name, line, file))
 
 QAPATHTEST[useless-rpaths] = "package_qa_check_useless_rpaths"
-def package_qa_check_useless_rpaths(file,name, d, elf, messages):
+def package_qa_check_useless_rpaths(file, name, d, elf, messages):
     """
     Check for RPATHs that are useless but not dangerous
     """
@@ -164,7 +164,7 @@  def package_qa_check_useless_rpaths(file,name, d, elf, messages):
 	   if rpath == libdir or rpath == base_libdir:
 	      # The dynamic linker searches both these places anyway.  There is no point in
 	      # looking there again.
-	      messages.append("dynamic section contains probably-redundant RPATH %s" % rpath)
+	      messages.append("%s: %s contains probably-redundant RPATH %s" % (name, package_qa_clean_path(file, d), rpath))
 
 QAPATHTEST[dev-so] = "package_qa_check_dev"
 def package_qa_check_dev(path, name, d, elf, messages):