Patchwork libgcc: correct mode on libgcc_s.so.1 to ensure it gets stripped

login
register
mail settings
Submitter Phil Blundell
Date July 20, 2011, 10:07 a.m.
Message ID <1311156453.30326.53.camel@phil-desktop>
Download mbox | patch
Permalink /patch/8053/
State New, archived
Headers show

Comments

Phil Blundell - July 20, 2011, 10:07 a.m.
If the library is installed without execute permission then package.bbclass
will not consider it for stripping.  This is particularly unfortunate because 
there seems to be a bug somewhere else which is causing all DSOs to end up with 
a NEEDED dependency on libgcc_s, even if they don't actually require it, and 
hence it is getting installed in all images (for uclibc on i586 at least).

Signed-off-by: Phil Blundell <philb@gnu.org>
---
 meta/recipes-devtools/gcc/libgcc_4.6.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Richard Purdie - July 20, 2011, 2:33 p.m.
On Wed, 2011-07-20 at 11:07 +0100, Phil Blundell wrote:
> If the library is installed without execute permission then package.bbclass
> will not consider it for stripping.  This is particularly unfortunate because 
> there seems to be a bug somewhere else which is causing all DSOs to end up with 
> a NEEDED dependency on libgcc_s, even if they don't actually require it, and 
> hence it is getting installed in all images (for uclibc on i586 at least).
> 
> Signed-off-by: Phil Blundell <philb@gnu.org>

Merged to master, thanks.

Richard

Patch

diff --git a/meta/recipes-devtools/gcc/libgcc_4.6.bb b/meta/recipes-devtools/gcc/libgcc_4.6.bb
index e74be19..a53835f 100644
--- a/meta/recipes-devtools/gcc/libgcc_4.6.bb
+++ b/meta/recipes-devtools/gcc/libgcc_4.6.bb
@@ -1,6 +1,6 @@ 
 require gcc-${PV}.inc
 
-PR = "r0"
+PR = "r1"
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}g++"
@@ -41,6 +41,7 @@  do_install () {
 	fi
 
 	chown -R root:root ${D}
+	chmod +x ${D}${base_libdir}/libgcc_s.so.*
 }
 
 do_package_write_ipk[depends] += "virtual/libc:do_package"