Patchwork lftp: add ti LFTB recipe

login
register
mail settings
Submitter chase maupin
Date Dec. 16, 2010, 5:46 p.m.
Message ID <1292521608-26072-1-git-send-email-Chase.Maupin@ti.com>
Download mbox | patch
Permalink /patch/80/
State Superseded
Headers show

Comments

chase maupin - Dec. 16, 2010, 5:46 p.m.
From: naresh <naresh@ti.com>

* This package contains functional test suites for TI devices
  used to verify the Linux kernel and drivers for the various
  peripherals found on TI devices.

Signed-off-by: naresh <naresh@ti.com>
Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
 recipes/ti/ti-lftb.inc    |   47 +++++++++++++++++++++++++++++++++++++++++++++
 recipes/ti/ti-lftb_2.0.bb |    9 ++++++++
 2 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 recipes/ti/ti-lftb.inc
 create mode 100644 recipes/ti/ti-lftb_2.0.bb
Khem Raj - Dec. 20, 2010, 3:10 a.m.
On (16/12/10 11:46), Chase Maupin wrote:
> From: naresh <naresh@ti.com>
> 
> * This package contains functional test suites for TI devices
>   used to verify the Linux kernel and drivers for the various
>   peripherals found on TI devices.
> 
> Signed-off-by: naresh <naresh@ti.com>
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
>  recipes/ti/ti-lftb.inc    |   47 +++++++++++++++++++++++++++++++++++++++++++++
>  recipes/ti/ti-lftb_2.0.bb |    9 ++++++++
>  2 files changed, 56 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/ti/ti-lftb.inc
>  create mode 100644 recipes/ti/ti-lftb_2.0.bb
> 
> diff --git a/recipes/ti/ti-lftb.inc b/recipes/ti/ti-lftb.inc
> new file mode 100644
> index 0000000..176f983
> --- /dev/null
> +++ b/recipes/ti/ti-lftb.inc
> @@ -0,0 +1,47 @@
> +DESCRIPTION = "Linux Functional test bench"

may be F should be f

> +HOMEPAGE = "http://arago-project.org/git/projects/?p=test-automation/target-code/psp/lftb.git;a=summary"
> +LICENSE="BSD"
> +
> +INC_PR = "r1"

New recipes begin at 'r0'

> +
> +DEPENDS = "virtual/kernel"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +COMPATIBLE_MACHINE = "(dm365|dm355|dm6446|dm6467|omapl137|omapl138|omap3|ti816x)"
> +

could it use SOC_FAMILY


> +S = "${WORKDIR}/git"
> +
> +#Machine specific overrides
> +PLATFORM_omap3evm="omap35x"
> +PLATFORM_am180x-evm="am18x"
> +PLATFORM_am3517-evm="am3517"
> +PLATFORM_am37x-evm="am37x"
> +PLATFORM_beagleboard="beagle"
> +PLATFORM_da830-omapl137-evm="am17x"
> +PLATFORM_da850-omapl138-evm="am18x"
> +PLATFORM_am181x-evm="am18x"
> +PLATFORM_dm355-evm="dm355"
> +PLATFORM_dm365-evm="dm365"
> +PLATFORM_dm37x-evm="am37x"
> +PLATFORM_dm6446-evm="dm644x"
> +PLATFORM_dm6467-evm="dm646x"
> +PLATFORM_ti816x="ti816x"
> +
> +do_compile () {
> +    cd ${S}
> +    make KERNEL_DIR=${STAGING_KERNEL_DIR} PLATFORM=${PLATFORM} TOOL_PREFIX=${TARGET_PREFIX}
> +}
> +
> +do_install () {
> +    install -d ${D}${bindir}/lftb
> +    cd ${S}

is this cd needed ?

> +    make INSTALL_DIR=${D}${bindir}/lftb install
> +
> +    # Remove unneeded tarball placed in bindir by install target
> +    rm -rf ${D}${bindir}/lftb.tar.gz
> +}
> +
> +INSANE_SKIP_${PN} = True
> +
> +FILES_${PN} = "${bindir}/lftb"
> diff --git a/recipes/ti/ti-lftb_2.0.bb b/recipes/ti/ti-lftb_2.0.bb
> new file mode 100644
> index 0000000..62c936c
> --- /dev/null
> +++ b/recipes/ti/ti-lftb_2.0.bb
> @@ -0,0 +1,9 @@
> +require ti-lftb.inc
> +
> +SRCREV = "3d0be58aee659ef7e8eda43e916172bab300235f"
> +
> +PR = "${MACHINE_KERNEL_PR}+${INC_PR}"
> +PR_append = "a"
> +
> +SRC_URI = "git://arago-project.org/git/projects/test-automation/target-code/psp/lftb.git;protocol=git \
> +"
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Paul Menzel - Dec. 20, 2010, 2:16 p.m.
Dear Naresh and Chase,


I am adding my comments to Khem’s.


Am Sonntag, den 19.12.2010, 19:10 -0800 schrieb Khem Raj:
> On (16/12/10 11:46), Chase Maupin wrote:

First of all the commit summary should be.

	lftb: add TI LFTP 2.0

lft*b*

> > From: naresh <naresh@ti.com>

If there is no compelling reason against it usually the real name
(Naresh Medisetty) is used.

> > * This package contains functional test suites for TI devices
> >   used to verify the Linux kernel and drivers for the various
> >   peripherals found on TI devices.
> > 
> > Signed-off-by: naresh <naresh@ti.com>

Here too.

> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> > ---
> >  recipes/ti/ti-lftb.inc    |   47 +++++++++++++++++++++++++++++++++++++++++++++
> >  recipes/ti/ti-lftb_2.0.bb |    9 ++++++++
> >  2 files changed, 56 insertions(+), 0 deletions(-)
> >  create mode 100644 recipes/ti/ti-lftb.inc
> >  create mode 100644 recipes/ti/ti-lftb_2.0.bb
> > 
> > diff --git a/recipes/ti/ti-lftb.inc b/recipes/ti/ti-lftb.inc
> > new file mode 100644
> > index 0000000..176f983
> > --- /dev/null
> > +++ b/recipes/ti/ti-lftb.inc
> > @@ -0,0 +1,47 @@
> > +DESCRIPTION = "Linux Functional test bench"
> 
> may be F should be f
> 
> > +HOMEPAGE = "http://arago-project.org/git/projects/?p=test-automation/target-code/psp/lftb.git;a=summary"
> > +LICENSE="BSD"
> > +
> > +INC_PR = "r1"
> 
> New recipes begin at 'r0'
> 
> > +
> > +DEPENDS = "virtual/kernel"
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> > +COMPATIBLE_MACHINE = "(dm365|dm355|dm6446|dm6467|omapl137|omapl138|omap3|ti816x)"
> > +
> 
> could it use SOC_FAMILY
> 
> 
> > +S = "${WORKDIR}/git"
> > +
> > +#Machine specific overrides
> > +PLATFORM_omap3evm="omap35x"
> > +PLATFORM_am180x-evm="am18x"
> > +PLATFORM_am3517-evm="am3517"
> > +PLATFORM_am37x-evm="am37x"
> > +PLATFORM_beagleboard="beagle"
> > +PLATFORM_da830-omapl137-evm="am17x"
> > +PLATFORM_da850-omapl138-evm="am18x"
> > +PLATFORM_am181x-evm="am18x"
> > +PLATFORM_dm355-evm="dm355"
> > +PLATFORM_dm365-evm="dm365"
> > +PLATFORM_dm37x-evm="am37x"
> > +PLATFORM_dm6446-evm="dm644x"
> > +PLATFORM_dm6467-evm="dm646x"
> > +PLATFORM_ti816x="ti816x"
> > +
> > +do_compile () {

I think the coding sytle is without a space before `()`.

> > +    cd ${S}
> > +    make KERNEL_DIR=${STAGING_KERNEL_DIR} PLATFORM=${PLATFORM} TOOL_PREFIX=${TARGET_PREFIX}
> > +}
> > +
> > +do_install () {
> > +    install -d ${D}${bindir}/lftb
> > +    cd ${S}
> 
> is this cd needed ?
> 
> > +    make INSTALL_DIR=${D}${bindir}/lftb install
> > +
> > +    # Remove unneeded tarball placed in bindir by install target
> > +    rm -rf ${D}${bindir}/lftb.tar.gz
> > +}
> > +
> > +INSANE_SKIP_${PN} = True
> > +
> > +FILES_${PN} = "${bindir}/lftb"
> > diff --git a/recipes/ti/ti-lftb_2.0.bb b/recipes/ti/ti-lftb_2.0.bb
> > new file mode 100644
> > index 0000000..62c936c
> > --- /dev/null
> > +++ b/recipes/ti/ti-lftb_2.0.bb
> > @@ -0,0 +1,9 @@
> > +require ti-lftb.inc
> > +
> > +SRCREV = "3d0be58aee659ef7e8eda43e916172bab300235f"
> > +
> > +PR = "${MACHINE_KERNEL_PR}+${INC_PR}"
> > +PR_append = "a"
> > +
> > +SRC_URI = "git://arago-project.org/git/projects/test-automation/target-code/psp/lftb.git;protocol=git \
> > +"


Thanks,

Paul
chase maupin - Dec. 20, 2010, 2:45 p.m.
> -----Original Message-----
> From: Khem Raj [mailto:raj.khem@gmail.com]
> Sent: Sunday, December 19, 2010 9:11 PM
> To: openembedded-devel@lists.openembedded.org
> Cc: Medisetty, Naresh; Maupin, Chase
> Subject: Re: [oe] [PATCH] lftp: add ti LFTB recipe
> 
> On (16/12/10 11:46), Chase Maupin wrote:
> > From: naresh <naresh@ti.com>
> >
> > * This package contains functional test suites for TI devices
> >   used to verify the Linux kernel and drivers for the various
> >   peripherals found on TI devices.
> >
> > Signed-off-by: naresh <naresh@ti.com>
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> > ---
> >  recipes/ti/ti-lftb.inc    |   47
> +++++++++++++++++++++++++++++++++++++++++++++
> >  recipes/ti/ti-lftb_2.0.bb |    9 ++++++++
> >  2 files changed, 56 insertions(+), 0 deletions(-)
> >  create mode 100644 recipes/ti/ti-lftb.inc
> >  create mode 100644 recipes/ti/ti-lftb_2.0.bb
> >
> > diff --git a/recipes/ti/ti-lftb.inc b/recipes/ti/ti-lftb.inc
> > new file mode 100644
> > index 0000000..176f983
> > --- /dev/null
> > +++ b/recipes/ti/ti-lftb.inc
> > @@ -0,0 +1,47 @@
> > +DESCRIPTION = "Linux Functional test bench"
> 
> may be F should be f

Changing to use "Linux Functional Test Bench" to bring out the L F T B.  Thanks for pointing this out.

> 
> > +HOMEPAGE = "http://arago-project.org/git/projects/?p=test-
> automation/target-code/psp/lftb.git;a=summary"
> > +LICENSE="BSD"
> > +
> > +INC_PR = "r1"
> 
> New recipes begin at 'r0'

Good call.  I will change this.

> 
> > +
> > +DEPENDS = "virtual/kernel"
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> > +COMPATIBLE_MACHINE =
> "(dm365|dm355|dm6446|dm6467|omapl137|omapl138|omap3|ti816x)"
> > +
> 
> could it use SOC_FAMILY

These are SOC_FAMILY entries.

> 
> 
> > +S = "${WORKDIR}/git"
> > +
> > +#Machine specific overrides
> > +PLATFORM_omap3evm="omap35x"
> > +PLATFORM_am180x-evm="am18x"
> > +PLATFORM_am3517-evm="am3517"
> > +PLATFORM_am37x-evm="am37x"
> > +PLATFORM_beagleboard="beagle"
> > +PLATFORM_da830-omapl137-evm="am17x"
> > +PLATFORM_da850-omapl138-evm="am18x"
> > +PLATFORM_am181x-evm="am18x"
> > +PLATFORM_dm355-evm="dm355"
> > +PLATFORM_dm365-evm="dm365"
> > +PLATFORM_dm37x-evm="am37x"
> > +PLATFORM_dm6446-evm="dm644x"
> > +PLATFORM_dm6467-evm="dm646x"
> > +PLATFORM_ti816x="ti816x"
> > +
> > +do_compile () {
> > +    cd ${S}
> > +    make KERNEL_DIR=${STAGING_KERNEL_DIR} PLATFORM=${PLATFORM}
> TOOL_PREFIX=${TARGET_PREFIX}
> > +}
> > +
> > +do_install () {
> > +    install -d ${D}${bindir}/lftb
> > +    cd ${S}
> 
> is this cd needed ?

Not strictly.  I'll remove it.

Thanks for the review and feedback.  I'll be submitting an updated patch shortly.

> 
> > +    make INSTALL_DIR=${D}${bindir}/lftb install
> > +
> > +    # Remove unneeded tarball placed in bindir by install target
> > +    rm -rf ${D}${bindir}/lftb.tar.gz
> > +}
> > +
> > +INSANE_SKIP_${PN} = True
> > +
> > +FILES_${PN} = "${bindir}/lftb"
> > diff --git a/recipes/ti/ti-lftb_2.0.bb b/recipes/ti/ti-lftb_2.0.bb
> > new file mode 100644
> > index 0000000..62c936c
> > --- /dev/null
> > +++ b/recipes/ti/ti-lftb_2.0.bb
> > @@ -0,0 +1,9 @@
> > +require ti-lftb.inc
> > +
> > +SRCREV = "3d0be58aee659ef7e8eda43e916172bab300235f"
> > +
> > +PR = "${MACHINE_KERNEL_PR}+${INC_PR}"
> > +PR_append = "a"
> > +
> > +SRC_URI = "git://arago-project.org/git/projects/test-automation/target-
> code/psp/lftb.git;protocol=git \
> > +"
> > --
> > 1.7.0.4
> >
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
chase maupin - Dec. 20, 2010, 2:45 p.m.
> -----Original Message-----

> From: openembedded-devel-bounces@lists.openembedded.org

> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of

> Paul Menzel

> Sent: Monday, December 20, 2010 8:16 AM

> To: openembedded-devel@lists.openembedded.org

> Subject: Re: [oe] [PATCH] lftp: add ti LFTB recipe

> 

> Dear Naresh and Chase,

> 

> 

> I am adding my comments to Khem’s.

> 

> 

> Am Sonntag, den 19.12.2010, 19:10 -0800 schrieb Khem Raj:

> > On (16/12/10 11:46), Chase Maupin wrote:

> 

> First of all the commit summary should be.

> 

> 	lftb: add TI LFTP 2.0

> 

> lft*b*


Good catch.  I can't believe I missed that one.

> 

> > > From: naresh <naresh@ti.com>

> 

> If there is no compelling reason against it usually the real name

> (Naresh Medisetty) is used.

> 

> > > * This package contains functional test suites for TI devices

> > >   used to verify the Linux kernel and drivers for the various

> > >   peripherals found on TI devices.

> > >

> > > Signed-off-by: naresh <naresh@ti.com>

> 

> Here too.


Fixed

> 

> > > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>

> > > ---

> > >  recipes/ti/ti-lftb.inc    |   47

> +++++++++++++++++++++++++++++++++++++++++++++

> > >  recipes/ti/ti-lftb_2.0.bb |    9 ++++++++

> > >  2 files changed, 56 insertions(+), 0 deletions(-)

> > >  create mode 100644 recipes/ti/ti-lftb.inc

> > >  create mode 100644 recipes/ti/ti-lftb_2.0.bb

> > >

> > > diff --git a/recipes/ti/ti-lftb.inc b/recipes/ti/ti-lftb.inc

> > > new file mode 100644

> > > index 0000000..176f983

> > > --- /dev/null

> > > +++ b/recipes/ti/ti-lftb.inc

> > > @@ -0,0 +1,47 @@

> > > +DESCRIPTION = "Linux Functional test bench"

> >

> > may be F should be f

> >

> > > +HOMEPAGE = "http://arago-project.org/git/projects/?p=test-

> automation/target-code/psp/lftb.git;a=summary"

> > > +LICENSE="BSD"

> > > +

> > > +INC_PR = "r1"

> >

> > New recipes begin at 'r0'

> >

> > > +

> > > +DEPENDS = "virtual/kernel"

> > > +

> > > +PACKAGE_ARCH = "${MACHINE_ARCH}"

> > > +

> > > +COMPATIBLE_MACHINE =

> "(dm365|dm355|dm6446|dm6467|omapl137|omapl138|omap3|ti816x)"

> > > +

> >

> > could it use SOC_FAMILY

> >

> >

> > > +S = "${WORKDIR}/git"

> > > +

> > > +#Machine specific overrides

> > > +PLATFORM_omap3evm="omap35x"

> > > +PLATFORM_am180x-evm="am18x"

> > > +PLATFORM_am3517-evm="am3517"

> > > +PLATFORM_am37x-evm="am37x"

> > > +PLATFORM_beagleboard="beagle"

> > > +PLATFORM_da830-omapl137-evm="am17x"

> > > +PLATFORM_da850-omapl138-evm="am18x"

> > > +PLATFORM_am181x-evm="am18x"

> > > +PLATFORM_dm355-evm="dm355"

> > > +PLATFORM_dm365-evm="dm365"

> > > +PLATFORM_dm37x-evm="am37x"

> > > +PLATFORM_dm6446-evm="dm644x"

> > > +PLATFORM_dm6467-evm="dm646x"

> > > +PLATFORM_ti816x="ti816x"

> > > +

> > > +do_compile () {

> 

> I think the coding sytle is without a space before `()`.


Fixed.

Thanks for the review and feedback.  I'll be submitting a new patch shortly.

> 

> > > +    cd ${S}

> > > +    make KERNEL_DIR=${STAGING_KERNEL_DIR} PLATFORM=${PLATFORM}

> TOOL_PREFIX=${TARGET_PREFIX}

> > > +}

> > > +

> > > +do_install () {

> > > +    install -d ${D}${bindir}/lftb

> > > +    cd ${S}

> >

> > is this cd needed ?

> >

> > > +    make INSTALL_DIR=${D}${bindir}/lftb install

> > > +

> > > +    # Remove unneeded tarball placed in bindir by install target

> > > +    rm -rf ${D}${bindir}/lftb.tar.gz

> > > +}

> > > +

> > > +INSANE_SKIP_${PN} = True

> > > +

> > > +FILES_${PN} = "${bindir}/lftb"

> > > diff --git a/recipes/ti/ti-lftb_2.0.bb b/recipes/ti/ti-lftb_2.0.bb

> > > new file mode 100644

> > > index 0000000..62c936c

> > > --- /dev/null

> > > +++ b/recipes/ti/ti-lftb_2.0.bb

> > > @@ -0,0 +1,9 @@

> > > +require ti-lftb.inc

> > > +

> > > +SRCREV = "3d0be58aee659ef7e8eda43e916172bab300235f"

> > > +

> > > +PR = "${MACHINE_KERNEL_PR}+${INC_PR}"

> > > +PR_append = "a"

> > > +

> > > +SRC_URI = "git://arago-project.org/git/projects/test-

> automation/target-code/psp/lftb.git;protocol=git \

> > > +"

> 

> 

> Thanks,

> 

> Paul

Patch

diff --git a/recipes/ti/ti-lftb.inc b/recipes/ti/ti-lftb.inc
new file mode 100644
index 0000000..176f983
--- /dev/null
+++ b/recipes/ti/ti-lftb.inc
@@ -0,0 +1,47 @@ 
+DESCRIPTION = "Linux Functional test bench"
+HOMEPAGE = "http://arago-project.org/git/projects/?p=test-automation/target-code/psp/lftb.git;a=summary"
+LICENSE="BSD"
+
+INC_PR = "r1"
+
+DEPENDS = "virtual/kernel"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+COMPATIBLE_MACHINE = "(dm365|dm355|dm6446|dm6467|omapl137|omapl138|omap3|ti816x)"
+
+S = "${WORKDIR}/git"
+
+#Machine specific overrides
+PLATFORM_omap3evm="omap35x"
+PLATFORM_am180x-evm="am18x"
+PLATFORM_am3517-evm="am3517"
+PLATFORM_am37x-evm="am37x"
+PLATFORM_beagleboard="beagle"
+PLATFORM_da830-omapl137-evm="am17x"
+PLATFORM_da850-omapl138-evm="am18x"
+PLATFORM_am181x-evm="am18x"
+PLATFORM_dm355-evm="dm355"
+PLATFORM_dm365-evm="dm365"
+PLATFORM_dm37x-evm="am37x"
+PLATFORM_dm6446-evm="dm644x"
+PLATFORM_dm6467-evm="dm646x"
+PLATFORM_ti816x="ti816x"
+
+do_compile () {
+    cd ${S}
+    make KERNEL_DIR=${STAGING_KERNEL_DIR} PLATFORM=${PLATFORM} TOOL_PREFIX=${TARGET_PREFIX}
+}
+
+do_install () {
+    install -d ${D}${bindir}/lftb
+    cd ${S}
+    make INSTALL_DIR=${D}${bindir}/lftb install
+
+    # Remove unneeded tarball placed in bindir by install target
+    rm -rf ${D}${bindir}/lftb.tar.gz
+}
+
+INSANE_SKIP_${PN} = True
+
+FILES_${PN} = "${bindir}/lftb"
diff --git a/recipes/ti/ti-lftb_2.0.bb b/recipes/ti/ti-lftb_2.0.bb
new file mode 100644
index 0000000..62c936c
--- /dev/null
+++ b/recipes/ti/ti-lftb_2.0.bb
@@ -0,0 +1,9 @@ 
+require ti-lftb.inc
+
+SRCREV = "3d0be58aee659ef7e8eda43e916172bab300235f"
+
+PR = "${MACHINE_KERNEL_PR}+${INC_PR}"
+PR_append = "a"
+
+SRC_URI = "git://arago-project.org/git/projects/test-automation/target-code/psp/lftb.git;protocol=git \
+"