Patchwork [meta-oe] md5deep: Add Recipe for md5deep package version 4.4

login
register
mail settings
Submitter Sven Ebenfeld
Date Aug. 25, 2014, 7:56 a.m.
Message ID <1408953391-25759-1-git-send-email-sven.ebenfeld@gmail.com>
Download mbox | patch
Permalink /patch/78897/
State New
Headers show

Comments

Sven Ebenfeld - Aug. 25, 2014, 7:56 a.m.
I need to build hashdeep/md5deep within OE to include it in my images. This recipe enables OE to cross-compile md5deep. I needed to add the patch as do_configure_qa is complaining about cross-compilation errors otherwise. I added a pull request for the issue with the variable expansion to hashdeep as well.

Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
---
 .../md5deep/files/wrong-variable-expansion.patch   | 39 ++++++++++++++++++++++
 meta-oe/recipes-extended/md5deep/md5deep_4.4.bb    | 16 +++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
 create mode 100644 meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
Martin Jansa - Aug. 25, 2014, 10:14 a.m.
On Mon, Aug 25, 2014 at 09:56:31AM +0200, Sven Ebenfeld wrote:
> I need to build hashdeep/md5deep within OE to include it in my images. This recipe enables OE to cross-compile md5deep. I needed to add the patch as do_configure_qa is complaining about cross-compilation errors otherwise. I added a pull request for the issue with the variable expansion to hashdeep as well.

Please send this to openembedded-devel@lists.openembedded.org


> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
> ---
>  .../md5deep/files/wrong-variable-expansion.patch   | 39 ++++++++++++++++++++++
>  meta-oe/recipes-extended/md5deep/md5deep_4.4.bb    | 16 +++++++++
>  2 files changed, 55 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
>  create mode 100644 meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
> 
> diff --git a/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
> new file mode 100644
> index 0000000..3a4c4f4
> --- /dev/null
> +++ b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
> @@ -0,0 +1,39 @@
> +--- a/configure.ac	2014-08-22 12:22:54.290884351 +0200
> ++++ b/configure.ac	2014-08-22 12:23:15.822306295 +0200
> +@@ -42,18 +42,6 @@
> +      ;;		 		     
> + esac
> + 
> +-
> +-# Bring additional directories where things might be found into our
> +-# search path. I don't know why autoconf doesn't do this by default
> +-if test x"${mingw}" == "xno" ; then
> +-  for spfx in /usr/local /opt/local /sw ; do
> +-    echo checking ${spfx}/include
> +-    if test -d ${spfx}/include; then
> +-        CPPFLAGS="-I${spfx}/include $CPPFLAGS"
> +-        LDFLAGS="-L${spfx}/lib $LDFLAGS"
> +-    fi
> +-  done
> +-fi
> + #
> + #
> + ################################################################
> +@@ -71,7 +59,7 @@
> + 
> + if test $mingw = "no" ; then
> +   # add the warnings we don't want to do on mingw
> +-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
> ++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
> + fi
> + 
> + for option in $WARNINGS_TO_TEST
> +@@ -105,7 +93,7 @@
> + 
> + if test $mingw = "no" ; then
> +   # add the warnings we don't want to do on mingw
> +-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
> ++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
> + fi
> + 
> + for option in $WARNINGS_TO_TEST
> diff --git a/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
> new file mode 100644
> index 0000000..4e4a2f5
> --- /dev/null
> +++ b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
> @@ -0,0 +1,16 @@
> +DESCRIPTION = "md5deep"

Please use better description than just PN (and use SUMMARY if it's
still short).

> +AUTHOR = "Jesse Kornblum, Simson L. Garfinkel"
> +HOMEPAGE = "http://md5deep.sourceforge.net"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=9190f660105b9a56cdb272309bfd5491"
> +
> +inherit autotools
> +
> +SRC_URI = "git://github.com/jessek/hashdeep.git \
> +        file://wrong-variable-expansion.patch \
> +        "
> +
> +# Release 4.4
> +SRCREV = "cd2ed7416685a5e83eb10bb659d6e9bec01244ae"
> +
> +S = "${WORKDIR}/git"
> -- 
> 1.8.1.rc3
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Sven Ebenfeld - Aug. 25, 2014, 10:51 a.m.
Thank you, I've posted an updated patch to openembedded-devel mailing list.

2014-08-25 12:14 GMT+02:00 Martin Jansa <martin.jansa@gmail.com>:
> On Mon, Aug 25, 2014 at 09:56:31AM +0200, Sven Ebenfeld wrote:
>> I need to build hashdeep/md5deep within OE to include it in my images. This recipe enables OE to cross-compile md5deep. I needed to add the patch as do_configure_qa is complaining about cross-compilation errors otherwise. I added a pull request for the issue with the variable expansion to hashdeep as well.
>
> Please send this to openembedded-devel@lists.openembedded.org
>
>
>> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
>> ---
>>  .../md5deep/files/wrong-variable-expansion.patch   | 39 ++++++++++++++++++++++
>>  meta-oe/recipes-extended/md5deep/md5deep_4.4.bb    | 16 +++++++++
>>  2 files changed, 55 insertions(+)
>>  create mode 100644 meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
>>  create mode 100644 meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
>>
>> diff --git a/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
>> new file mode 100644
>> index 0000000..3a4c4f4
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
>> @@ -0,0 +1,39 @@
>> +--- a/configure.ac   2014-08-22 12:22:54.290884351 +0200
>> ++++ b/configure.ac   2014-08-22 12:23:15.822306295 +0200
>> +@@ -42,18 +42,6 @@
>> +      ;;
>> + esac
>> +
>> +-
>> +-# Bring additional directories where things might be found into our
>> +-# search path. I don't know why autoconf doesn't do this by default
>> +-if test x"${mingw}" == "xno" ; then
>> +-  for spfx in /usr/local /opt/local /sw ; do
>> +-    echo checking ${spfx}/include
>> +-    if test -d ${spfx}/include; then
>> +-        CPPFLAGS="-I${spfx}/include $CPPFLAGS"
>> +-        LDFLAGS="-L${spfx}/lib $LDFLAGS"
>> +-    fi
>> +-  done
>> +-fi
>> + #
>> + #
>> + ################################################################
>> +@@ -71,7 +59,7 @@
>> +
>> + if test $mingw = "no" ; then
>> +   # add the warnings we don't want to do on mingw
>> +-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
>> ++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
>> + fi
>> +
>> + for option in $WARNINGS_TO_TEST
>> +@@ -105,7 +93,7 @@
>> +
>> + if test $mingw = "no" ; then
>> +   # add the warnings we don't want to do on mingw
>> +-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
>> ++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
>> + fi
>> +
>> + for option in $WARNINGS_TO_TEST
>> diff --git a/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
>> new file mode 100644
>> index 0000000..4e4a2f5
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
>> @@ -0,0 +1,16 @@
>> +DESCRIPTION = "md5deep"
>
> Please use better description than just PN (and use SUMMARY if it's
> still short).
>
>> +AUTHOR = "Jesse Kornblum, Simson L. Garfinkel"
>> +HOMEPAGE = "http://md5deep.sourceforge.net"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=9190f660105b9a56cdb272309bfd5491"
>> +
>> +inherit autotools
>> +
>> +SRC_URI = "git://github.com/jessek/hashdeep.git \
>> +        file://wrong-variable-expansion.patch \
>> +        "
>> +
>> +# Release 4.4
>> +SRCREV = "cd2ed7416685a5e83eb10bb659d6e9bec01244ae"
>> +
>> +S = "${WORKDIR}/git"
>> --
>> 1.8.1.rc3
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
Sven Ebenfeld - Aug. 28, 2014, 9:39 a.m.
Am 25.08.2014 12:14, schrieb Martin Jansa:
> On Mon, Aug 25, 2014 at 09:56:31AM +0200, Sven Ebenfeld wrote:
>> I need to build hashdeep/md5deep within OE to include it in my images. This recipe enables OE to cross-compile md5deep. I needed to add the patch as do_configure_qa is complaining about cross-compilation errors otherwise. I added a pull request for the issue with the variable expansion to hashdeep as well.
> 
> Please send this to openembedded-devel@lists.openembedded.org
> 
> 

Did I understand this right, that I should send the whole patch to
OE-Devel ML? Or should I've sent anything else?
Martin Jansa - Aug. 28, 2014, 2:36 p.m.
On Thu, Aug 28, 2014 at 11:39:27AM +0200, Sven Ebenfeld wrote:
> Am 25.08.2014 12:14, schrieb Martin Jansa:
> > On Mon, Aug 25, 2014 at 09:56:31AM +0200, Sven Ebenfeld wrote:
> >> I need to build hashdeep/md5deep within OE to include it in my images. This recipe enables OE to cross-compile md5deep. I needed to add the patch as do_configure_qa is complaining about cross-compilation errors otherwise. I added a pull request for the issue with the variable expansion to hashdeep as well.
> > 
> > Please send this to openembedded-devel@lists.openembedded.org
> > 
> > 
> 
> Did I understand this right, that I should send the whole patch to
> OE-Devel ML? Or should I've sent anything else?

Whole patch as it was sent and picked by patchwork:
http://patchwork.openembedded.org/patch/78901/

it was merged in master-next few days ago.
Sven Ebenfeld - Aug. 28, 2014, 7:43 p.m.
Am 28.08.2014 16:36, schrieb Martin Jansa:
> On Thu, Aug 28, 2014 at 11:39:27AM +0200, Sven Ebenfeld wrote:
>> Am 25.08.2014 12:14, schrieb Martin Jansa:
>>> On Mon, Aug 25, 2014 at 09:56:31AM +0200, Sven Ebenfeld wrote:
>>>> I need to build hashdeep/md5deep within OE to include it in my images. This recipe enables OE to cross-compile md5deep. I needed to add the patch as do_configure_qa is complaining about cross-compilation errors otherwise. I added a pull request for the issue with the variable expansion to hashdeep as well.
>>>
>>> Please send this to openembedded-devel@lists.openembedded.org
>>>
>>>
>>
>> Did I understand this right, that I should send the whole patch to
>> OE-Devel ML? Or should I've sent anything else?
> 
> Whole patch as it was sent and picked by patchwork:
> http://patchwork.openembedded.org/patch/78901/
> 
> it was merged in master-next few days ago.
> 

Oh, I didn't see that, that's good news. Thanks!
Is it possible to get that patch into dora and daisy branch as well?
Unfortunately we are still developing in dora branch atm but I hope to
switch to daisy branch in near future.

Patch

diff --git a/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
new file mode 100644
index 0000000..3a4c4f4
--- /dev/null
+++ b/meta-oe/recipes-extended/md5deep/files/wrong-variable-expansion.patch
@@ -0,0 +1,39 @@ 
+--- a/configure.ac	2014-08-22 12:22:54.290884351 +0200
++++ b/configure.ac	2014-08-22 12:23:15.822306295 +0200
+@@ -42,18 +42,6 @@
+      ;;		 		     
+ esac
+ 
+-
+-# Bring additional directories where things might be found into our
+-# search path. I don't know why autoconf doesn't do this by default
+-if test x"${mingw}" == "xno" ; then
+-  for spfx in /usr/local /opt/local /sw ; do
+-    echo checking ${spfx}/include
+-    if test -d ${spfx}/include; then
+-        CPPFLAGS="-I${spfx}/include $CPPFLAGS"
+-        LDFLAGS="-L${spfx}/lib $LDFLAGS"
+-    fi
+-  done
+-fi
+ #
+ #
+ ################################################################
+@@ -71,7 +59,7 @@
+ 
+ if test $mingw = "no" ; then
+   # add the warnings we don't want to do on mingw
+-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST -Wall -Wstrict-prototypes  -Weffc++"
+ fi
+ 
+ for option in $WARNINGS_TO_TEST
+@@ -105,7 +93,7 @@
+ 
+ if test $mingw = "no" ; then
+   # add the warnings we don't want to do on mingw
+-  $WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
++  WARNINGS_TO_TEST="$WARNINGS_TO_TEST  -Weffc++"
+ fi
+ 
+ for option in $WARNINGS_TO_TEST
diff --git a/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
new file mode 100644
index 0000000..4e4a2f5
--- /dev/null
+++ b/meta-oe/recipes-extended/md5deep/md5deep_4.4.bb
@@ -0,0 +1,16 @@ 
+DESCRIPTION = "md5deep"
+AUTHOR = "Jesse Kornblum, Simson L. Garfinkel"
+HOMEPAGE = "http://md5deep.sourceforge.net"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=9190f660105b9a56cdb272309bfd5491"
+
+inherit autotools
+
+SRC_URI = "git://github.com/jessek/hashdeep.git \
+        file://wrong-variable-expansion.patch \
+        "
+
+# Release 4.4
+SRCREV = "cd2ed7416685a5e83eb10bb659d6e9bec01244ae"
+
+S = "${WORKDIR}/git"