Patchwork [v2,07/12] udev-cache: Don't ignore error messages from cache extract

login
register
mail settings
Submitter Richard Tollerton
Date Aug. 22, 2014, 9:30 p.m.
Message ID <50419b4dad83cfabaf5f17c40ffc45012c2117b5.1408742574.git.rich.tollerton@ni.com>
Download mbox | patch
Permalink /patch/78843/
State Accepted
Commit 7c56a5e728f4c5adb3c9df7cf3cb2da782e3c94c
Headers show

Comments

Richard Tollerton - Aug. 22, 2014, 9:30 p.m.
Previous changes should obviate all known spurious errors coming out of
tar. Since real extraction failures can and will occur, stop redirecting
stdout/stderr to /dev/null.

Take this opportunity to also remove an unnecessary subshell.

Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
---
 meta/recipes-core/udev/udev/init | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
index 4a6df6e..1d073c2 100644
--- a/meta/recipes-core/udev/udev/init
+++ b/meta/recipes-core/udev/udev/init
@@ -69,7 +69,7 @@  case "$1" in
 		    readfiles /etc/udev/cache.data
 		    OLDDATA="$READDATA"
 		    if [ "$OLDDATA" = "$NEWDATA" ]; then
-                            (cd /; tar xmf $DEVCACHE > /dev/null 2>&1)
+                            tar xmf $DEVCACHE -C / -m
                             not_first_boot=1
                             [ "$VERBOSE" != "no" ] && echo "udev: using cache file $DEVCACHE"
                             [ -e /dev/shm/udev.cache ] && rm -f /dev/shm/udev.cache