Patchwork [meta-oe] lmbench: remove debianutils from RDEPENDS and add perl

login
register
mail settings
Submitter jackie huang
Date Aug. 21, 2014, 9:20 a.m.
Message ID <1408612843-22017-1-git-send-email-jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/78735/
State Accepted, archived
Headers show

Comments

jackie huang - Aug. 21, 2014, 9:20 a.m.
From: Jackie Huang <jackie.huang@windriver.com>

- I don't see any evdidence that lmbench needs debianutils to run:
  debianutils provides:
    run-parts, tempfile, savelog, which, ischroot,
    add-shell, installkernel, remove-shell
  but none of them is used by lmbench scripts and I tested it work
  fine without debianutils, so remove debianutils from RDEPENDS

- Some scripts in lmbench are perl scripts, so add
  RDEPENDS on perl (no addtional perl module is needed).

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - Aug. 21, 2014, 7:31 p.m.
On Thu, Aug 21, 2014 at 05:20:43AM -0400, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> - I don't see any evdidence that lmbench needs debianutils to run:
>   debianutils provides:
>     run-parts, tempfile, savelog, which, ischroot,
>     add-shell, installkernel, remove-shell
>   but none of them is used by lmbench scripts and I tested it work
>   fine without debianutils, so remove debianutils from RDEPENDS

Lets see how far Tom's memory goes :)

commit 6dbe8d71c465fdf86310ca7f83332ff32baf12f5
Author: Tom Rini <trini@embeddedalley.com>
Date:   Fri Feb 13 01:14:22 2009 -0500

    lmbench: Fix config file location in lmbench-run add RDEP on debianutils, bump PR

> 
> - Some scripts in lmbench are perl scripts, so add
>   RDEPENDS on perl (no addtional perl module is needed).
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
> index 38e0d2e..0586d72 100644
> --- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
> +++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
> @@ -74,5 +74,5 @@ pkg_postinst_${PN} () {
>      fi
>  }
>  
> -RDEPENDS_${PN} = "debianutils"
> +RDEPENDS_${PN} = "perl"
>  FILES_${PN} += "${datadir}/lmbench ${libdir}/lmbench"
> -- 
> 2.0.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj - Aug. 25, 2014, 6:37 a.m.
On 14-08-21 21:31:42, Martin Jansa wrote:
> On Thu, Aug 21, 2014 at 05:20:43AM -0400, jackie.huang@windriver.com wrote:
> > From: Jackie Huang <jackie.huang@windriver.com>
> > 
> > - I don't see any evdidence that lmbench needs debianutils to run:
> >   debianutils provides:
> >     run-parts, tempfile, savelog, which, ischroot,
> >     add-shell, installkernel, remove-shell
> >   but none of them is used by lmbench scripts and I tested it work
> >   fine without debianutils, so remove debianutils from RDEPENDS
> 
> Lets see how far Tom's memory goes :)
> 
> commit 6dbe8d71c465fdf86310ca7f83332ff32baf12f5
> Author: Tom Rini <trini@embeddedalley.com>
> Date:   Fri Feb 13 01:14:22 2009 -0500
> 
>     lmbench: Fix config file location in lmbench-run add RDEP on debianutils, bump PR
> 

that was lmbench2 and probably some config script might have needed it
but clearly I dont see any need for it now with lmbench3

Patch

diff --git a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
index 38e0d2e..0586d72 100644
--- a/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
+++ b/meta-oe/recipes-benchmark/lmbench/lmbench_3.0-a9.bb
@@ -74,5 +74,5 @@  pkg_postinst_${PN} () {
     fi
 }
 
-RDEPENDS_${PN} = "debianutils"
+RDEPENDS_${PN} = "perl"
 FILES_${PN} += "${datadir}/lmbench ${libdir}/lmbench"