Patchwork [meta-python] python-pyparted: Add recipe

login
register
mail settings
Submitter Sujith H
Date Aug. 21, 2014, 6:46 a.m.
Message ID <1408603607-32536-1-git-send-email-sujith.h@gmail.com>
Download mbox | patch
Permalink /patch/78727/
State Accepted, archived
Headers show

Comments

Sujith H - Aug. 21, 2014, 6:46 a.m.
From: Sujith H <Sujith_Haridasan@mentor.com>

This recipe will provide a set of Python modules that
provide Python programmers an interface to libparted,
the GNU parted library for disk partitioning and filesystem
manipulation.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
---
 .../python-pyparted/python-pyparted_3.9.bb          | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
Paul Eggleton - Aug. 21, 2014, 1:47 p.m.
Hi Sujith,

I think this recipe is almost there, just some minor tweaks:

On Thursday 21 August 2014 12:16:47 Sujith H wrote:
> From: Sujith H <Sujith_Haridasan@mentor.com>
> 
> This recipe will provide a set of Python modules that
> provide Python programmers an interface to libparted,
> the GNU parted library for disk partitioning and filesystem
> manipulation.
> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
> ---
>  .../python-pyparted/python-pyparted_3.9.bb          | 21
> +++++++++++++++++++++ 1 file changed, 21 insertions(+)
>  create mode 100644
> meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
> 
> diff --git
> a/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
> b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb new
> file mode 100644
> index 0000000..db1b936
> --- /dev/null
> +++ b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
> @@ -0,0 +1,21 @@
> +DESCRIPTION = "pyparted is a set of Python modules that provide Python
> programmers \ +an interface to libparted, the GNU parted library for disk
> partitioning and \ +filesystem manipulation."
> +SUMMARY = "Python bindings for libparted"
> +HOMEPAGE = "https://fedorahosted.org/pyparted/"
> +LICENSE = "GPL-2.0+"
> +LIC_FILES_CHKSUM = "\
> +    file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
> +   
> file://src/_pedmodule.c;startline=10;endline=22;md5=70c62bd73782a03f56a0571
> a9f08ea46 \ +"
> +DEPENDS += "parted"
> +RDEPENDS_${PN} += "python-stringold python-codecs python-math"

Could you please move the RDEPENDS line down to just before the BBCLASSEXTEND 
line? (i.e. where any other definitions that concern packaging would appear).

> +
> +S="${WORKDIR}/pyparted-${PV}"

Please move this after the SRC_URI / checksums and add spaces around the = .

if you could also please ensure that your next version is marked [PATCH v3] 
(if it will be the third version of this patch) rather than just [PATCH] so 
that it's clear that it supersedes an earlier version.

Thanks,
Paul
Tim Orling - Aug. 22, 2014, 4:36 a.m.
On Thu, Aug 21, 2014 at 6:47 AM, Paul Eggleton <
paul.eggleton@linux.intel.com> wrote:

> Hi Sujith,
>
> I think this recipe is almost there, just some minor tweaks:
>
> On Thursday 21 August 2014 12:16:47 Sujith H wrote:
> > From: Sujith H <Sujith_Haridasan@mentor.com>
> >
> > This recipe will provide a set of Python modules that
> > provide Python programmers an interface to libparted,
> > the GNU parted library for disk partitioning and filesystem
> > manipulation.
> >
> > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> > Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
>
Tested-by: Tim Orling <TicoTimo@gmail.com>
(qemuarm, core-image-sato)

NOTES:
(1) In order to get help for this module,
IMAGE_INSTALL_append = " python-pyparted python-pydoc python-pkgutil
python-io"
$ python
>>>import parted
>>>help(parted)

(2) I used the examples (list_devices.py, list_partitions.py) from the
following to test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692503

 > ---
> >  .../python-pyparted/python-pyparted_3.9.bb          | 21
> > +++++++++++++++++++++ 1 file changed, 21 insertions(+)
> >  create mode 100644
> > meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
> >
> > diff --git
> > a/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
> > b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
> new
> > file mode 100644
> > index 0000000..db1b936
> > --- /dev/null
> > +++ b/meta-python/recipes-extended/python-pyparted/
> python-pyparted_3.9.bb
> > @@ -0,0 +1,21 @@
> > +DESCRIPTION = "pyparted is a set of Python modules that provide Python
> > programmers \ +an interface to libparted, the GNU parted library for disk
> > partitioning and \ +filesystem manipulation."
> > +SUMMARY = "Python bindings for libparted"
> > +HOMEPAGE = "https://fedorahosted.org/pyparted/"
> > +LICENSE = "GPL-2.0+"
> > +LIC_FILES_CHKSUM = "\
> > +    file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
> > +
> >
> file://src/_pedmodule.c;startline=10;endline=22;md5=70c62bd73782a03f56a0571
> > a9f08ea46 \ +"
> > +DEPENDS += "parted"
> > +RDEPENDS_${PN} += "python-stringold python-codecs python-math"
>
> Could you please move the RDEPENDS line down to just before the
> BBCLASSEXTEND
> line? (i.e. where any other definitions that concern packaging would
> appear).
>
> > +
> > +S="${WORKDIR}/pyparted-${PV}"
>
> Please move this after the SRC_URI / checksums and add spaces around the =
> .
>
> if you could also please ensure that your next version is marked [PATCH v3]
> (if it will be the third version of this patch) rather than just [PATCH] so
> that it's clear that it supersedes an earlier version.
>

I agree completely with Paul and meant to mention that on the previous
patch [PATCH v2].

Regards,

Tim
Sujith H - Aug. 22, 2014, 6:19 a.m.
On Fri, Aug 22, 2014 at 10:06 AM, Tim Orling <ticotimo@gmail.com> wrote:

>
> On Thu, Aug 21, 2014 at 6:47 AM, Paul Eggleton <
> paul.eggleton@linux.intel.com> wrote:
>
>> Hi Sujith,
>>
>> I think this recipe is almost there, just some minor tweaks:
>>
>> On Thursday 21 August 2014 12:16:47 Sujith H wrote:
>> > From: Sujith H <Sujith_Haridasan@mentor.com>
>> >
>> > This recipe will provide a set of Python modules that
>> > provide Python programmers an interface to libparted,
>> > the GNU parted library for disk partitioning and filesystem
>> > manipulation.
>> >
>> > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
>> > Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
>>
> Tested-by: Tim Orling <TicoTimo@gmail.com>
> (qemuarm, core-image-sato)
>
> NOTES:
> (1) In order to get help for this module,
> IMAGE_INSTALL_append = " python-pyparted python-pydoc python-pkgutil
> python-io"
> $ python
> >>>import parted
> >>>help(parted)
>
> (2) I used the examples (list_devices.py, list_partitions.py) from the
> following to test:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692503
>
>  > ---
>> >  .../python-pyparted/python-pyparted_3.9.bb          | 21
>> > +++++++++++++++++++++ 1 file changed, 21 insertions(+)
>> >  create mode 100644
>> > meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
>> >
>> > diff --git
>> > a/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
>> > b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
>> new
>> > file mode 100644
>> > index 0000000..db1b936
>> > --- /dev/null
>> > +++ b/meta-python/recipes-extended/python-pyparted/
>> python-pyparted_3.9.bb
>> > @@ -0,0 +1,21 @@
>> > +DESCRIPTION = "pyparted is a set of Python modules that provide Python
>> > programmers \ +an interface to libparted, the GNU parted library for
>> disk
>> > partitioning and \ +filesystem manipulation."
>> > +SUMMARY = "Python bindings for libparted"
>> > +HOMEPAGE = "https://fedorahosted.org/pyparted/"
>> > +LICENSE = "GPL-2.0+"
>> > +LIC_FILES_CHKSUM = "\
>> > +    file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>> > +
>> >
>> file://src/_pedmodule.c;startline=10;endline=22;md5=70c62bd73782a03f56a0571
>> > a9f08ea46 \ +"
>> > +DEPENDS += "parted"
>> > +RDEPENDS_${PN} += "python-stringold python-codecs python-math"
>>
>> Could you please move the RDEPENDS line down to just before the
>> BBCLASSEXTEND
>> line? (i.e. where any other definitions that concern packaging would
>> appear).
>>
>> > +
>> > +S="${WORKDIR}/pyparted-${PV}"
>>
>> Please move this after the SRC_URI / checksums and add spaces around the
>> = .
>>
>> if you could also please ensure that your next version is marked [PATCH
>> v3]
>> (if it will be the third version of this patch) rather than just [PATCH]
>> so
>> that it's clear that it supersedes an earlier version.
>>
>
> I agree completely with Paul and meant to mention that on the previous
> patch [PATCH v2].
>

Sure the next patch will be mentioned as [PATCH v3].

Thanks and Regards,

Sujith H

Patch

diff --git a/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
new file mode 100644
index 0000000..db1b936
--- /dev/null
+++ b/meta-python/recipes-extended/python-pyparted/python-pyparted_3.9.bb
@@ -0,0 +1,21 @@ 
+DESCRIPTION = "pyparted is a set of Python modules that provide Python programmers \
+an interface to libparted, the GNU parted library for disk partitioning and \
+filesystem manipulation."
+SUMMARY = "Python bindings for libparted"
+HOMEPAGE = "https://fedorahosted.org/pyparted/"
+LICENSE = "GPL-2.0+"
+LIC_FILES_CHKSUM = "\
+    file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
+    file://src/_pedmodule.c;startline=10;endline=22;md5=70c62bd73782a03f56a0571a9f08ea46 \
+"
+DEPENDS += "parted"
+RDEPENDS_${PN} += "python-stringold python-codecs python-math"
+
+S="${WORKDIR}/pyparted-${PV}"
+SRC_URI = "https://fedorahosted.org/releases/p/y/pyparted/pyparted-${PV}.tar.gz"
+SRC_URI[md5sum] = "f16c7ef7f5fa4a43fcb2a4654b487e39"
+SRC_URI[sha256sum] = "a56712e3d058ce3d859c158236dbbf45224018919efd3d880ea80f9e0d0bebbb"
+
+inherit distutils
+
+BBCLASSEXTEND += "native"