Patchwork [META-OE,1/1] oscam: fixed QA issue where binary was being stripped

login
register
mail settings
Submitter Tom King
Date Aug. 21, 2014, 6:13 a.m.
Message ID <CAHQecY6bxmkDi3U6nN3MhF4x6-ysPnXyb0nwrjXwq3-xX5NdcQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/78725/
State Accepted, archived
Headers show

Comments

Tom King - Aug. 21, 2014, 6:13 a.m.
http://lists.openembedded.org/pipermail/openembedded-core/2014-August/095778.html

WARNING: QA Issue: File '/usr/bin/oscam' from oscam was already stripped,
this
will prevent future debugging! [already-stripped]

Fix above warning by telling cmake to do Debug type build, which prevents
linking with '-s' flag that removed symbols before bitbake could put them
into dbg package.

Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
Signed-off-by: Tom King<ka6sox@gmail.com>
---
 meta-multimedia/recipes-dvb/oscam/oscam_svn.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
1.7.9.5
Koen Kooi - Aug. 21, 2014, 7:44 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tom King schreef op 21-08-14 08:13:
> http://lists.openembedded.org/pipermail/openembedded-core/2014-August/095778.html
>
>  WARNING: QA Issue: File '/usr/bin/oscam' from oscam was already
> stripped, this will prevent future debugging! [already-stripped]
> 
> Fix above warning by telling cmake to do Debug type build, which
> prevents linking with '-s' flag that removed symbols before bitbake could
> put them into dbg package.
> 
> Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com> Signed-off-by: Tom
> King<ka6sox@gmail.com> --- meta-multimedia/recipes-dvb/oscam/oscam_svn.bb
> |    2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb 
> b/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb index e3f2708..c4a4d99
> 100644 --- a/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb +++
> b/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb @@ -14,5 +14,5 @@ S =
> "${WORKDIR}/trunk"
> 
> inherit cmake
> 
> -EXTRA_OECMAKE = "-DDEFAULT_CS_CONFDIR=${sysconfdir}" +EXTRA_OECMAKE =
> "-DDEFAULT_CS_CONFDIR=${sysconfdir} -DCMAKE_BUILD_TYPE=Debug"

Whitespace damage due to mailer?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFT9aN7MkyGM64RGpERAocuAJ41630bimczFzLdBtpxDkCRY33h6QCeO80c
myBws3uS1pXaavua8+O9vo8=
=xjKT
-----END PGP SIGNATURE-----

Patch

diff --git a/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb
 b/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb
index e3f2708..c4a4d99 100644
--- a/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb
+++ b/meta-multimedia/recipes-dvb/oscam/oscam_svn.bb
@@ -14,5 +14,5 @@  S = "${WORKDIR}/trunk"

 inherit cmake

-EXTRA_OECMAKE = "-DDEFAULT_CS_CONFDIR=${sysconfdir}"
+EXTRA_OECMAKE = "-DDEFAULT_CS_CONFDIR=${sysconfdir}
-DCMAKE_BUILD_TYPE=Debug"