Patchwork [2/2] gdb-cross-canadian: add nativesdk-ncurses-libncurses to RDEPENDS

login
register
mail settings
Submitter Robert Yang
Date Aug. 15, 2014, 8:49 a.m.
Message ID <2209793d9f1cb962c181308634d3c2f36f9869fc.1408092524.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/78337/
State New
Headers show

Comments

Robert Yang - Aug. 15, 2014, 8:49 a.m.
We had nativesdk-ncurses in the DEPENDS, also need add
nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5
is not in the rdepends chain.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Richard Purdie - Aug. 15, 2014, 8:54 a.m.
On Fri, 2014-08-15 at 01:49 -0700, Robert Yang wrote:
> We had nativesdk-ncurses in the DEPENDS, also need add
> nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5
> is not in the rdepends chain.

This doesn't make sense. Can you please give more information about the
problem you're solving here please?

If its a dynamically linked lib, the dependency should be detected
automatically.

Cheers,

Richard

> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> index e594bb1..2be427a 100644
> --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> @@ -7,7 +7,9 @@ BPN = "gdb"
>  
>  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-readline nativesdk-python"
>  RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
> -                   nativesdk-python-codecs nativesdk-python-netclient"
> +                   nativesdk-python-codecs nativesdk-python-netclient \
> +                   nativesdk-ncurses-libncurses \
> +                  "
>  
>  GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
>  
> -- 
> 1.7.9.5
>
Robert Yang - Aug. 15, 2014, 10:47 a.m.
On 08/15/2014 04:54 PM, Richard Purdie wrote:
> On Fri, 2014-08-15 at 01:49 -0700, Robert Yang wrote:
>> We had nativesdk-ncurses in the DEPENDS, also need add
>> nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5
>> is not in the rdepends chain.
>
> This doesn't make sense. Can you please give more information about the
> problem you're solving here please?

Sorry, I should put more info in the commit message. Yes, it doesn't
make sense to package_rpm, but makes sense to package_ipk (verified)
and package_deb (not yet verified).

My host is X86_64 (doesn't matter)

# Make sure it is a clean build
$ bitbake meta-toolchain -ccleansstate

$ bitbake meta-toolchain

$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep 
poky-linux-gdb
tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/opt/poky/1.6+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/x86_64-poky-linux/x86_64-poky-linux-gdb
#### Note gdb-cross has been installed

$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
### No output, libncurses.so isn't installed.

And if we use PACKAGE_CLASSES = "package_rpm", we can see that libncurses.so
is installed.

This is because:

$ rpm -qpR 
tmp/deploy/rpm/x86_64_nativesdk/gdb-cross-canadian-x86-64-7.7.1-r0.x86_64_nativesdk.rpm 
| grep ncurses
libncurses.so.5()(64bit)
### There is a file depends (libncurses.so.5)

$ dpkg-deb -I 
tmp/deploy/ipk/x86_64-nativesdk/gdb-cross-canadian-x86-64_7.7.1-r0_x86_64-nativesdk.ipk 
| grep ncurses
### No output, ipk knows nothing about the file depends (libncurses.so.5),
### so that it would not be  installed.

I updated the commit message in the repo, please feel free to let me know if
you have any questions.

git://git.openembedded.org/openembedded-core-contrib rbt/python3-gdb

We had nativesdk-ncurses in the DEPENDS, also need add
nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses will
not be installed when PACKAGE_CLASSES = "package_ipk" or deb.

Fixed:
- Set these in local.conf:
   MACHINE = "qemux86-64"
   PACKAGE_CLASSES = "package_ipk"

$ bitbake meta-toolchain
$ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
   ## No output, ncurses isn't installed, but it should.

// Robert

>
> If its a dynamically linked lib, the dependency should be detected
> automatically.
>
> Cheers,
>
> Richard
>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>> index e594bb1..2be427a 100644
>> --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>> @@ -7,7 +7,9 @@ BPN = "gdb"
>>
>>   DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-readline nativesdk-python"
>>   RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
>> -                   nativesdk-python-codecs nativesdk-python-netclient"
>> +                   nativesdk-python-codecs nativesdk-python-netclient \
>> +                   nativesdk-ncurses-libncurses \
>> +                  "
>>
>>   GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
>>
>> --
>> 1.7.9.5
>>
>
>
>
>
Robert Yang - Aug. 15, 2014, 10:56 a.m.
On 08/15/2014 06:47 PM, Robert Yang wrote:
>
>
> On 08/15/2014 04:54 PM, Richard Purdie wrote:
>> On Fri, 2014-08-15 at 01:49 -0700, Robert Yang wrote:
>>> We had nativesdk-ncurses in the DEPENDS, also need add
>>> nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses.so.5
>>> is not in the rdepends chain.
>>
>> This doesn't make sense. Can you please give more information about the
>> problem you're solving here please?
>
> Sorry, I should put more info in the commit message. Yes, it doesn't
> make sense to package_rpm, but makes sense to package_ipk (verified)
> and package_deb (not yet verified).
>
> My host is X86_64 (doesn't matter)

(Sorry, I used a ctrl-X cut these mesasge, here is the set in local.conf
to reproduce the problem):

- Set these in local.conf:
   MACHINE = "qemux86-64"
   PACKAGE_CLASSES = "package_ipk"

// Robert

>
> # Make sure it is a clean build
> $ bitbake meta-toolchain -ccleansstate
>
> $ bitbake meta-toolchain
>
> $ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep
> poky-linux-gdb
> tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/opt/poky/1.6+snapshot/sysroots/x86_64-pokysdk-linux/usr/bin/x86_64-poky-linux/x86_64-poky-linux-gdb
>
> #### Note gdb-cross has been installed
>
> $ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
> ### No output, libncurses.so isn't installed.
>
> And if we use PACKAGE_CLASSES = "package_rpm", we can see that libncurses.so
> is installed.
>
> This is because:
>
> $ rpm -qpR
> tmp/deploy/rpm/x86_64_nativesdk/gdb-cross-canadian-x86-64-7.7.1-r0.x86_64_nativesdk.rpm
> | grep ncurses
> libncurses.so.5()(64bit)
> ### There is a file depends (libncurses.so.5)
>
> $ dpkg-deb -I
> tmp/deploy/ipk/x86_64-nativesdk/gdb-cross-canadian-x86-64_7.7.1-r0_x86_64-nativesdk.ipk
> | grep ncurses
> ### No output, ipk knows nothing about the file depends (libncurses.so.5),
> ### so that it would not be  installed.
>
> I updated the commit message in the repo, please feel free to let me know if
> you have any questions.
>
> git://git.openembedded.org/openembedded-core-contrib rbt/python3-gdb
>
> We had nativesdk-ncurses in the DEPENDS, also need add
> nativesdk-ncurses-libncurses to the RDEPENDS, otherwise libncurses will
> not be installed when PACKAGE_CLASSES = "package_ipk" or deb.
>
> Fixed:
> - Set these in local.conf:
>    MACHINE = "qemux86-64"
>    PACKAGE_CLASSES = "package_ipk"
>
> $ bitbake meta-toolchain
> $ find tmp/work/core2-64-poky-linux/meta-toolchain/1.0-r7/sdk/image/ | grep ncurses
>    ## No output, ncurses isn't installed, but it should.
>
> // Robert
>
>>
>> If its a dynamically linked lib, the dependency should be detected
>> automatically.
>>
>> Cheers,
>>
>> Richard
>>
>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>> ---
>>>   meta/recipes-devtools/gdb/gdb-cross-canadian.inc |    4 +++-
>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>>> b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>>> index e594bb1..2be427a 100644
>>> --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>>> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
>>> @@ -7,7 +7,9 @@ BPN = "gdb"
>>>
>>>   DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext
>>> nativesdk-readline nativesdk-python"
>>>   RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang
>>> nativesdk-python-re \
>>> -                   nativesdk-python-codecs nativesdk-python-netclient"
>>> +                   nativesdk-python-codecs nativesdk-python-netclient \
>>> +                   nativesdk-ncurses-libncurses \
>>> +                  "
>>>
>>>   GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
>>>
>>> --
>>> 1.7.9.5
>>>
>>
>>
>>
>>

Patch

diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
index e594bb1..2be427a 100644
--- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
@@ -7,7 +7,9 @@  BPN = "gdb"
 
 DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-readline nativesdk-python"
 RDEPENDS_${PN} += "nativesdk-python-core nativesdk-python-lang nativesdk-python-re \
-                   nativesdk-python-codecs nativesdk-python-netclient"
+                   nativesdk-python-codecs nativesdk-python-netclient \
+                   nativesdk-ncurses-libncurses \
+                  "
 
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"