Patchwork [meta-oe,2/2] collectd: make pinba support a selectable feature

login
register
mail settings
Submitter Maciej Borzecki
Date Aug. 14, 2014, 3:31 p.m.
Message ID <1408030303-742-3-git-send-email-maciej.borzecki@open-rnd.pl>
Download mbox | patch
Permalink /patch/78243/
State Accepted, archived
Headers show

Comments

Maciej Borzecki - Aug. 14, 2014, 3:31 p.m.
Pinba support requires protobuf-c that is currently only available in
meta-virtualization layer. Make this a selectable feature.

Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
---
 meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 +
 1 file changed, 1 insertion(+)
Martin Jansa - Aug. 14, 2014, 3:42 p.m.
On Thu, Aug 14, 2014 at 05:31:43PM +0200, Maciej Borzecki wrote:
> Pinba support requires protobuf-c that is currently only available in
> meta-virtualization layer. Make this a selectable feature.

There is some protobuf in meta-oe
meta-openembedded/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb

is protobuf-c something else?

> Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> ---
>  meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> index 30279c2..837eae5 100644
> --- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> +++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> @@ -32,6 +32,7 @@ PACKAGECONFIG[sensors] = "--enable-sensors --with-libsensors=yes, \
>          --disable-sensors --with-libsensors=no,lmsensors"
>  PACKAGECONFIG[amqp] = "--enable-amqp --with-librabbitmq=yes, \
>          --disable-amqp --with-librabbitmq=no,rabbitmq-c"
> +PACKAGECONFIG[pinba] = "--enable-pinba,--disable-pinba,protobuf protobuf-native"
>  
>  EXTRA_OECONF = " \
>                  ${FPLAYOUT} \
> -- 
> 1.9.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Maciej Borzecki - Aug. 14, 2014, 3:47 p.m.
On Thursday 14 of August 2014 17:42:20 Martin Jansa wrote:
> On Thu, Aug 14, 2014 at 05:31:43PM +0200, Maciej Borzecki wrote:
> > Pinba support requires protobuf-c that is currently only available in
> > meta-virtualization layer. Make this a selectable feature.
> 
> There is some protobuf in meta-oe
> meta-openembedded/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> 
> is protobuf-c something else?
Yes. protobuf in meta-oe is a tool (protoc) and a C++ library, protobuf-c is a
C implementation of the library.

(sorry if you get multiple copies of this email, kmail got confused with 
multiple email accounts)

> 
> > Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> > Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> > ---
> > 
> >  meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb index
> > 30279c2..837eae5 100644
> > --- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > +++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > @@ -32,6 +32,7 @@ PACKAGECONFIG[sensors] = "--enable-sensors
> > --with-libsensors=yes, \> 
> >          --disable-sensors --with-libsensors=no,lmsensors"
> >  
> >  PACKAGECONFIG[amqp] = "--enable-amqp --with-librabbitmq=yes, \
> >  
> >          --disable-amqp --with-librabbitmq=no,rabbitmq-c"
> > 
> > +PACKAGECONFIG[pinba] = "--enable-pinba,--disable-pinba,protobuf
> > protobuf-native"> 
> >  EXTRA_OECONF = " \
> >  
> >                  ${FPLAYOUT} \
Martin Jansa - Aug. 14, 2014, 3:50 p.m.
On Thu, Aug 14, 2014 at 05:45:12PM +0200, Maciej Borzecki wrote:
> On Thursday 14 of August 2014 17:42:20 Martin Jansa wrote:
> > On Thu, Aug 14, 2014 at 05:31:43PM +0200, Maciej Borzecki wrote:
> > > Pinba support requires protobuf-c that is currently only available in
> > > meta-virtualization layer. Make this a selectable feature.
> > 
> > There is some protobuf in meta-oe
> > meta-openembedded/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> > 
> > is protobuf-c something else?
> Yes. protobuf in meta-oe is a tool (protoc) and a C++ library, protobuf-c is a 
> C implementation of the library.

So shouldn't PACKAGECONFIG contain protobuf-c as well?

If yes, then please add comment above PACKAGECONFIG definition that
protobuf-c is in meta-virtualization (so that people don't need to
search commit messages).

Thanks

> > > Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> > > Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> > > ---
> > > 
> > >  meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > > b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb index
> > > 30279c2..837eae5 100644
> > > --- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > > +++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > > @@ -32,6 +32,7 @@ PACKAGECONFIG[sensors] = "--enable-sensors
> > > --with-libsensors=yes, \> 
> > >          --disable-sensors --with-libsensors=no,lmsensors"
> > >  
> > >  PACKAGECONFIG[amqp] = "--enable-amqp --with-librabbitmq=yes, \
> > >  
> > >          --disable-amqp --with-librabbitmq=no,rabbitmq-c"
> > > 
> > > +PACKAGECONFIG[pinba] = "--enable-pinba,--disable-pinba,protobuf
> > > protobuf-native"> 
> > >  EXTRA_OECONF = " \
> > >  
> > >                  ${FPLAYOUT} \
> 
> -- 
> Maciek Borzecki <maciek.borzecki@gmail.com>
Maciej Borzecki - Aug. 14, 2014, 8:06 p.m.
On Thursday 14 of August 2014 17:50:04 Martin Jansa wrote:
> On Thu, Aug 14, 2014 at 05:45:12PM +0200, Maciej Borzecki wrote:
> > On Thursday 14 of August 2014 17:42:20 Martin Jansa wrote:
> > > On Thu, Aug 14, 2014 at 05:31:43PM +0200, Maciej Borzecki wrote:
> > > > Pinba support requires protobuf-c that is currently only available in
> > > > meta-virtualization layer. Make this a selectable feature.
> > > 
> > > There is some protobuf in meta-oe
> > > meta-openembedded/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> > > 
> > > is protobuf-c something else?
> > 
> > Yes. protobuf in meta-oe is a tool (protoc) and a C++ library, protobuf-c
> > is a C implementation of the library.
> 
> So shouldn't PACKAGECONFIG contain protobuf-c as well?
Indeed, looks like a brain fart on my side :)


> 
> If yes, then please add comment above PACKAGECONFIG definition that
> protobuf-c is in meta-virtualization (so that people don't need to
> search commit messages).
> 
> Thanks
> 
> > > > Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> > > > Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> > > > ---
> > > > 
> > > >  meta-oe/recipes-extended/collectd/collectd_5.2.2.bb | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > > > b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb index
> > > > 30279c2..837eae5 100644
> > > > --- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > > > +++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
> > > > @@ -32,6 +32,7 @@ PACKAGECONFIG[sensors] = "--enable-sensors
> > > > --with-libsensors=yes, \>
> > > > 
> > > >          --disable-sensors --with-libsensors=no,lmsensors"
> > > >  
> > > >  PACKAGECONFIG[amqp] = "--enable-amqp --with-librabbitmq=yes, \
> > > >  
> > > >          --disable-amqp --with-librabbitmq=no,rabbitmq-c"
> > > > 
> > > > +PACKAGECONFIG[pinba] = "--enable-pinba,--disable-pinba,protobuf
> > > > protobuf-native">
> > > > 
> > > >  EXTRA_OECONF = " \
> > > >  
> > > >                  ${FPLAYOUT} \

Patch

diff --git a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
index 30279c2..837eae5 100644
--- a/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
+++ b/meta-oe/recipes-extended/collectd/collectd_5.2.2.bb
@@ -32,6 +32,7 @@  PACKAGECONFIG[sensors] = "--enable-sensors --with-libsensors=yes, \
         --disable-sensors --with-libsensors=no,lmsensors"
 PACKAGECONFIG[amqp] = "--enable-amqp --with-librabbitmq=yes, \
         --disable-amqp --with-librabbitmq=no,rabbitmq-c"
+PACKAGECONFIG[pinba] = "--enable-pinba,--disable-pinba,protobuf protobuf-native"
 
 EXTRA_OECONF = " \
                 ${FPLAYOUT} \