Patchwork site: Add common-darwin

login
register
mail settings
Submitter Richard Purdie
Date Aug. 14, 2014, 1:38 p.m.
Message ID <1408023506.22187.106.camel@ted>
Download mbox | patch
Permalink /patch/78227/
State New
Headers show

Comments

Richard Purdie - Aug. 14, 2014, 1:38 p.m.
We need this to ensure there are some correct values when building with
meta-darwin. This matches the addition of a common-mingw site file in
the core.
Stefan Seefeld - Aug. 14, 2014, 1:42 p.m.
On 08/14/2014 09:38 AM, Richard Purdie wrote:
> We need this to ensure there are some correct values when building with
> meta-darwin. This matches the addition of a common-mingw site file in
> the core.
> 
> diff --git a/meta/site/common-darwin b/meta/site/common-darwin
> new file mode 100644
> index 0000000..604c04b
> --- /dev/null
> +++ b/meta/site/common-darwin
> @@ -0,0 +1,2 @@
> +ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getpwuid_r=yes}
> +ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getgrgid_r=yes}

This looks like a typo. Shouldn't the second line start with
"ac_cv_func_posix_getgrgid_r=..." ?

	Stefan
Richard Purdie - Aug. 14, 2014, 3:57 p.m.
On Thu, 2014-08-14 at 09:42 -0400, Stefan Seefeld wrote:
> On 08/14/2014 09:38 AM, Richard Purdie wrote:
> > We need this to ensure there are some correct values when building with
> > meta-darwin. This matches the addition of a common-mingw site file in
> > the core.
> > 
> > diff --git a/meta/site/common-darwin b/meta/site/common-darwin
> > new file mode 100644
> > index 0000000..604c04b
> > --- /dev/null
> > +++ b/meta/site/common-darwin
> > @@ -0,0 +1,2 @@
> > +ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getpwuid_r=yes}
> > +ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getgrgid_r=yes}
> 
> This looks like a typo. Shouldn't the second line start with
> "ac_cv_func_posix_getgrgid_r=..." ?

That is a typo, thanks. Fixed in the version queued in master-next.

Cheers,

Richard

Patch

diff --git a/meta/site/common-darwin b/meta/site/common-darwin
new file mode 100644
index 0000000..604c04b
--- /dev/null
+++ b/meta/site/common-darwin
@@ -0,0 +1,2 @@ 
+ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getpwuid_r=yes}
+ac_cv_func_posix_getpwuid_r=${ac_cv_func_posix_getgrgid_r=yes}