Patchwork [2/2] gstreamer1.0-plugins-good: Add a PACKAGECONFIG for udev

login
register
mail settings
Submitter Peter Kjellerstedt
Date Aug. 13, 2014, 5:46 p.m.
Message ID <452f76082d13b3d1c7f9930c8754553c336bd176.1407951966.git.pkj@axis.com>
Download mbox | patch
Permalink /patch/78085/
State Accepted
Commit 9c1ea582496a6c6597bc7a5301101e11d9b91c3d
Headers show

Comments

Peter Kjellerstedt - Aug. 13, 2014, 5:46 p.m.
This solves these floating dependencies:

WARNING: QA Issue: gstreamer1.0-plugins-good-video4linux2 rdepends on
libudev, but it isn't a build dependency? [build-deps]
WARNING: QA Issue: gstreamer1.0-plugins-good-video4linux2 rdepends on
libgudev-1.0, but it isn't a build dependency? [build-deps]

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Ross Burton - Aug. 14, 2014, 11:21 a.m.
On 13 August 2014 18:46, Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
> +PACKAGECONFIG[gudev]      = "--with-gudev,--without-gudev,udev"

Don't you need to depend on gudev here aswell?

Ross
Koen Kooi - Aug. 14, 2014, 11:27 a.m.
Op 14 aug. 2014, om 13:21 heeft Burton, Ross <ross.burton@intel.com> het volgende geschreven:

> On 13 August 2014 18:46, Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
>> +PACKAGECONFIG[gudev]      = "--with-gudev,--without-gudev,udev"
> 
> Don't you need to depend on gudev here aswell?

gudev is part of udev, right? And as a shlib it will get picked up as RDEPEND automatically[1].

regards,

Koen

[1] Unless gst is stupid and dlopen()s it.
Ross Burton - Aug. 14, 2014, 11:44 a.m.
On 14 August 2014 12:27, Koen Kooi <koen@dominion.thruhere.net> wrote:
> gudev is part of udev, right? And as a shlib it will get picked up as RDEPEND automatically[1].

Yep, brainfart my end - confused it with another library.

Ross

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
index 223e790..b33ab2b 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc
@@ -11,7 +11,7 @@  inherit gettext
 PACKAGECONFIG ??= " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
-    orc cairo flac gdk-pixbuf jpeg libpng soup speex taglib \
+    orc cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib \
     "
 
 X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
@@ -22,6 +22,7 @@  PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
 PACKAGECONFIG[cairo]      = "--enable-cairo,--disable-cairo,cairo"
 PACKAGECONFIG[flac]       = "--enable-flac,--disable-flac,flac"
 PACKAGECONFIG[gdk-pixbuf] = "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
+PACKAGECONFIG[gudev]      = "--with-gudev,--without-gudev,udev"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[jpeg]       = "--enable-jpeg,--disable-jpeg,jpeg"
 PACKAGECONFIG[libpng]     = "--enable-libpng,--disable-libpng,libpng"