Patchwork [meta-oe] rabbitmq-c: add recipe

login
register
mail settings
Submitter Maciej Borzecki
Date Aug. 11, 2014, 2:33 p.m.
Message ID <1407767636-32624-1-git-send-email-maciej.borzecki@open-rnd.pl>
Download mbox | patch
Permalink /patch/77881/
State Accepted, archived
Headers show

Comments

Maciej Borzecki - Aug. 11, 2014, 2:33 p.m.
rabbitmq-c is a C library providing an implementation of AMQP client for
use with v2.0+ of the RabbitMQ broker

Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
---
 .../rabbitmq-c/rabbitmq-c_0.5.0.bb                 | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb

\ No newline at end of file
Martin Jansa - Aug. 12, 2014, 11:45 a.m.
On Mon, Aug 11, 2014 at 04:33:56PM +0200, Maciej Borzecki wrote:
> rabbitmq-c is a C library providing an implementation of AMQP client for
> use with v2.0+ of the RabbitMQ broker
> 
> Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> ---
>  .../rabbitmq-c/rabbitmq-c_0.5.0.bb                 | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
> 
> diff --git a/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
> new file mode 100644
> index 0000000..d8e3189
> --- /dev/null
> +++ b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "A C-language AMQP client library for use with v2.0+ of the RabbitMQ broker"
> +HOMEPAGE = "https://github.com/alanxz/rabbitmq-c"
> +LIC_FILES_CHKSUM = "file://${S}/LICENSE-MIT;md5=6b7424f9db80cfb11fdd5c980b583f53"
> +LICENSE = "MIT"
> +
> +SRC_URI = "https://github.com/alanxz/rabbitmq-c/releases/download/v${PV}/rabbitmq-c-${PV}.tar.gz"
> +SRC_URI[md5sum] = "b1f902c658c772cda464754678d8deb6"
> +SRC_URI[sha256sum] = "53702ea2ab809af0f923e387458e2cad191d9549f50410035fe82ce5e6ccc4fa"
> +
> +PR = "r0"

^ dropped when cherry-picking to master-next

> +
> +S = "${WORKDIR}/rabbitmq-c-${PV}"

^ dropped when cherry-picking to master-next

> +
> +EXTRA_OECONF = "--disable-examples --enable-tools"
> +
> +inherit autotools pkgconfig
> +
> +PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-tools ${PN}"

Why are you dropping -doc, -staticdev, -locale and other default
packages?

PACKAGE_BEFORE_PN += "${PN}-tools"

should be enough, will do in master-next, but please ack

> +
> +DEPENDS = "popt openssl"
> +
> +FILES_${PN}-tools = "${bindir}"
> \ No newline at end of file
> -- 
> 1.9.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Maciej Borzecki - Aug. 12, 2014, 12:05 p.m.
On Tuesday 12 of August 2014 13:45:38 Martin Jansa wrote:
> On Mon, Aug 11, 2014 at 04:33:56PM +0200, Maciej Borzecki wrote:
> > rabbitmq-c is a C library providing an implementation of AMQP client for
> > use with v2.0+ of the RabbitMQ broker
> > 
> > Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> > Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> > ---
> > 
> >  .../rabbitmq-c/rabbitmq-c_0.5.0.bb                 | 22
> >  ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
> >  create mode 100644
> >  meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb> 
> > diff --git a/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
> > b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb new file
> > mode 100644
> > index 0000000..d8e3189
> > --- /dev/null
> > +++ b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
> > @@ -0,0 +1,22 @@
> > +DESCRIPTION = "A C-language AMQP client library for use with v2.0+ of the
> > RabbitMQ broker" +HOMEPAGE = "https://github.com/alanxz/rabbitmq-c"
> > +LIC_FILES_CHKSUM =
> > "file://${S}/LICENSE-MIT;md5=6b7424f9db80cfb11fdd5c980b583f53" +LICENSE =
> > "MIT"
> > +
> > +SRC_URI =
> > "https://github.com/alanxz/rabbitmq-c/releases/download/v${PV}/rabbitmq-c
> > -${PV}.tar.gz" +SRC_URI[md5sum] = "b1f902c658c772cda464754678d8deb6"
> > +SRC_URI[sha256sum] =
> > "53702ea2ab809af0f923e387458e2cad191d9549f50410035fe82ce5e6ccc4fa" +
> > +PR = "r0"
> 
> ^ dropped when cherry-picking to master-next
> 
> > +
> > +S = "${WORKDIR}/rabbitmq-c-${PV}"
> 
> ^ dropped when cherry-picking to master-next
> 
> > +
> > +EXTRA_OECONF = "--disable-examples --enable-tools"
> > +
> > +inherit autotools pkgconfig
> > +
> > +PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-tools ${PN}"
> 
> Why are you dropping -doc, -staticdev, -locale and other default
> packages?
> 
> PACKAGE_BEFORE_PN += "${PN}-tools"
Right, this should do the trick. The -doc, -staticdev, -locale are empty 
anyway, but it does make more sense not to remove them from PACKAGES.

I can post an updated patch if that's needed.

> 
> should be enough, will do in master-next, but please ack
> 
> > +
> > +DEPENDS = "popt openssl"
> > +
> > +FILES_${PN}-tools = "${bindir}"
> > \ No newline at end of file
Martin Jansa - Aug. 13, 2014, 8:34 p.m.
On Tue, Aug 12, 2014 at 02:05:05PM +0200, Maciej Borzecki wrote:
> On Tuesday 12 of August 2014 13:45:38 Martin Jansa wrote:
> > On Mon, Aug 11, 2014 at 04:33:56PM +0200, Maciej Borzecki wrote:
> > > rabbitmq-c is a C library providing an implementation of AMQP client for
> > > use with v2.0+ of the RabbitMQ broker
> > > 
> > > Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> > > Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> > > ---
> > > 
> > >  .../rabbitmq-c/rabbitmq-c_0.5.0.bb                 | 22
> > >  ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
> > >  create mode 100644
> > >  meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb> 
> > > diff --git a/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
> > > b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb new file
> > > mode 100644
> > > index 0000000..d8e3189
> > > --- /dev/null
> > > +++ b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
> > > @@ -0,0 +1,22 @@
> > > +DESCRIPTION = "A C-language AMQP client library for use with v2.0+ of the
> > > RabbitMQ broker" +HOMEPAGE = "https://github.com/alanxz/rabbitmq-c"
> > > +LIC_FILES_CHKSUM =
> > > "file://${S}/LICENSE-MIT;md5=6b7424f9db80cfb11fdd5c980b583f53" +LICENSE =
> > > "MIT"
> > > +
> > > +SRC_URI =
> > > "https://github.com/alanxz/rabbitmq-c/releases/download/v${PV}/rabbitmq-c
> > > -${PV}.tar.gz" +SRC_URI[md5sum] = "b1f902c658c772cda464754678d8deb6"
> > > +SRC_URI[sha256sum] =
> > > "53702ea2ab809af0f923e387458e2cad191d9549f50410035fe82ce5e6ccc4fa" +
> > > +PR = "r0"
> > 
> > ^ dropped when cherry-picking to master-next
> > 
> > > +
> > > +S = "${WORKDIR}/rabbitmq-c-${PV}"
> > 
> > ^ dropped when cherry-picking to master-next
> > 
> > > +
> > > +EXTRA_OECONF = "--disable-examples --enable-tools"
> > > +
> > > +inherit autotools pkgconfig
> > > +
> > > +PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-tools ${PN}"
> > 
> > Why are you dropping -doc, -staticdev, -locale and other default
> > packages?
> > 
> > PACKAGE_BEFORE_PN += "${PN}-tools"
> Right, this should do the trick. The -doc, -staticdev, -locale are empty 
> anyway, but it does make more sense not to remove them from PACKAGES.
> 
> I can post an updated patch if that's needed.

There is another issue found in world builds:

| /home/jenkins/oe/world/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/bin/xmlto: line 325: local: can only be used in a function
| /home/jenkins/oe/world/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/bin/xmlto: line 325: local: can only be used in a function
| I/O xmlto --skip-validation --searchpath /home/jenkins/oe/world/shr-core/tmp-eglibc/work/core2-64-oe-linux/rabbitmq-c/0.5.0-r0/build/tools/doc -o ./tools/doc man /home/jenkins/oe/world/shr-core/tmp-eglibc/work/core2-64-oe-linux/rabbitmq-c/0.5.0-r0/rabbitmq-c-0.5.0/tools/doc/amqp-delete-queue.xml
| error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
| compilation error: file /tmp/xmlto-xsl.dUNOhT line 4 element import
| xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| make[1]: *** [tools/doc/amqp-publish.1] Error 1
| make[1]: *** Waiting for unfinished jobs....
| I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
| compilation error: file /tmp/xmlto-xsl.9922tE line 4 element import
| xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
| compilation error: file /tmp/xmlto-xsl.EhgGFW line 4 element import
| xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| /home/jenkins/oe/world/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/bin/xmlto: line 325: local: can only be used in a function
| make[1]: *** [tools/doc/amqp-consume.1] Error 1
| make[1]: *** [tools/doc/amqp-get.1] Error 1
| /home/jenkins/oe/world/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/bin/xmlto: line 325: local: can only be used in a function
| I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
| compilation error: file /tmp/xmlto-xsl.31x9dG line 4 element import
| xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| make[1]: *** [tools/doc/amqp-declare-queue.1] Error 1
| I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl"
| compilation error: file /tmp/xmlto-xsl.z0t8kl line 4 element import
| xsl:import : unable to load http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
| make[1]: *** [tools/doc/amqp-delete-queue.1] Error 1
| make[1]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-eglibc/work/core2-64-oe-linux/rabbitmq-c/0.5.0-r0/build'
| make: *** [all] Error 2
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_compile (log file is located at /home/jenkins/oe/world/shr-core/tmp-eglibc/work/core2-64-oe-linux/rabbitmq-c/0.5.0-r0/temp/log.do_compile.28061)

so please send updated version with disabled or fixed doc generation

> > should be enough, will do in master-next, but please ack
> > 
> > > +
> > > +DEPENDS = "popt openssl"
> > > +
> > > +FILES_${PN}-tools = "${bindir}"
> > > \ No newline at end of file
> 
> -- 
>  
> Maciej Borz?cki 
> Senior Software Engineer Open-RnD Sp. z o.o. 
> www.open-rnd.pl, Facebook, Twitter 
> mobile: +48 telefon, fax: +48 42 657 9079 
> 
> 
> Niniejsza wiadomo?? wraz z za??cznikami mo?e zawiera? chronione prawem lub 
> poufne informacje i zosta?a wys?ana wy??cznie do wiadomo?ci i u?ytku osób, do 
> których zosta?a zaadresowana. Je?li wiadomo?? zosta?a otrzymana przypadkowo 
> zabrania si? jej kopiowania lub rozsy?ania do osób trzecich. W takim przypadku 
> uprasza si? o natychmiastowe zniszczenie wiadomo?ci oraz poinformowanie 
> nadawcy o zaistnia?ej sytuacji za pomoc? wiadomo?ci zwrotnej. Dzi?kujemy. 
> 
> This message, including any attachments hereto, may contain privileged or 
> confidential information and is sent solely for the attention and use of the 
> intended addressee(s). If you are not an intended addressee, you may neither 
> use this message nor copy or deliver it to anyone. In such case, you should 
> immediately destroy this message and kindly notify the sender by reply email. 
> Thank you.

Patch

diff --git a/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
new file mode 100644
index 0000000..d8e3189
--- /dev/null
+++ b/meta-oe/recipes-connectivity/rabbitmq-c/rabbitmq-c_0.5.0.bb
@@ -0,0 +1,22 @@ 
+DESCRIPTION = "A C-language AMQP client library for use with v2.0+ of the RabbitMQ broker"
+HOMEPAGE = "https://github.com/alanxz/rabbitmq-c"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE-MIT;md5=6b7424f9db80cfb11fdd5c980b583f53"
+LICENSE = "MIT"
+
+SRC_URI = "https://github.com/alanxz/rabbitmq-c/releases/download/v${PV}/rabbitmq-c-${PV}.tar.gz"
+SRC_URI[md5sum] = "b1f902c658c772cda464754678d8deb6"
+SRC_URI[sha256sum] = "53702ea2ab809af0f923e387458e2cad191d9549f50410035fe82ce5e6ccc4fa"
+
+PR = "r0"
+
+S = "${WORKDIR}/rabbitmq-c-${PV}"
+
+EXTRA_OECONF = "--disable-examples --enable-tools"
+
+inherit autotools pkgconfig
+
+PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-tools ${PN}"
+
+DEPENDS = "popt openssl"
+
+FILES_${PN}-tools = "${bindir}"