Patchwork [2/3] rt-tests: Upgrade to latest version 0.73.

login
register
mail settings
Submitter Raymond Danks
Date July 18, 2011, 7:25 p.m.
Message ID <1311017115-28352-2-git-send-email-ray.danks@se-eng.com>
Download mbox | patch
Permalink /patch/7771/
State New, archived
Headers show

Comments

Raymond Danks - July 18, 2011, 7:25 p.m.
Signed-off-by: Raymond Danks <ray.danks@se-eng.com>
---
 recipes/rt-tests/rt-tests_0.73.bb |   27 +++++++++++++++++++++++++++
 1 files changed, 27 insertions(+), 0 deletions(-)
 create mode 100644 recipes/rt-tests/rt-tests_0.73.bb
Paul Menzel - July 18, 2011, 8:16 p.m.
Am Montag, den 18.07.2011, 13:25 -0600 schrieb Raymond Danks:

No full stop at the end of commit summaries, please.

> Signed-off-by: Raymond Danks <ray.danks@se-eng.com>
> ---
>  recipes/rt-tests/rt-tests_0.73.bb |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/rt-tests/rt-tests_0.73.bb
> 
> diff --git a/recipes/rt-tests/rt-tests_0.73.bb b/recipes/rt-tests/rt-tests_0.73.bb
> new file mode 100644
> index 0000000..bebf89e
> --- /dev/null
> +++ b/recipes/rt-tests/rt-tests_0.73.bb
> @@ -0,0 +1,27 @@
> +DESCRIPTION = "Real-time tests, such as cyclictest, for real-time linux PREEMPT RT kernels"
> +HOMEPAGE = "http://rt.wiki.kernel.org/index.php/Cyclictest"
> +LICENSE = "GPL"
> +PR = "r1"

Please start at `r0`.

> +
> +SRC_URI = "http://www.kernel.org/pub/linux/kernel/people/tglx/rt-tests/rt-tests-${PV}.tar.bz2"
> +
> +S = "${WORKDIR}/rt-tests"
> +
> +CFLAGS += "-D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include"
> +TARGET_CC_ARCH += "${LDFLAGS}"
> +
> +# Limit to cyclictest only for non-real-time kernels.
> +# EXTRA_OEMAKE = "cyclictest"
> +
> +do_install() {
> +  install -d ${D}${bindir}
> +  # any file that is executable by user and/or group
> +  for binary in `find . -perm /u+x,g+x -type f`
> +  do
> +    install -m 0755 $binary ${D}${bindir}
> +  done
> +}

Hmm, I am wondering how does this recipe work anyway. `inherit
autotools` is missing, so how are the tasks configure and compile
executed?

> +
> +SRC_URI[md5sum] = "98da46135f0a91c96cb7e5b27c7e3bb6"
> +SRC_URI[sha256sum] = "f8d396ecd6aa5526c49919acbac0ea4936f27f2410ca806570d8c92c1067c29d"

Ok, it looks like you just adapted the recipe of the old version already
in included in OE.

1. Please use `git format-patch -M -M -C -C -C` – I do not know how
often those arguments have to be passed – so that Git detects renames
and makes the diff smaller and easier to review.
2. Could you please send a follow up patch removing the old version?
3. If there are any errors with the old version which you experienced
and have been fixed, please mention those in the commit message.


Thanks,

Paul

Patch

diff --git a/recipes/rt-tests/rt-tests_0.73.bb b/recipes/rt-tests/rt-tests_0.73.bb
new file mode 100644
index 0000000..bebf89e
--- /dev/null
+++ b/recipes/rt-tests/rt-tests_0.73.bb
@@ -0,0 +1,27 @@ 
+DESCRIPTION = "Real-time tests, such as cyclictest, for real-time linux PREEMPT RT kernels"
+HOMEPAGE = "http://rt.wiki.kernel.org/index.php/Cyclictest"
+LICENSE = "GPL"
+PR = "r1"
+
+SRC_URI = "http://www.kernel.org/pub/linux/kernel/people/tglx/rt-tests/rt-tests-${PV}.tar.bz2"
+
+S = "${WORKDIR}/rt-tests"
+
+CFLAGS += "-D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include"
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+# Limit to cyclictest only for non-real-time kernels.
+# EXTRA_OEMAKE = "cyclictest"
+
+do_install() {
+  install -d ${D}${bindir}
+  # any file that is executable by user and/or group
+  for binary in `find . -perm /u+x,g+x -type f`
+  do
+    install -m 0755 $binary ${D}${bindir}
+  done
+}
+
+SRC_URI[md5sum] = "98da46135f0a91c96cb7e5b27c7e3bb6"
+SRC_URI[sha256sum] = "f8d396ecd6aa5526c49919acbac0ea4936f27f2410ca806570d8c92c1067c29d"
+