Patchwork [dora,backport] kernel: don't copy .so.dbg files into kernel source install

login
register
mail settings
Submitter Koen Kooi
Date Aug. 9, 2014, 9:11 a.m.
Message ID <1407575476-15945-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/77655/
State Accepted
Commit 4033ca87f5e270b766ecb146c36815d28ece2b4a
Headers show

Comments

Koen Kooi - Aug. 9, 2014, 9:11 a.m.
From: Bruce Ashfield <bruce.ashfield@windriver.com>

In 3.16+ x86-64 kernel builds produce a vdso64.so.dbg file. If this file is
copied into the kernel source install multiple QA failures are triggered.
Specifically, this file triggers a debug package split that results in
files installed but not shipped, and invalid .debug file errors.

By ensuring that .so files are not copied, we avoid this incorrect split
with no impact on future build phases.

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - Aug. 11, 2014, 10:04 a.m.
On Sat, 2014-08-09 at 11:11 +0200, Koen Kooi wrote:
> From: Bruce Ashfield <bruce.ashfield@windriver.com>
> 
> In 3.16+ x86-64 kernel builds produce a vdso64.so.dbg file. If this file is
> copied into the kernel source install multiple QA failures are triggered.
> Specifically, this file triggers a debug package split that results in
> files installed but not shipped, and invalid .debug file errors.
> 
> By ensuring that .so files are not copied, we avoid this incorrect split
> with no impact on future build phases.
> 
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
>  meta/classes/kernel.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Was this mean for daisy, not dora? It doesn't apply to dora but did for
daisy...

Cheers,

Richard
Koen Kooi - Aug. 11, 2014, 11:24 a.m.
Op 11 aug. 2014, om 12:04 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:

> On Sat, 2014-08-09 at 11:11 +0200, Koen Kooi wrote:
>> From: Bruce Ashfield <bruce.ashfield@windriver.com>
>> 
>> In 3.16+ x86-64 kernel builds produce a vdso64.so.dbg file. If this file is
>> copied into the kernel source install multiple QA failures are triggered.
>> Specifically, this file triggers a debug package split that results in
>> files installed but not shipped, and invalid .debug file errors.
>> 
>> By ensuring that .so files are not copied, we avoid this incorrect split
>> with no impact on future build phases.
>> 
>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>> ---
>> meta/classes/kernel.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Was this mean for daisy, not dora? It doesn't apply to dora but did for
> daisy...

Err, right 'daisy', not 'dora'. Sorry for the confusion.

regards,

Koen

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index b2e9d4c..1289873 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -232,7 +232,7 @@  kernel_do_install() {
 	# dir. This ensures the original Makefiles are used and not the
 	# redirecting Makefiles in the build directory.
 	#
-	find . -depth -not -name "*.cmd" -not -name "*.o" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
+	find . -depth -not -name "*.cmd" -not -name "*.o" -not -name "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
 	cp .config $kerneldir
 	if [ "${S}" != "${B}" ]; then
 		pwd="$PWD"