Patchwork [2/2] opkg: Add runtime dep on gnupg if 'gpg' is in PACAKGECONFIG

login
register
mail settings
Submitter Paul Barker
Date Aug. 8, 2014, 11:37 a.m.
Message ID <1407497829-9330-3-git-send-email-paul@paulbarker.me.uk>
Download mbox | patch
Permalink /patch/77535/
State Accepted
Commit de963051ee369fb8c56c93550fcb62b11055139b
Headers show

Comments

Paul Barker - Aug. 8, 2014, 11:37 a.m.
The 'opkg-key' utility requires gpg to manage the list of trusted keys. The
ability to verify package signatures is not much use without the ability to add
keys to the trusted list...

Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
---
 meta/recipes-devtools/opkg/opkg.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - Aug. 8, 2014, 12:13 p.m.
On Fri, Aug 08, 2014 at 11:37:09AM +0000, Paul Barker wrote:
> The 'opkg-key' utility requires gpg to manage the list of trusted keys. The
> ability to verify package signatures is not much use without the ability to add
> keys to the trusted list...
> 
> Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> ---
>  meta/recipes-devtools/opkg/opkg.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/opkg/opkg.inc b/meta/recipes-devtools/opkg/opkg.inc
> index ba21d84..56c54b6 100644
> --- a/meta/recipes-devtools/opkg/opkg.inc
> +++ b/meta/recipes-devtools/opkg/opkg.inc
> @@ -27,7 +27,7 @@ OPKGLIBDIR = "${target_localstatedir}/lib"
>  
>  PACKAGECONFIG ??= ""
>  
> -PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error"
> +PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error,gnupg"

Shouldn't this be gpgme?

>  PACKAGECONFIG[curl] = "--enable-curl,--disable-curl,curl"
>  PACKAGECONFIG[ssl-curl] = "--enable-ssl-curl,--disable-ssl-curl,curl openssl"
>  PACKAGECONFIG[openssl] = "--enable-openssl,--disable-openssl,openssl"
> -- 
> 2.0.3
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Paul Barker - Aug. 8, 2014, 12:16 p.m.
On Fri, Aug 08, 2014 at 02:13:46PM +0200, Martin Jansa wrote:
> On Fri, Aug 08, 2014 at 11:37:09AM +0000, Paul Barker wrote:
> > The 'opkg-key' utility requires gpg to manage the list of trusted keys. The
> > ability to verify package signatures is not much use without the ability to add
> > keys to the trusted list...
> > 
> > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > ---
> >  meta/recipes-devtools/opkg/opkg.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-devtools/opkg/opkg.inc b/meta/recipes-devtools/opkg/opkg.inc
> > index ba21d84..56c54b6 100644
> > --- a/meta/recipes-devtools/opkg/opkg.inc
> > +++ b/meta/recipes-devtools/opkg/opkg.inc
> > @@ -27,7 +27,7 @@ OPKGLIBDIR = "${target_localstatedir}/lib"
> >  
> >  PACKAGECONFIG ??= ""
> >  
> > -PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error"
> > +PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error,gnupg"
> 
> Shouldn't this be gpgme?
> 

Which bit? The PACKAGECONFIG name or one of the comma separated fields?

Thanks,
Paul Barker - Aug. 14, 2014, 4:50 p.m.
On Fri, Aug 08, 2014 at 12:16:28PM +0000, Paul Barker wrote:
> On Fri, Aug 08, 2014 at 02:13:46PM +0200, Martin Jansa wrote:
> > On Fri, Aug 08, 2014 at 11:37:09AM +0000, Paul Barker wrote:
> > > The 'opkg-key' utility requires gpg to manage the list of trusted keys. The
> > > ability to verify package signatures is not much use without the ability to add
> > > keys to the trusted list...
> > > 
> > > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > > ---
> > >  meta/recipes-devtools/opkg/opkg.inc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-devtools/opkg/opkg.inc b/meta/recipes-devtools/opkg/opkg.inc
> > > index ba21d84..56c54b6 100644
> > > --- a/meta/recipes-devtools/opkg/opkg.inc
> > > +++ b/meta/recipes-devtools/opkg/opkg.inc
> > > @@ -27,7 +27,7 @@ OPKGLIBDIR = "${target_localstatedir}/lib"
> > >  
> > >  PACKAGECONFIG ??= ""
> > >  
> > > -PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error"
> > > +PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error,gnupg"
> > 
> > Shouldn't this be gpgme?
> > 
> 
> Which bit? The PACKAGECONFIG name or one of the comma separated fields?
> 

Sorry Martin, I didn't understand your comment. Could you clarify for me?

Thanks,
Martin Jansa - Aug. 14, 2014, 5:16 p.m.
On Thu, Aug 14, 2014 at 04:50:33PM +0000, Paul Barker wrote:
> On Fri, Aug 08, 2014 at 12:16:28PM +0000, Paul Barker wrote:
> > On Fri, Aug 08, 2014 at 02:13:46PM +0200, Martin Jansa wrote:
> > > On Fri, Aug 08, 2014 at 11:37:09AM +0000, Paul Barker wrote:
> > > > The 'opkg-key' utility requires gpg to manage the list of trusted keys. The
> > > > ability to verify package signatures is not much use without the ability to add
> > > > keys to the trusted list...
> > > > 
> > > > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > > > ---
> > > >  meta/recipes-devtools/opkg/opkg.inc | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/meta/recipes-devtools/opkg/opkg.inc b/meta/recipes-devtools/opkg/opkg.inc
> > > > index ba21d84..56c54b6 100644
> > > > --- a/meta/recipes-devtools/opkg/opkg.inc
> > > > +++ b/meta/recipes-devtools/opkg/opkg.inc
> > > > @@ -27,7 +27,7 @@ OPKGLIBDIR = "${target_localstatedir}/lib"
> > > >  
> > > >  PACKAGECONFIG ??= ""
> > > >  
> > > > -PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error"
> > > > +PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error,gnupg"
> > > 
> > > Shouldn't this be gpgme?
> > > 
> > 
> > Which bit? The PACKAGECONFIG name or one of the comma separated fields?
> > 
> 
> Sorry Martin, I didn't understand your comment. Could you clarify for me?

Sorry for late reply, I haven't noticed your earlier e-mail.

It has build-time dependency on gpgme and runtime dependency on gnupg
(in comma separated fields) - it could be OK, I just wasn't sure.

Is opkg-key calling gnupg tools?

> Thanks,
> 
> -- 
> Paul Barker
> 
> Email: paul@paulbarker.me.uk
> http://www.paulbarker.me.uk
Paul Barker - Aug. 14, 2014, 5:19 p.m.
On Thu, Aug 14, 2014 at 07:16:53PM +0200, Martin Jansa wrote:
> On Thu, Aug 14, 2014 at 04:50:33PM +0000, Paul Barker wrote:
> > On Fri, Aug 08, 2014 at 12:16:28PM +0000, Paul Barker wrote:
> > > On Fri, Aug 08, 2014 at 02:13:46PM +0200, Martin Jansa wrote:
> > > > On Fri, Aug 08, 2014 at 11:37:09AM +0000, Paul Barker wrote:
> > > > > The 'opkg-key' utility requires gpg to manage the list of trusted keys. The
> > > > > ability to verify package signatures is not much use without the ability to add
> > > > > keys to the trusted list...
> > > > > 
> > > > > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > > > > ---
> > > > >  meta/recipes-devtools/opkg/opkg.inc | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/meta/recipes-devtools/opkg/opkg.inc b/meta/recipes-devtools/opkg/opkg.inc
> > > > > index ba21d84..56c54b6 100644
> > > > > --- a/meta/recipes-devtools/opkg/opkg.inc
> > > > > +++ b/meta/recipes-devtools/opkg/opkg.inc
> > > > > @@ -27,7 +27,7 @@ OPKGLIBDIR = "${target_localstatedir}/lib"
> > > > >  
> > > > >  PACKAGECONFIG ??= ""
> > > > >  
> > > > > -PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error"
> > > > > +PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error,gnupg"
> > > > 
> > > > Shouldn't this be gpgme?
> > > > 
> > > 
> > > Which bit? The PACKAGECONFIG name or one of the comma separated fields?
> > > 
> > 
> > Sorry Martin, I didn't understand your comment. Could you clarify for me?
> 
> Sorry for late reply, I haven't noticed your earlier e-mail.
> 
> It has build-time dependency on gpgme and runtime dependency on gnupg
> (in comma separated fields) - it could be OK, I just wasn't sure.
> 
> Is opkg-key calling gnupg tools?
> 

Yes, opkg-key is just a shell script which runs 'gpg' with appropriate command
line options. The main opkg program uses the gpgme library instead.

Thanks,

Patch

diff --git a/meta/recipes-devtools/opkg/opkg.inc b/meta/recipes-devtools/opkg/opkg.inc
index ba21d84..56c54b6 100644
--- a/meta/recipes-devtools/opkg/opkg.inc
+++ b/meta/recipes-devtools/opkg/opkg.inc
@@ -27,7 +27,7 @@  OPKGLIBDIR = "${target_localstatedir}/lib"
 
 PACKAGECONFIG ??= ""
 
-PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error"
+PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,gpgme libgpg-error,gnupg"
 PACKAGECONFIG[curl] = "--enable-curl,--disable-curl,curl"
 PACKAGECONFIG[ssl-curl] = "--enable-ssl-curl,--disable-ssl-curl,curl openssl"
 PACKAGECONFIG[openssl] = "--enable-openssl,--disable-openssl,openssl"