Patchwork [meta-networking] wireshark: update README instructions

login
register
mail settings
Submitter Joe MacDonald
Date Aug. 6, 2014, 2:42 p.m.
Message ID <1407336153-2226-1-git-send-email-joe_macdonald@mentor.com>
Download mbox | patch
Permalink /patch/77389/
State Accepted, archived
Headers show

Comments

Joe MacDonald - Aug. 6, 2014, 2:42 p.m.
Minor tweaks to the README to make the email suggestion follow the format
used in other meta-openembedded README files and adding clarification on
building wireshark in a GUI environment.

Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
---
 meta-networking/recipes-support/wireshark/README | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Armin Kuster - Aug. 6, 2014, 2:45 p.m.
Acked-by: Armin Kuster <akuster@mvista.com>

thanks Joe.


On 08/06/2014 07:42 AM, Joe MacDonald wrote:
> Minor tweaks to the README to make the email suggestion follow the format
> used in other meta-openembedded README files and adding clarification on
> building wireshark in a GUI environment.
>
> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
> ---
>   meta-networking/recipes-support/wireshark/README | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-support/wireshark/README b/meta-networking/recipes-support/wireshark/README
> index 0e0c526..63b5b72 100644
> --- a/meta-networking/recipes-support/wireshark/README
> +++ b/meta-networking/recipes-support/wireshark/README
> @@ -19,6 +19,10 @@ IMAGE_INSTALL_append = " wireshark"
>   Adding the wireshark to your graphical build
>   ========================================
>   via local.conf
> +IMAGE_INSTALL_append = " wireshark"
> +
> +and one of:
> +
>   EXTRA_IMAGE_FEATURES += "x11-base"
>
>   or use the "core-image-x11"
> @@ -29,8 +33,12 @@ Maintenance
>
>   Send patches, comments or questions to openembedded-devel@lists.openembedded.org
>
> -When sending single patches, please using something like:
> -'git send-email -1 --to  openembedded-devel@lists.openembedded.org --cc akuster@mvista.com --subject-prefix=meta-security][PATCH'
> +When sending single patches, please use something like:
> +
> +   git send-email -1 -M \
> +       --to openembedded-devel@lists.openembedded.org \
> +       --cc akuster@mvista.com \
> +       --subject-prefix=meta-networking][PATCH
>
>   Maintainer:    Armin Kuster <akuster@mvista.com>
>
>

Patch

diff --git a/meta-networking/recipes-support/wireshark/README b/meta-networking/recipes-support/wireshark/README
index 0e0c526..63b5b72 100644
--- a/meta-networking/recipes-support/wireshark/README
+++ b/meta-networking/recipes-support/wireshark/README
@@ -19,6 +19,10 @@  IMAGE_INSTALL_append = " wireshark"
 Adding the wireshark to your graphical build
 ========================================
 via local.conf
+IMAGE_INSTALL_append = " wireshark"
+
+and one of:
+
 EXTRA_IMAGE_FEATURES += "x11-base"
 
 or use the "core-image-x11"
@@ -29,8 +33,12 @@  Maintenance
 
 Send patches, comments or questions to openembedded-devel@lists.openembedded.org
 
-When sending single patches, please using something like:
-'git send-email -1 --to  openembedded-devel@lists.openembedded.org --cc akuster@mvista.com --subject-prefix=meta-security][PATCH'
+When sending single patches, please use something like:
+
+   git send-email -1 -M \
+       --to openembedded-devel@lists.openembedded.org \
+       --cc akuster@mvista.com \
+       --subject-prefix=meta-networking][PATCH
 
 Maintainer:    Armin Kuster <akuster@mvista.com>