Patchwork [meta-fsl-arm] gstreamer1.0-plugins-base: enable native video in playbin for i.MX SoCs

login
register
mail settings
Submitter Wang Zidan
Date Aug. 6, 2014, 1:56 a.m.
Message ID <1407290185-3111-1-git-send-email-b50113@freescale.com>
Download mbox | patch
Permalink /patch/77343/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Wang Zidan - Aug. 6, 2014, 1:56 a.m.
GST_PLAY_FLAG_NATIVE_VIDEO means link decoder directly with video
render, otherwise, software csc/resize/deinterlace plugins will be
linked between them.

For all i.MX chips, we should enable this flag, as the fsl renders
has the capability to do csc/resize.

Signed-off-by: Wang Zidan <b50113@freescale.com>
---
 .../gstplaybin-enable-native-video.patch           |   31 ++++++++++++++++++++
 .../gstreamer/gstreamer1.0-plugins-base_%.bbappend |    7 +++++
 2 files changed, 38 insertions(+)
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
Otavio Salvador - Aug. 6, 2014, 2:40 p.m.
On Tue, Aug 5, 2014 at 10:56 PM, Wang Zidan <b50113@freescale.com> wrote:
> GST_PLAY_FLAG_NATIVE_VIDEO means link decoder directly with video
> render, otherwise, software csc/resize/deinterlace plugins will be
> linked between them.
>
> For all i.MX chips, we should enable this flag, as the fsl renders
> has the capability to do csc/resize.
>
> Signed-off-by: Wang Zidan <b50113@freescale.com>
> ---
>  .../gstplaybin-enable-native-video.patch           |   31 ++++++++++++++++++++
>  .../gstreamer/gstreamer1.0-plugins-base_%.bbappend |    7 +++++
>  2 files changed, 38 insertions(+)
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
> new file mode 100644
> index 0000000..bc0c0ce
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
> @@ -0,0 +1,31 @@
> +From 9cfb86cd100904f0ef2626f348695bd2d3416c6a Mon Sep 17 00:00:00 2001
> +From: Jian Li <jian.li@freescale.com>
> +Date: Mon, 23 Jun 2014 14:14:07 +0800
> +Subject: [PATCH] gstplaybin enable native video
> +
> +- use native video patch in playbin for i.MX SoCs
> +
> +Upstream Status: N/A

N/A does not exist.

Check:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations

> +Signed-off-by: Jian Li <jian.li@freescale.com>
> +---
> + gst/playback/gstplaybin2.c |    3 +--
> + 1 file changed, 1 insertion(+), 2 deletions(-)
> +
> +diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c
> +index fc02ca3..c342438 100644
> +--- a/gst/playback/gstplaybin2.c
> ++++ b/gst/playback/gstplaybin2.c
> +@@ -511,8 +511,7 @@ struct _GstPlayBinClass
> + #define DEFAULT_SUBURI            NULL
> + #define DEFAULT_SOURCE            NULL
> + #define DEFAULT_FLAGS             GST_PLAY_FLAG_AUDIO | GST_PLAY_FLAG_VIDEO | GST_PLAY_FLAG_TEXT | \
> +-                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_DEINTERLACE | \
> +-                                  GST_PLAY_FLAG_SOFT_COLORBALANCE
> ++                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_NATIVE_VIDEO
> + #define DEFAULT_N_VIDEO           0
> + #define DEFAULT_CURRENT_VIDEO     -1
> + #define DEFAULT_N_AUDIO           0
> +--
> +1.7.9.5
> +
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> new file mode 100644
> index 0000000..25f9d40
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> @@ -0,0 +1,7 @@
> +
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +SRC_URI_append = "${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", " file://gstplaybin-enable-native-video.patch", "", d)}"
> +
> +PACKAGE_ARCH = "${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", "${MACHINE_SOCARCH}", "", d)}"

This should also support gstreamer1.0-imx as this is the community
version and has same capabilities, no? (adding Carlos in Cc)
Carlos Rafael Giani - Aug. 6, 2014, 2:54 p.m.
I suggest: "Upstream-Status: Inappropriate [platform specific]"

On 2014-08-06 16:40, Otavio Salvador wrote:
> On Tue, Aug 5, 2014 at 10:56 PM, Wang Zidan <b50113@freescale.com> wrote:
>> GST_PLAY_FLAG_NATIVE_VIDEO means link decoder directly with video
>> render, otherwise, software csc/resize/deinterlace plugins will be
>> linked between them.
>>
>> For all i.MX chips, we should enable this flag, as the fsl renders
>> has the capability to do csc/resize.
>>
>> Signed-off-by: Wang Zidan <b50113@freescale.com>
>> ---
>>   .../gstplaybin-enable-native-video.patch           |   31 ++++++++++++++++++++
>>   .../gstreamer/gstreamer1.0-plugins-base_%.bbappend |    7 +++++
>>   2 files changed, 38 insertions(+)
>>   create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
>>   create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
>>
>> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
>> new file mode 100644
>> index 0000000..bc0c0ce
>> --- /dev/null
>> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
>> @@ -0,0 +1,31 @@
>> +From 9cfb86cd100904f0ef2626f348695bd2d3416c6a Mon Sep 17 00:00:00 2001
>> +From: Jian Li <jian.li@freescale.com>
>> +Date: Mon, 23 Jun 2014 14:14:07 +0800
>> +Subject: [PATCH] gstplaybin enable native video
>> +
>> +- use native video patch in playbin for i.MX SoCs
>> +
>> +Upstream Status: N/A
> N/A does not exist.
>
> Check:
>
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations
>
>> +Signed-off-by: Jian Li <jian.li@freescale.com>
>> +---
>> + gst/playback/gstplaybin2.c |    3 +--
>> + 1 file changed, 1 insertion(+), 2 deletions(-)
>> +
>> +diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c
>> +index fc02ca3..c342438 100644
>> +--- a/gst/playback/gstplaybin2.c
>> ++++ b/gst/playback/gstplaybin2.c
>> +@@ -511,8 +511,7 @@ struct _GstPlayBinClass
>> + #define DEFAULT_SUBURI            NULL
>> + #define DEFAULT_SOURCE            NULL
>> + #define DEFAULT_FLAGS             GST_PLAY_FLAG_AUDIO | GST_PLAY_FLAG_VIDEO | GST_PLAY_FLAG_TEXT | \
>> +-                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_DEINTERLACE | \
>> +-                                  GST_PLAY_FLAG_SOFT_COLORBALANCE
>> ++                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_NATIVE_VIDEO
>> + #define DEFAULT_N_VIDEO           0
>> + #define DEFAULT_CURRENT_VIDEO     -1
>> + #define DEFAULT_N_AUDIO           0
>> +--
>> +1.7.9.5
>> +
>> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
>> new file mode 100644
>> index 0000000..25f9d40
>> --- /dev/null
>> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
>> @@ -0,0 +1,7 @@
>> +
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +
>> +SRC_URI_append = "${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", " file://gstplaybin-enable-native-video.patch", "", d)}"
>> +
>> +PACKAGE_ARCH = "${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", "${MACHINE_SOCARCH}", "", d)}"
> This should also support gstreamer1.0-imx as this is the community
> version and has same capabilities, no? (adding Carlos in Cc)
>
Otavio Salvador - Aug. 6, 2014, 3 p.m.
On Wed, Aug 6, 2014 at 11:54 AM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> I suggest: "Upstream-Status: Inappropriate [platform specific]"

Agreed.

Patch

diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
new file mode 100644
index 0000000..bc0c0ce
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/gstplaybin-enable-native-video.patch
@@ -0,0 +1,31 @@ 
+From 9cfb86cd100904f0ef2626f348695bd2d3416c6a Mon Sep 17 00:00:00 2001
+From: Jian Li <jian.li@freescale.com>
+Date: Mon, 23 Jun 2014 14:14:07 +0800
+Subject: [PATCH] gstplaybin enable native video
+
+- use native video patch in playbin for i.MX SoCs
+
+Upstream Status: N/A
+
+Signed-off-by: Jian Li <jian.li@freescale.com>
+---
+ gst/playback/gstplaybin2.c |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c
+index fc02ca3..c342438 100644
+--- a/gst/playback/gstplaybin2.c
++++ b/gst/playback/gstplaybin2.c
+@@ -511,8 +511,7 @@ struct _GstPlayBinClass
+ #define DEFAULT_SUBURI            NULL
+ #define DEFAULT_SOURCE            NULL
+ #define DEFAULT_FLAGS             GST_PLAY_FLAG_AUDIO | GST_PLAY_FLAG_VIDEO | GST_PLAY_FLAG_TEXT | \
+-                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_DEINTERLACE | \
+-                                  GST_PLAY_FLAG_SOFT_COLORBALANCE
++                                  GST_PLAY_FLAG_SOFT_VOLUME | GST_PLAY_FLAG_NATIVE_VIDEO
+ #define DEFAULT_N_VIDEO           0
+ #define DEFAULT_CURRENT_VIDEO     -1
+ #define DEFAULT_N_AUDIO           0
+-- 
+1.7.9.5
+
diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
new file mode 100644
index 0000000..25f9d40
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
@@ -0,0 +1,7 @@ 
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+SRC_URI_append = "${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", " file://gstplaybin-enable-native-video.patch", "", d)}"
+
+PACKAGE_ARCH = "${@base_contains("MACHINE_GSTREAMER_1_0_PLUGIN", "gst1.0-fsl-plugin", "${MACHINE_SOCARCH}", "", d)}"
+