Patchwork [19/20] udev: Disable keymap support on machines lacking keyboard support

login
register
mail settings
Submitter Ben Shelton
Date Aug. 4, 2014, 6:41 p.m.
Message ID <b56115f746af1b91da18dc418f8f647345f942fe.1407177403.git.ben.shelton@ni.com>
Download mbox | patch
Permalink /patch/77227/
State New
Headers show

Comments

Ben Shelton - Aug. 4, 2014, 6:41 p.m.
From: Richard Tollerton <rich.tollerton@ni.com>

/lib/udev/keymaps/ is 244k. On headless machines, this is wasted space.

Natinst-Rally-ID: TA44427
Acked-by: Gratian Crisan <gratian.crisan@ni.com>
Natinst-ReviewBoard-ID: 58621
Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
---
 meta/recipes-core/udev/udev.inc | 1 +
 1 file changed, 1 insertion(+)
Martin Jansa - Aug. 4, 2014, 7:41 p.m.
On Mon, Aug 04, 2014 at 01:41:11PM -0500, Ben Shelton wrote:
> From: Richard Tollerton <rich.tollerton@ni.com>
> 
> /lib/udev/keymaps/ is 244k. On headless machines, this is wasted space.
> 
> Natinst-Rally-ID: TA44427
> Acked-by: Gratian Crisan <gratian.crisan@ni.com>
> Natinst-ReviewBoard-ID: 58621
> Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
> ---
>  meta/recipes-core/udev/udev.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
> index 8394064..2d2150c 100644
> --- a/meta/recipes-core/udev/udev.inc
> +++ b/meta/recipes-core/udev/udev.inc
> @@ -51,6 +51,7 @@ EXTRA_OECONF = "--disable-introspection \
>                  --with-rootlibdir=${base_libdir} \
>                  --with-rootprefix= \
>                  --without-systemdsystemunitdir \
> +                ${@base_contains('MACHINE_FEATURES', 'keyboard', '', '--disable-keymap', d)} \

udev isn't MACHINE_ARCH, so you cannot use MACHINE_FEATURES there.

But you can add PACKAGECONFIG and let DISTRO decide if all supported
MACHINEs are headless, it can disable it.

>                 "
>  
>  PACKAGES =+ "udev-cache"
> -- 
> 2.0.4
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
index 8394064..2d2150c 100644
--- a/meta/recipes-core/udev/udev.inc
+++ b/meta/recipes-core/udev/udev.inc
@@ -51,6 +51,7 @@  EXTRA_OECONF = "--disable-introspection \
                 --with-rootlibdir=${base_libdir} \
                 --with-rootprefix= \
                 --without-systemdsystemunitdir \
+                ${@base_contains('MACHINE_FEATURES', 'keyboard', '', '--disable-keymap', d)} \
                "
 
 PACKAGES =+ "udev-cache"