Patchwork [2/2] local.conf.sample.extended: update for preferred ABI

login
register
mail settings
Submitter Robert Yang
Date July 31, 2014, 8:15 a.m.
Message ID <989bf32313d1405858f7839e5474fe9be93fd182.1406794207.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/77013/
State Accepted
Commit 854d9e463b9fdbd5b1d0a4000420f7f328e042f5
Headers show

Comments

Robert Yang - July 31, 2014, 8:15 a.m.
[YOCTO #4073]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/conf/local.conf.sample.extended |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
Robert Yang - July 31, 2014, 8:18 a.m.
On 07/31/2014 04:15 PM, Robert Yang wrote:
> [YOCTO #4073]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   meta/conf/local.conf.sample.extended |   15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/meta/conf/local.conf.sample.extended b/meta/conf/local.conf.sample.extended
> index 89b80a6..8ad7b6f 100644
> --- a/meta/conf/local.conf.sample.extended
> +++ b/meta/conf/local.conf.sample.extended
> @@ -145,6 +145,13 @@
>   #MULTILIBS = "multilib:lib32"
>   #DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
>
> +# Set RPM_PREFER_COLOR to configure preferred ABI when using rpm packaging
> +# backend to generate a rootfs, choices are:
> +# 1: ELF32 wins
> +# 2: ELF64 wins
> +# 3: ELF64 N32 wins (for mips64 or mips64el only)
> +#RPM_PREFER_COLOR ?= "2"
> +
>   # The network based PR service host and port
>   # Uncomment the following lines to enable PRservice.
>   # Set PRSERV_HOST to 'localhost:0' to automatically
> @@ -354,3 +361,11 @@
>   # feed layout is used where package files are placed in <outdir>/<arch>/.
>   #
>   #IPK_HIERARCHICAL_FEED = "1"


I removed the lines below in the git repo, they should be in another patch.

> +
> +# Checks the kernel image size against KERNEL_IMAGE_MAXSIZE (The unit is
> +# Kbytes)
> +#KERNEL_IMAGE_MAXSIZE = "8192"
> +#
> +# Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (The unit is
> +# Kbytes)
> +#IMAGE_ROOTFS_MAXSIZE = "65536"
>

// Robert
Richard Purdie - July 31, 2014, 1:45 p.m.
On Thu, 2014-07-31 at 16:18 +0800, Robert Yang wrote:
> 
> On 07/31/2014 04:15 PM, Robert Yang wrote:
> > [YOCTO #4073]
> >
> > Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> > ---
> >   meta/conf/local.conf.sample.extended |   15 +++++++++++++++
> >   1 file changed, 15 insertions(+)
> >
> > diff --git a/meta/conf/local.conf.sample.extended b/meta/conf/local.conf.sample.extended
> > index 89b80a6..8ad7b6f 100644
> > --- a/meta/conf/local.conf.sample.extended
> > +++ b/meta/conf/local.conf.sample.extended
> > @@ -145,6 +145,13 @@
> >   #MULTILIBS = "multilib:lib32"
> >   #DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
> >
> > +# Set RPM_PREFER_COLOR to configure preferred ABI when using rpm packaging
> > +# backend to generate a rootfs, choices are:
> > +# 1: ELF32 wins
> > +# 2: ELF64 wins
> > +# 3: ELF64 N32 wins (for mips64 or mips64el only)
> > +#RPM_PREFER_COLOR ?= "2"
> > +

Is x86 x32 also color 3?

Cheers,

Richard
Mark Hatle - July 31, 2014, 1:55 p.m.
On 7/31/14, 8:45 AM, Richard Purdie wrote:
> On Thu, 2014-07-31 at 16:18 +0800, Robert Yang wrote:
>>
>> On 07/31/2014 04:15 PM, Robert Yang wrote:
>>> [YOCTO #4073]
>>>
>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>> ---
>>>    meta/conf/local.conf.sample.extended |   15 +++++++++++++++
>>>    1 file changed, 15 insertions(+)
>>>
>>> diff --git a/meta/conf/local.conf.sample.extended b/meta/conf/local.conf.sample.extended
>>> index 89b80a6..8ad7b6f 100644
>>> --- a/meta/conf/local.conf.sample.extended
>>> +++ b/meta/conf/local.conf.sample.extended
>>> @@ -145,6 +145,13 @@
>>>    #MULTILIBS = "multilib:lib32"
>>>    #DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
>>>
>>> +# Set RPM_PREFER_COLOR to configure preferred ABI when using rpm packaging
>>> +# backend to generate a rootfs, choices are:
>>> +# 1: ELF32 wins
>>> +# 2: ELF64 wins
>>> +# 3: ELF64 N32 wins (for mips64 or mips64el only)
>>> +#RPM_PREFER_COLOR ?= "2"
>>> +
>
> Is x86 x32 also color 3?

x32 support was never implemented.  RPM has no unique identification for x32 
binaries at this time.  They're treated as ELF64 if I remember correctly.

If implemented, I would expect it to piggy back on '3' as well.

--Mark

> Cheers,
>
> Richard
>

Patch

diff --git a/meta/conf/local.conf.sample.extended b/meta/conf/local.conf.sample.extended
index 89b80a6..8ad7b6f 100644
--- a/meta/conf/local.conf.sample.extended
+++ b/meta/conf/local.conf.sample.extended
@@ -145,6 +145,13 @@ 
 #MULTILIBS = "multilib:lib32"
 #DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
 
+# Set RPM_PREFER_COLOR to configure preferred ABI when using rpm packaging
+# backend to generate a rootfs, choices are:
+# 1: ELF32 wins
+# 2: ELF64 wins
+# 3: ELF64 N32 wins (for mips64 or mips64el only)
+#RPM_PREFER_COLOR ?= "2"
+
 # The network based PR service host and port
 # Uncomment the following lines to enable PRservice.
 # Set PRSERV_HOST to 'localhost:0' to automatically
@@ -354,3 +361,11 @@ 
 # feed layout is used where package files are placed in <outdir>/<arch>/.
 #
 #IPK_HIERARCHICAL_FEED = "1"
+
+# Checks the kernel image size against KERNEL_IMAGE_MAXSIZE (The unit is
+# Kbytes)
+#KERNEL_IMAGE_MAXSIZE = "8192"
+#
+# Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (The unit is
+# Kbytes)
+#IMAGE_ROOTFS_MAXSIZE = "65536"