Patchwork packagegroup-core-standalone-sdk-target: include static libs

login
register
mail settings
Submitter Ben Shelton
Date July 28, 2014, 6:26 p.m.
Message ID <1406571990-4821-1-git-send-email-ben.shelton@ni.com>
Download mbox | patch
Permalink /patch/76771/
State New
Headers show

Comments

Ben Shelton - July 28, 2014, 6:26 p.m.
From: Richard Tollerton <rich.tollerton@ni.com>

meta-toolchain ought to include static libs.  This fixes an issue we saw
where a compile against libsupc++.a failed due to the missing library.

Acked-by: Gratian Crisan <gratian.crisan@ni.com>
Acked-by: Brad Mouring <brad.mouring@ni.com>
Acked-by: Ken Sharp <ken.sharp@ni.com>
Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
Signed-off-by: Ben Shelton <ben.shelton@ni.com>
---
 .../packagegroups/packagegroup-core-standalone-sdk-target.bb             | 1 +
 1 file changed, 1 insertion(+)
Khem Raj - July 28, 2014, 6:36 p.m.
On Mon, Jul 28, 2014 at 11:26 AM, Ben Shelton <ben.shelton@ni.com> wrote:
> meta-toolchain ought to include static libs.  This fixes an issue we saw
> where a compile against libsupc++.a failed due to the missing library.

I don't think this is a good idea. There are license implications of
static linking. You have to specific about it. However this case is
different since libsupc++ is special library and also have runtime
exceptions. You should move this library to libstdc++-dev package
instead.

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb b/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb
index 5d1ce97..da57b36 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb
@@ -9,6 +9,7 @@  RDEPENDS_${PN} = "\
     libgcc-dev \
     libstdc++ \
     libstdc++-dev \
+    libstdc++-staticdev \
     ${LIBC_DEPENDENCIES} \
     qemuwrapper-cross \
     "