Patchwork bitbake.conf: Change TERM default fallback to XTERM instead of GNOME_TERM

login
register
mail settings
Submitter Khem Raj
Date July 15, 2011, 9:23 p.m.
Message ID <1310764987-26717-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/7669/
State New, archived
Headers show

Comments

Khem Raj - July 15, 2011, 9:23 p.m.
Its better to use xterm since some folks may not be using gnome
or KDE. Chances of having xterm on build machines are lot more
than having gnome-terminal.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/conf/bitbake.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Darren Hart - July 16, 2011, 5:49 a.m.
On 07/15/2011 02:23 PM, Khem Raj wrote:
> Its better to use xterm since some folks may not be using gnome
> or KDE. Chances of having xterm on build machines are lot more
> than having gnome-terminal.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Thank you, this is something I've been meaning to do for a while.

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  meta/conf/bitbake.conf |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 463991d..128b0b6 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -571,8 +571,8 @@ KONSOLE_TERMCMD = 'konsole -T "$TERMWINDOWTITLE"'
>  KONSOLE_TERMCMDRUN = '${KONSOLE_TERMCMD} -e $SHELLCMDS'
>  
>  # Set a default
> -TERMCMD ?= "${GNOME_TERMCMD}"
> -TERMCMDRUN ?= "${GNOME_TERMCMDRUN}"
> +TERMCMD ?= "${XTERM_TERMCMD}"
> +TERMCMDRUN ?= "${XTERM_TERMCMDRUN}"
>  
>  ##################################################################
>  # Miscellaneous utilities.

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 463991d..128b0b6 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -571,8 +571,8 @@  KONSOLE_TERMCMD = 'konsole -T "$TERMWINDOWTITLE"'
 KONSOLE_TERMCMDRUN = '${KONSOLE_TERMCMD} -e $SHELLCMDS'
 
 # Set a default
-TERMCMD ?= "${GNOME_TERMCMD}"
-TERMCMDRUN ?= "${GNOME_TERMCMDRUN}"
+TERMCMD ?= "${XTERM_TERMCMD}"
+TERMCMDRUN ?= "${XTERM_TERMCMDRUN}"
 
 ##################################################################
 # Miscellaneous utilities.