Patchwork shadow-securetty: add freescale lpuart

login
register
mail settings
Submitter Stefan Agner
Date July 24, 2014, 7:44 a.m.
Message ID <1406187862-2819-1-git-send-email-stefan@agner.ch>
Download mbox | patch
Permalink /patch/76561/
State Accepted
Commit 3754726de9c75ee6c7bd6a16eeac09a672dc15d1
Headers show

Comments

Stefan Agner - July 24, 2014, 7:44 a.m.
Add Freescale lpuart tty's (ttyLPx) to securetty. Freescale Vybrid
devices running upstream kernel use this driver.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 meta/recipes-extended/shadow/files/securetty | 8 ++++++++
 1 file changed, 8 insertions(+)
Mark Hatle - July 24, 2014, 2:03 p.m.
We should probably be setting up the securetty file in a machine specific way.

Doing it generically just pollutes the file with more stuff a specific user 
won't want.

(Note, you aren't the first to do this.. so right now it's probably the best 
answer, but we should fix this in the future.)

--Mark

On 7/24/14, 2:44 AM, Stefan Agner wrote:
> Add Freescale lpuart tty's (ttyLPx) to securetty. Freescale Vybrid
> devices running upstream kernel use this driver.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>   meta/recipes-extended/shadow/files/securetty | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/meta/recipes-extended/shadow/files/securetty b/meta/recipes-extended/shadow/files/securetty
> index 0b1629f..d919993 100644
> --- a/meta/recipes-extended/shadow/files/securetty
> +++ b/meta/recipes-extended/shadow/files/securetty
> @@ -137,6 +137,14 @@ ttymxc3
>   ttymxc4
>   ttymxc5
>
> +# Freescale lpuart ports
> +ttyLP0
> +ttyLP1
> +ttyLP2
> +ttyLP3
> +ttyLP4
> +ttyLP5
> +
>   # Standard serial ports, with devfs
>   tts/0
>   tts/1
>
Saul Wold - July 24, 2014, 5:13 p.m.
On 07/24/2014 07:03 AM, Mark Hatle wrote:
> We should probably be setting up the securetty file in a machine
> specific way.
>
> Doing it generically just pollutes the file with more stuff a specific
> user won't want.
>
> (Note, you aren't the first to do this.. so right now it's probably the
> best answer, but we should fix this in the future.)
>

Mark,

can you please file a bug to track this, I will mark it as an unassigned 
future / low for someone to pick up.

Sau!

> --Mark
>
> On 7/24/14, 2:44 AM, Stefan Agner wrote:
>> Add Freescale lpuart tty's (ttyLPx) to securetty. Freescale Vybrid
>> devices running upstream kernel use this driver.
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
>>   meta/recipes-extended/shadow/files/securetty | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/meta/recipes-extended/shadow/files/securetty
>> b/meta/recipes-extended/shadow/files/securetty
>> index 0b1629f..d919993 100644
>> --- a/meta/recipes-extended/shadow/files/securetty
>> +++ b/meta/recipes-extended/shadow/files/securetty
>> @@ -137,6 +137,14 @@ ttymxc3
>>   ttymxc4
>>   ttymxc5
>>
>> +# Freescale lpuart ports
>> +ttyLP0
>> +ttyLP1
>> +ttyLP2
>> +ttyLP3
>> +ttyLP4
>> +ttyLP5
>> +
>>   # Standard serial ports, with devfs
>>   tts/0
>>   tts/1
>>
>

Patch

diff --git a/meta/recipes-extended/shadow/files/securetty b/meta/recipes-extended/shadow/files/securetty
index 0b1629f..d919993 100644
--- a/meta/recipes-extended/shadow/files/securetty
+++ b/meta/recipes-extended/shadow/files/securetty
@@ -137,6 +137,14 @@  ttymxc3
 ttymxc4
 ttymxc5
 
+# Freescale lpuart ports
+ttyLP0
+ttyLP1
+ttyLP2
+ttyLP3
+ttyLP4
+ttyLP5
+
 # Standard serial ports, with devfs
 tts/0
 tts/1