Patchwork [V3,0/1] insane: add checking to standardize how .bbappend files do FILESEXTRAPATHS

login
register
mail settings
Submitter Hongxu Jia
Date July 23, 2014, 3:33 a.m.
Message ID <cover.1406085105.git.hongxu.jia@windriver.com>
Download mbox
Permalink /patch/76449/
State Accepted
Commit 68bc4eb778764e4fa66dd6296ca2042e7a9ebf67
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib hongxu/filesextrapaths

Comments

Hongxu Jia - July 23, 2014, 3:33 a.m.
Change in V3:
- Make the error message more readable. The incorrect assignment
  info will be helpful for issue location.

Change in V2:
- It is more reasonable to move the checking to insance.bbclass
  rather than create a new bbclass. 

Test Steps:

1) Add git://git.yoctoproject.org/meta-fsl-ppc layer
   The openssl and cryptodev-fsl incorrectly assigned
   FILESEXTRAPATHS which forgot the colon.(I have sent the
   fix to meta-fsl-ppc layer mail list)
   ...
   FILESEXTRAPATHS_prepend := "${THISDIR}/openssl-fsl"
   ...
   FILESEXTRAPATHS_prepend := "${THISDIR}/cryptodev-fsl"
   ...
2) bitbake openssl
...
ERROR: FILESEXTRAPATHS-variable, must always use _prepend (or _append)
type of assignment, and don't forget the colon.
Please assign it with the format of:
  FILESEXTRAPATHS_append := ":${THISDIR}/Your_Files_Path" or
  FILESEXTRAPATHS_prepend := "${THISDIR}/Your_Files_Path:"
in your bbappend file

Your incorrect assignment is:
/home/jiahongxu/yocto/meta-openembedded/meta-fsl-ppc/recipes-connectivity/openssl/openssl-fsl__default:

ERROR: Failed to parse recipe: /home/jiahongxu/yocto/meta-openembedded/meta-fsl-ppc/recipes-connectivity/openssl/openssl_1.0.1g.bb
...
 
//Hongxu



The following changes since commit 4d2ac6f6df2b3ef98699dd4f7afadb2d994222bb:

  rootfs: Remove the extraneous install directory (2014-07-19 00:18:21 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib hongxu/filesextrapaths
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/filesextrapaths

Hongxu Jia (1):
  insane: add checking to standardize how .bbappend files do
    FILESEXTRAPATHS

 meta/classes/insane.bbclass | 13 +++++++++++++
 meta/classes/utils.bbclass  |  2 ++
 meta/conf/bitbake.conf      |  2 ++
 3 files changed, 17 insertions(+)
Hongxu Jia - July 25, 2014, 8:22 a.m.
Ping

The fix in meta-fsl-ppc has been merged. It will not break the autobuilder.

//Hongxu

On 07/23/2014 11:33 AM, Hongxu Jia wrote:
> Change in V3:
> - Make the error message more readable. The incorrect assignment
>    info will be helpful for issue location.
>
> Change in V2:
> - It is more reasonable to move the checking to insance.bbclass
>    rather than create a new bbclass.
>
> Test Steps:
>
> 1) Add git://git.yoctoproject.org/meta-fsl-ppc layer
>     The openssl and cryptodev-fsl incorrectly assigned
>     FILESEXTRAPATHS which forgot the colon.(I have sent the
>     fix to meta-fsl-ppc layer mail list)
>     ...
>     FILESEXTRAPATHS_prepend := "${THISDIR}/openssl-fsl"
>     ...
>     FILESEXTRAPATHS_prepend := "${THISDIR}/cryptodev-fsl"
>     ...
> 2) bitbake openssl
> ...
> ERROR: FILESEXTRAPATHS-variable, must always use _prepend (or _append)
> type of assignment, and don't forget the colon.
> Please assign it with the format of:
>    FILESEXTRAPATHS_append := ":${THISDIR}/Your_Files_Path" or
>    FILESEXTRAPATHS_prepend := "${THISDIR}/Your_Files_Path:"
> in your bbappend file
>
> Your incorrect assignment is:
> /home/jiahongxu/yocto/meta-openembedded/meta-fsl-ppc/recipes-connectivity/openssl/openssl-fsl__default:
>
> ERROR: Failed to parse recipe: /home/jiahongxu/yocto/meta-openembedded/meta-fsl-ppc/recipes-connectivity/openssl/openssl_1.0.1g.bb
> ...
>   
> //Hongxu
>
>
>
> The following changes since commit 4d2ac6f6df2b3ef98699dd4f7afadb2d994222bb:
>
>    rootfs: Remove the extraneous install directory (2014-07-19 00:18:21 +0100)
>
> are available in the git repository at:
>
>    git://git.pokylinux.org/poky-contrib hongxu/filesextrapaths
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/filesextrapaths
>
> Hongxu Jia (1):
>    insane: add checking to standardize how .bbappend files do
>      FILESEXTRAPATHS
>
>   meta/classes/insane.bbclass | 13 +++++++++++++
>   meta/classes/utils.bbclass  |  2 ++
>   meta/conf/bitbake.conf      |  2 ++
>   3 files changed, 17 insertions(+)
>