Patchwork connman: Fix PPTP VPN plugin QA issue

login
register
mail settings
Submitter Jukka Rissanen
Date July 21, 2014, 10:03 a.m.
Message ID <1405936990-10656-1-git-send-email-jukka.rissanen@linux.intel.com>
Download mbox | patch
Permalink /patch/76173/
State New
Headers show

Comments

Jukka Rissanen - July 21, 2014, 10:03 a.m.
Fixing this error by skipping dev-so QA check for
connman-plugin-vpn-pptp package.

ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so: connman-plugin-vpn-pptp path '/work/core2-32-oe-linux/connman/1.24+gitAUTOINC+42779cd63c-r20.0/packages-split/connman-plugin-vpn-pptp/usr/lib/connman/scripts/libppp-plugin.so' [dev-so]
ERROR: QA run found fatal errors. Please consider fixing them.
ERROR: Function failed: do_package_qa

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
---
Hi,

just upgraded to head 4d2ac6f6df2b3ef98699dd4f7afadb2d994222bb in master and started
to see this QA error. Adding proper INSANE_SKIP seem to fix it. Just wondered why
I am seeing this now but not earlier.


Cheers,
Jukka


 meta/recipes-connectivity/connman/connman.inc | 1 +
 1 file changed, 1 insertion(+)
Ross Burton - July 21, 2014, 10:55 a.m.
On 21 July 2014 11:03, Jukka Rissanen <jukka.rissanen@linux.intel.com> wrote:
> Fixing this error by skipping dev-so QA check for
> connman-plugin-vpn-pptp package.

As discussed on IM but repeating for the list, plugins should always
be real .so files and not symlinks to versioned files.

If a plugin is on disk as symlinks and versioned files, then you need
to pass more flags to libtool: -shared -avoid-version -module is the
canonical set to get a loadable module without a static counterpart
and versioned symlinks.

Ideally a few patches to the build will remove the need for every
dev-so insane skip in connman.

Ross
Jukka Rissanen - July 21, 2014, 11:07 a.m.
Hi Ross,

On ma, 2014-07-21 at 11:55 +0100, Burton, Ross wrote:
> On 21 July 2014 11:03, Jukka Rissanen <jukka.rissanen@linux.intel.com> wrote:
> > Fixing this error by skipping dev-so QA check for
> > connman-plugin-vpn-pptp package.
> 
> As discussed on IM but repeating for the list, plugins should always
> be real .so files and not symlinks to versioned files.
> 
> If a plugin is on disk as symlinks and versioned files, then you need
> to pass more flags to libtool: -shared -avoid-version -module is the
> canonical set to get a loadable module without a static counterpart
> and versioned symlinks.
> 
> Ideally a few patches to the build will remove the need for every
> dev-so insane skip in connman.

Sure, I can prepare a more sane version :)


Cheers,
Jukka

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index f121a81..3e9d027 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -211,5 +211,6 @@  DESCRIPTION_${PN}-plugin-vpn-pptp = "The ConnMan PPTP plugin uses pptp-linux cli
 to create a VPN connection to PPTP server."
 FILES_${PN}-plugin-vpn-pptp += "${libdir}/connman/scripts/libppp-plugin.so* \
                                 ${libdir}/connman/plugins-vpn/pptp.so"
+INSANE_SKIP_${PN}-plugin-vpn-pptp += "dev-so"
 RDEPENDS_${PN}-plugin-vpn-pptp += "${PN}-vpn"
 RRECOMMENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG','pptp','${PN}-plugin-vpn-pptp', '', d)}"