Patchwork [meta-fsl-arm,1/2] gpu-viv-bin-mx6q: Fix file ownership in packages

login
register
mail settings
Submitter Jacob Kroon
Date July 18, 2014, 9:05 p.m.
Message ID <1405717544-2513-1-git-send-email-jacob.kroon@mikrodidakt.se>
Download mbox | patch
Permalink /patch/76097/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Jacob Kroon - July 18, 2014, 9:05 p.m.
The do_install() function is run under pseudo in order to create packages with
correct file-permissions. By issuing "cp -a" to install files, we leak
build user/group permissions into the packages, since the do_unpack() function
is executed as the regular build user. Replace it with -P, so that we at least
keep symlinks.

Also drop -x (--one-file-system) since it's not needed.

This was tested by comparing the output of "ls -lR --time-style=+ image/"
before and after the change.

Signed-off-by: Jacob Kroon <jacob.kroon@mikrodidakt.se>
---
 recipes-graphics/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.inc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch

diff --git a/recipes-graphics/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.inc b/recipes-graphics/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.inc
index 4106848..901f7d3 100644
--- a/recipes-graphics/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.inc
+++ b/recipes-graphics/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.inc
@@ -108,9 +108,9 @@  do_install () {
     install -d ${D}${libdir}
     install -d ${D}${includedir}
 
-    cp -a ${S}/usr/lib/*.so* ${D}${libdir}
-    cp -axr ${S}/usr/include/* ${D}${includedir}
-    cp -axr ${S}/opt ${D}
+    cp -P ${S}/usr/lib/*.so* ${D}${libdir}
+    cp -r ${S}/usr/include/* ${D}${includedir}
+    cp -r ${S}/opt ${D}
 
     install -d ${D}${libdir}/pkgconfig
 
@@ -170,7 +170,7 @@  do_install () {
 
     # update libglesv2 as backend dependent
     rm -rf ${D}${libdir}/libGLESv2*
-    cp -a ${S}/usr/lib/libGLESv2-${backend}.so ${D}${libdir}/libGLESv2.so.2.0.0
+    cp ${S}/usr/lib/libGLESv2-${backend}.so ${D}${libdir}/libGLESv2.so.2.0.0
     ln -sf libGLESv2.so.2.0.0 ${D}${libdir}/libGLESv2.so.2
     ln -sf libGLESv2.so.2.0.0 ${D}${libdir}/libGLESv2.so