Patchwork [meta-fsl-networking] recipes-bsp/tcf-qorqdbg doesn't build with poky master

login
register
mail settings
Submitter Ting Liu
Date July 16, 2014, 6:44 a.m.
Message ID <49f1f4094a424bb5887c3710cb9f95d3@BN1PR03MB156.namprd03.prod.outlook.com>
Download mbox | patch
Permalink /patch/75745/
State Rejected
Headers show

Comments

Ting Liu - July 16, 2014, 6:44 a.m.
Hello Bob,

You are right. Here is the patch:


> -----Original Message-----
> From: Bob Cochran [mailto:yocto@mindchasers.com]
> Sent: Wednesday, July 16, 2014 2:21 AM
> To: Liu Ting-B28495
> Cc: meta-freescale@yoctoproject.org
> Subject: [meta-fsl-networking] recipes-bsp/tcf-qorqdbg doesn't build with poky
> master
> 
> I worked around it by changing inherit autotools to inherit autotools-
> brokensep.
> 
> However, perhaps this recipe should be written as a makefile only recipe (not
> inherit autotools) since there is no autoconf support / configure script in
> the archive.
> 
> 
>
Bob Cochran - July 16, 2014, 10:06 p.m.
On 07/16/2014 02:44 AM, ting.liu@freescale.com wrote:
> Hello Bob,
>
> You are right. Here is the patch:
>
> --- a/recipes-bsp/tcf-qoriqdbg/tcf-qoriqdbg_4.0.0.105390.bb
> +++ b/recipes-bsp/tcf-qoriqdbg/tcf-qoriqdbg_4.0.0.105390.bb
> @@ -11,6 +11,13 @@ SRC_URI = "file://${BPN}-${PV}.tar.bz2 \
>   SRC_URI[md5sum] = "f11b99b489030d9f35573e91c4404e03"
>   SRC_URI[sha256sum] = "3250e2951c3b57bfc3dc9e1174e38555e75682ad90831720a7c882093c119f2b"
>
> -inherit autotools
> -
>   EXTRA_OEMAKE += "CXX='${CXX}'"


Hi Ting,

In my default environment on Poky master, EXTRA_OEMAKE has a default 
"-e", which instructs make to use environment vars over the vars 
internal to the Makefile.  Therefore, it doesn't build.  The "-e" is 
part of the default EXTRA_OEMAKE setting in meta/conf/bitbake.conf.

It builds if I replace "EXTRA_OEMAKE +=" with "EXTRA_OEMAKE =" in the 
recipe, but I suspect it might be better (for yocto developers) to move 
the compiler and linker flags out to the recipe and include them in 
EXTRA_OEMAKE.

I'll leave it up to you.

Bob





> +
> +do_compile() {
> +    oe_runmake all
> +}
> +
> +do_install() {
> +    oe_runmake DESTDIR=${D} install
> +}
> +
>
>> -----Original Message-----
>> From: Bob Cochran [mailto:yocto@mindchasers.com]
>> Sent: Wednesday, July 16, 2014 2:21 AM
>> To: Liu Ting-B28495
>> Cc: meta-freescale@yoctoproject.org
>> Subject: [meta-fsl-networking] recipes-bsp/tcf-qorqdbg doesn't build with poky
>> master
>>
>> I worked around it by changing inherit autotools to inherit autotools-
>> brokensep.
>>
>> However, perhaps this recipe should be written as a makefile only recipe (not
>> inherit autotools) since there is no autoconf support / configure script in
>> the archive.
>>
>>
>>
>
>

Patch

--- a/recipes-bsp/tcf-qoriqdbg/tcf-qoriqdbg_4.0.0.105390.bb
+++ b/recipes-bsp/tcf-qoriqdbg/tcf-qoriqdbg_4.0.0.105390.bb
@@ -11,6 +11,13 @@  SRC_URI = "file://${BPN}-${PV}.tar.bz2 \
 SRC_URI[md5sum] = "f11b99b489030d9f35573e91c4404e03"
 SRC_URI[sha256sum] = "3250e2951c3b57bfc3dc9e1174e38555e75682ad90831720a7c882093c119f2b"
 
-inherit autotools
-
 EXTRA_OEMAKE += "CXX='${CXX}'"
+
+do_compile() {
+    oe_runmake all
+}
+
+do_install() {
+    oe_runmake DESTDIR=${D} install
+}
+