Patchwork [1/5] wic: Error on parted non-zero error code

mail settings
Date July 15, 2014, 3:43 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/75661/
State Accepted
Commit b1c68e5446080f0743f7f8a530f3b00f90c8717d
Headers show

Comments - July 15, 2014, 3:43 p.m.
The current code uses msger.debug() to note errors, effectively
squelching them if --debug isn't used.  Apparently this is because it
can return non-zero for some loop device failures.  We don't care
about loop devices, and not paying attention to the error code
actually results in invalid images, so error out on parted failures as
we should be.

Signed-off-by: Tom Zanussi <>
 scripts/lib/mic/utils/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/scripts/lib/mic/utils/ b/scripts/lib/mic/utils/
index 6607466..593cf1f 100644
--- a/scripts/lib/mic/utils/
+++ b/scripts/lib/mic/utils/
@@ -272,7 +272,7 @@  class PartitionedMount(Mount):
             # parted always fails to reload part table with loop devices. This
             # prevents us from distinguishing real errors based on return
             # code.
-            msger.debug("WARNING: parted returned '%s' instead of 0" % rc)
+            msger.error("WARNING: parted returned '%s' instead of 0 (use --debug for details)" % rc)
     def __create_partition(self, device, parttype, fstype, start, size):
         """ Create a partition on an image described by the 'device' object. """