Patchwork [13/38] gnu-config: add perl to RDEPENDS_gnu-config

login
register
mail settings
Submitter Robert Yang
Date July 15, 2014, 2:19 p.m.
Message ID <c6ba65dc4b22e743a8aef32cf77b08c6eca388fc.1405433828.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/75587/
State New
Headers show

Comments

Robert Yang - July 15, 2014, 2:19 p.m.
Perl script:
gnu-config/usr/bin/gnu-configize

[YOCTO #1662]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 .../gnu-config/gnu-config_20120814.bb              |    2 ++
 meta/recipes-devtools/gnu-config/gnu-config_git.bb |    2 ++
 2 files changed, 4 insertions(+)
Khem Raj - July 15, 2014, 3:40 p.m.
On Tue, Jul 15, 2014 at 7:19 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
> Perl script:
> gnu-config/usr/bin/gnu-configize

will it impact native recipes too ?

>
> [YOCTO #1662]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  .../gnu-config/gnu-config_20120814.bb              |    2 ++
>  meta/recipes-devtools/gnu-config/gnu-config_git.bb |    2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb b/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
> index d67466a..af4afd6 100644
> --- a/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
> +++ b/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
> @@ -17,6 +17,8 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/gnu-config/gnu-config-${PV
>  SRC_URI[md5sum] = "bcfca5a2bb39edad4aae5a65efc84094"
>  SRC_URI[sha256sum] = "44f99a8e76f3e8e4fec0bb5ad4762f8e44366168554ce66cb85afbe2ed3efd8b"
>
> +RDEPENDS_${PN} += "perl"
> +
>  do_compile() {
>         :
>  }
> diff --git a/meta/recipes-devtools/gnu-config/gnu-config_git.bb b/meta/recipes-devtools/gnu-config/gnu-config_git.bb
> index 00fa759..d1b0a59 100644
> --- a/meta/recipes-devtools/gnu-config/gnu-config_git.bb
> +++ b/meta/recipes-devtools/gnu-config/gnu-config_git.bb
> @@ -17,6 +17,8 @@ SRC_URI = "git://git.sv.gnu.org/config.git \
>
>  S = "${WORKDIR}/git"
>
> +RDEPENDS_${PN} += "perl"
> +
>  do_compile() {
>         :
>  }
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Robert Yang - July 16, 2014, 3:01 a.m.
On 07/15/2014 11:40 PM, Khem Raj wrote:
> On Tue, Jul 15, 2014 at 7:19 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
>> Perl script:
>> gnu-config/usr/bin/gnu-configize
>
> will it impact native recipes too ?

Yes, it will, thanks, update it to target only in the git repo,

RDEPENDS_${PN}_class-target += "perl"

// Robert

>
>>
>> [YOCTO #1662]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   .../gnu-config/gnu-config_20120814.bb              |    2 ++
>>   meta/recipes-devtools/gnu-config/gnu-config_git.bb |    2 ++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb b/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
>> index d67466a..af4afd6 100644
>> --- a/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
>> +++ b/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
>> @@ -17,6 +17,8 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/gnu-config/gnu-config-${PV
>>   SRC_URI[md5sum] = "bcfca5a2bb39edad4aae5a65efc84094"
>>   SRC_URI[sha256sum] = "44f99a8e76f3e8e4fec0bb5ad4762f8e44366168554ce66cb85afbe2ed3efd8b"
>>
>> +RDEPENDS_${PN} += "perl"
>> +
>>   do_compile() {
>>          :
>>   }
>> diff --git a/meta/recipes-devtools/gnu-config/gnu-config_git.bb b/meta/recipes-devtools/gnu-config/gnu-config_git.bb
>> index 00fa759..d1b0a59 100644
>> --- a/meta/recipes-devtools/gnu-config/gnu-config_git.bb
>> +++ b/meta/recipes-devtools/gnu-config/gnu-config_git.bb
>> @@ -17,6 +17,8 @@ SRC_URI = "git://git.sv.gnu.org/config.git \
>>
>>   S = "${WORKDIR}/git"
>>
>> +RDEPENDS_${PN} += "perl"
>> +
>>   do_compile() {
>>          :
>>   }
>> --
>> 1.7.9.5
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
Richard Purdie - July 16, 2014, 8:35 a.m.
On Wed, 2014-07-16 at 11:01 +0800, Robert Yang wrote:
> 
> On 07/15/2014 11:40 PM, Khem Raj wrote:
> > On Tue, Jul 15, 2014 at 7:19 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
> >> Perl script:
> >> gnu-config/usr/bin/gnu-configize
> >
> > will it impact native recipes too ?
> 
> Yes, it will, thanks, update it to target only in the git repo,
> 
> RDEPENDS_${PN}_class-target += "perl"

Please don't do that. perl-native should be in ASSUME_PROVIDED so we
should be safe from that angle (but we should check).

The autobuilder showed an error with these changes:

https://autobuilder.yoctoproject.org/main/builders/build-appliance/builds/170/steps/BuildImages/logs/stdio

(see the bash-native ERROR) so we probably need to add bash-native to
ASSUME_PROVIDED to fix that.

Cheers,

Richard

Patch

diff --git a/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb b/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
index d67466a..af4afd6 100644
--- a/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
+++ b/meta/recipes-devtools/gnu-config/gnu-config_20120814.bb
@@ -17,6 +17,8 @@  SRC_URI = "http://downloads.yoctoproject.org/releases/gnu-config/gnu-config-${PV
 SRC_URI[md5sum] = "bcfca5a2bb39edad4aae5a65efc84094"
 SRC_URI[sha256sum] = "44f99a8e76f3e8e4fec0bb5ad4762f8e44366168554ce66cb85afbe2ed3efd8b"
 
+RDEPENDS_${PN} += "perl"
+
 do_compile() {
 	:
 }
diff --git a/meta/recipes-devtools/gnu-config/gnu-config_git.bb b/meta/recipes-devtools/gnu-config/gnu-config_git.bb
index 00fa759..d1b0a59 100644
--- a/meta/recipes-devtools/gnu-config/gnu-config_git.bb
+++ b/meta/recipes-devtools/gnu-config/gnu-config_git.bb
@@ -17,6 +17,8 @@  SRC_URI = "git://git.sv.gnu.org/config.git \
 
 S = "${WORKDIR}/git"
 
+RDEPENDS_${PN} += "perl"
+
 do_compile() {
 	:
 }