Patchwork [meta-oe] V2 lz4: update to latest version

login
register
mail settings
Submitter Armin Kuster
Date July 15, 2014, 1:41 a.m.
Message ID <1405388483-30716-1-git-send-email-akuster@mvista.com>
Download mbox | patch
Permalink /patch/75493/
State New
Headers show

Comments

Armin Kuster - July 15, 2014, 1:41 a.m.
update to version r119
Use github instead of svn
LICENSE md5sum changed since it was updated in r117
FIxes CVE-2014-4611

Signed-off-by: Armin Kuster <akuster@mvista.com>
---
 meta/recipes-support/lz4/lz4_git.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta/recipes-support/lz4/lz4_git.bb
Armin Kuster - July 15, 2014, 5:30 a.m.
Bah,

missed removing old recipe and wrong list.

- Armin

On 07/14/2014 06:41 PM, Armin Kuster wrote:
> update to version r119
> Use github instead of svn
> LICENSE md5sum changed since it was updated in r117
> FIxes CVE-2014-4611
>
> Signed-off-by: Armin Kuster <akuster@mvista.com>
> ---
>   meta/recipes-support/lz4/lz4_git.bb | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>   create mode 100644 meta/recipes-support/lz4/lz4_git.bb
>
> diff --git a/meta/recipes-support/lz4/lz4_git.bb b/meta/recipes-support/lz4/lz4_git.bb
> new file mode 100644
> index 0000000..3978d76
> --- /dev/null
> +++ b/meta/recipes-support/lz4/lz4_git.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "Extremely Fast Compression algorithm"
> +DESCRIPTION = "LZ4 is a very fast lossless compression algorithm, providing compression speed at 400 MB/s per core, scalable with multi-cores CPU. It also features an extremely fast decoder, with speed in multiple GB/s per core, typically reaching RAM speed limits on multi-core systems."
> +
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=0b0d063f37a4477b54af2459477dcafd"
> +
> +SRCREV = "28fd251bc7b42e5cde15f9a2d78fc53b3b575558"
> +SRC_URI= "git://github.com/Cyan4973/lz4.git;branch=master"
> +
> +S = "${WORKDIR}/git"
> +
> +EXTRA_OEMAKE = "PREFIX=${prefix} CC='${CC}' DESTDIR=${D} LIBDIR=${libdir} INCLUDEDIR=${includedir}"
> +
> +do_install() {
> +	oe_runmake install
> +}
> +
> +BBCLASSEXTEND += "native nativesdk"
>
Richard Purdie - July 16, 2014, 9:11 a.m.
On Mon, 2014-07-14 at 18:41 -0700, Armin Kuster wrote:
> update to version r119
> Use github instead of svn

I'm still a little concerned about this change from svn to git. Which is
the definitive source? It looks like the svn repo is active too?

I just don't want to end up in a position where we're pulling from
someone's hack'n'dev version of lz4 rather than the place considered the
real "master" source...

Cheers,

Richard


> LICENSE md5sum changed since it was updated in r117
> FIxes CVE-2014-4611
> 
> Signed-off-by: Armin Kuster <akuster@mvista.com>
> ---
>  meta/recipes-support/lz4/lz4_git.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta/recipes-support/lz4/lz4_git.bb
> 
> diff --git a/meta/recipes-support/lz4/lz4_git.bb b/meta/recipes-support/lz4/lz4_git.bb
> new file mode 100644
> index 0000000..3978d76
> --- /dev/null
> +++ b/meta/recipes-support/lz4/lz4_git.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "Extremely Fast Compression algorithm"
> +DESCRIPTION = "LZ4 is a very fast lossless compression algorithm, providing compression speed at 400 MB/s per core, scalable with multi-cores CPU. It also features an extremely fast decoder, with speed in multiple GB/s per core, typically reaching RAM speed limits on multi-core systems."
> +
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=0b0d063f37a4477b54af2459477dcafd"
> +
> +SRCREV = "28fd251bc7b42e5cde15f9a2d78fc53b3b575558"
> +SRC_URI= "git://github.com/Cyan4973/lz4.git;branch=master"
> +
> +S = "${WORKDIR}/git"
> +
> +EXTRA_OEMAKE = "PREFIX=${prefix} CC='${CC}' DESTDIR=${D} LIBDIR=${libdir} INCLUDEDIR=${includedir}"
> +
> +do_install() {
> +	oe_runmake install
> +}
> +
> +BBCLASSEXTEND += "native nativesdk"
> -- 
> 1.9.1
>
Ross Burton - July 16, 2014, 1:48 p.m.
On 16 July 2014 10:11, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> I'm still a little concerned about this change from svn to git. Which is
> the definitive source? It looks like the svn repo is active too?
>
> I just don't want to end up in a position where we're pulling from
> someone's hack'n'dev version of lz4 rather than the place considered the
> real "master" source...

The revision histories *are* different (commits marked "untested" and
then fixed in another commit) but the owner of the git repo is the
same as the owner of the svn repo.  It looks like git is his working
area and then changes that have been tested are merged and committed
to git.

Unless there's a good reason I'd keep with the svn repo for now.

Ross
Armin Kuster - July 16, 2014, 7:07 p.m.
Did not mean to generate extra work for you all.

Thanks for the input. I will go back to the drawing board.

regards,
Armin
On 07/16/2014 06:48 AM, Burton, Ross wrote:
> On 16 July 2014 10:11, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> I'm still a little concerned about this change from svn to git. Which is
>> the definitive source? It looks like the svn repo is active too?
>>
>> I just don't want to end up in a position where we're pulling from
>> someone's hack'n'dev version of lz4 rather than the place considered the
>> real "master" source...
> The revision histories *are* different (commits marked "untested" and
> then fixed in another commit) but the owner of the git repo is the
> same as the owner of the svn repo.  It looks like git is his working
> area and then changes that have been tested are merged and committed
> to git.
>
> Unless there's a good reason I'd keep with the svn repo for now.
>
> Ross

Patch

diff --git a/meta/recipes-support/lz4/lz4_git.bb b/meta/recipes-support/lz4/lz4_git.bb
new file mode 100644
index 0000000..3978d76
--- /dev/null
+++ b/meta/recipes-support/lz4/lz4_git.bb
@@ -0,0 +1,18 @@ 
+SUMMARY = "Extremely Fast Compression algorithm"
+DESCRIPTION = "LZ4 is a very fast lossless compression algorithm, providing compression speed at 400 MB/s per core, scalable with multi-cores CPU. It also features an extremely fast decoder, with speed in multiple GB/s per core, typically reaching RAM speed limits on multi-core systems."
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=0b0d063f37a4477b54af2459477dcafd"
+
+SRCREV = "28fd251bc7b42e5cde15f9a2d78fc53b3b575558"
+SRC_URI= "git://github.com/Cyan4973/lz4.git;branch=master"
+
+S = "${WORKDIR}/git"
+
+EXTRA_OEMAKE = "PREFIX=${prefix} CC='${CC}' DESTDIR=${D} LIBDIR=${libdir} INCLUDEDIR=${includedir}"
+
+do_install() {
+	oe_runmake install
+}
+
+BBCLASSEXTEND += "native nativesdk"