Patchwork setserial: package depends on groff-native to build

login
register
mail settings
Submitter jackie huang
Date July 14, 2014, 9:03 a.m.
Message ID <1405328638-7688-1-git-send-email-jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/75445/
State New
Headers show

Comments

jackie huang - July 14, 2014, 9:03 a.m.
From: Yue Tao <Yue.Tao@windriver.com>

[YOCTO #6526]

Add explicit depends to avoid host contamination.

Signed-off-by: Jonas Zetterberg <jonas.zetterberg@windriver.com>
Signed-off-by: Yue Tao <yue.tao@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-bsp/setserial/setserial_2.17.bb | 2 ++
 1 file changed, 2 insertions(+)
Ross Burton - July 14, 2014, 10:32 a.m.
On 14 July 2014 10:03,  <jackie.huang@windriver.com> wrote:
> Add explicit depends to avoid host contamination.

That's not host contamination, please reword the commit to explain
that it's a missing build dependency.

Ross
jackie huang - July 15, 2014, 1:57 a.m.
> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton@intel.com]
> Sent: Monday, July 14, 2014 6:32 PM
> To: Huang, Jie (Jackie)
> Cc: OE-core
> Subject: Re: [OE-core] [PATCH] setserial: package depends on groff-native to build
> 
> On 14 July 2014 10:03,  <jackie.huang@windriver.com> wrote:
> > Add explicit depends to avoid host contamination.
> 
> That's not host contamination, please reword the commit to explain that it's a missing build

Sure, I will resend v2 for this.

Thanks,
Jackie

> dependency.
> 
> Ross

Patch

diff --git a/meta/recipes-bsp/setserial/setserial_2.17.bb b/meta/recipes-bsp/setserial/setserial_2.17.bb
index 65d6068..f1e8cd3 100644
--- a/meta/recipes-bsp/setserial/setserial_2.17.bb
+++ b/meta/recipes-bsp/setserial/setserial_2.17.bb
@@ -8,6 +8,8 @@  LICENSE = "GPLv2.0"
 LIC_FILES_CHKSUM = "file://version.h;beginline=1;endline=6;md5=2e7c59cb9e57e356ae81f50f4e4dfd99"
 PR = "r3"
 
+DEPENDS += "groff-native"
+
 inherit autotools-brokensep
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/setserial/${BPN}-${PV}.tar.gz \