Patchwork [1/1] pseudo_1.6.0.bb: uprev to pseudo 1.6

login
register
mail settings
Submitter Peter Seebach
Date July 11, 2014, 8:22 p.m.
Message ID <0cbfa0da548acdef1a4ab12cb708c699a495dd7f.1405110050.git.peter.seebach@windriver.com>
Download mbox | patch
Permalink /patch/75391/
State New
Headers show

Comments

Ross Burton - July 11, 2014, 8:21 p.m.
On 11 July 2014 21:22, Peter Seebach <peter.seebach@windriver.com> wrote:
> This uprevs pseudo to 1.6. This merges in all of the existing
> fixes, and also adds partial support for extended attributes,
> including storing arbitrary extended attributes in the database,
> and also interpreting the posix permissions ACLs as chmod
> requests.

The extended attributes code means adding build-dependency on attr.

Which leads onto the discussion as to whether we add attr-native to
the build for pseudo-native, or use ASSUME_PROVIDED and document that
the host needs to provide it.

Ross
Peter Seebach - July 11, 2014, 8:22 p.m.
This uprevs pseudo to 1.6. This merges in all of the existing
fixes, and also adds partial support for extended attributes,
including storing arbitrary extended attributes in the database,
and also interpreting the posix permissions ACLs as chmod
requests.
---
 meta/recipes-devtools/pseudo/pseudo.inc      |    4 ----
 meta/recipes-devtools/pseudo/pseudo_1.5.1.bb |    4 ++++
 meta/recipes-devtools/pseudo/pseudo_1.6.0.bb |   10 ++++++++++
 meta/recipes-devtools/pseudo/pseudo_git.bb   |    4 ++--
 4 files changed, 16 insertions(+), 6 deletions(-)
 create mode 100644 meta/recipes-devtools/pseudo/pseudo_1.6.0.bb
Peter Seebach - July 11, 2014, 8:24 p.m.
On Fri, 11 Jul 2014 21:21:06 +0100
"Burton, Ross" <ross.burton@intel.com> wrote:

> The extended attributes code means adding build-dependency on attr.
> 
> Which leads onto the discussion as to whether we add attr-native to
> the build for pseudo-native, or use ASSUME_PROVIDED and document that
> the host needs to provide it.

Well, since my builds worked without adding the dependency, I guess I would
go with ASSUME_PROVIDED since that was what I did, apparently.

I admit to not having been aware that it was possible to lack xattr
support in a modernish Linux.

-s
Richard Purdie - July 11, 2014, 9:32 p.m.
On Fri, 2014-07-11 at 15:24 -0500, Peter Seebach wrote:
> On Fri, 11 Jul 2014 21:21:06 +0100
> "Burton, Ross" <ross.burton@intel.com> wrote:
> 
> > The extended attributes code means adding build-dependency on attr.
> > 
> > Which leads onto the discussion as to whether we add attr-native to
> > the build for pseudo-native, or use ASSUME_PROVIDED and document that
> > the host needs to provide it.
> 
> Well, since my builds worked without adding the dependency, I guess I would
> go with ASSUME_PROVIDED since that was what I did, apparently.
> 
> I admit to not having been aware that it was possible to lack xattr
> support in a modernish Linux.

The issue is the lack of the xattr headers from what I saw, not the
xattr support itself and we're missing what looks like a single define.
For the complexity, I did wonder if we should ship a default...

Adding in the xattr-native dependency may well be easier than updating
the docs on dependencies on all the different distros.

Cheers,

Richard
Peter Seebach - July 11, 2014, 9:56 p.m.
On Fri, 11 Jul 2014 22:32:49 +0100
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:

> The issue is the lack of the xattr headers from what I saw, not the
> xattr support itself and we're missing what looks like a single define.
> For the complexity, I did wonder if we should ship a default...

Hmm. We could in theory add a test to the configure script for the header,
and just hard-code that value in a couple of places. I don't think we actually
need the header for much else. I don't know how stable that value is across
distros or anything, though. I assume it's pretty stable.

The main thing is that I've tried to avoid making dependencies on compile
checks like "can I compile something using this header" because those are
annoying and slow.
 
> Adding in the xattr-native dependency may well be easier than updating
> the docs on dependencies on all the different distros.

-s
Peter Seebach - July 14, 2014, 6:39 p.m.
On Fri, 11 Jul 2014 22:32:49 +0100
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:

> The issue is the lack of the xattr headers from what I saw, not the
> xattr support itself and we're missing what looks like a single define.
> For the complexity, I did wonder if we should ship a default...

Thinking about this more, the default alone wouldn't do it, I'd have to
either drop the header or make it conditional, which I'd sort of prefer not
to do. Checks for header availability are a pain.

So should I resubmit with the attr-native dependency? I don't know how much
build time that will impose, but I assume not very much.

-s
Ross Burton - July 14, 2014, 6:55 p.m.
On 14 July 2014 19:39, Peter Seebach <peter.seebach@windriver.com> wrote:
> So should I resubmit with the attr-native dependency? I don't know how much
> build time that will impose, but I assume not very much.

Please do, the build time for attr-native is minimal in the scheme of things.

Ross

Patch

diff --git a/meta/recipes-devtools/pseudo/pseudo.inc b/meta/recipes-devtools/pseudo/pseudo.inc
index 42738ab..cf321ed 100644
--- a/meta/recipes-devtools/pseudo/pseudo.inc
+++ b/meta/recipes-devtools/pseudo/pseudo.inc
@@ -9,10 +9,6 @@  SECTION = "base"
 LICENSE = "LGPL2.1"
 DEPENDS = "sqlite3"
 
-SRC_URI_append_class-nativesdk = " file://symver.patch"
-
-SRC_URI_append_class-native = " file://symver.patch"
-
 FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
 FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
 INSANE_SKIP_${PN} += "libdir"
diff --git a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
index 47291fd..8d562ec 100644
--- a/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_1.5.1.bb
@@ -10,6 +10,10 @@  SRC_URI = " \
     file://pseudo-fchmodat-permissions.patch \
 "
 
+SRC_URI_append_class-nativesdk = " file://symver.patch"
+
+SRC_URI_append_class-native = " file://symver.patch"
+
 SRC_URI[md5sum] = "5ec67c7bff5fe68c56de500859c19172"
 SRC_URI[sha256sum] = "3b896f592f4d568569bd02323fad2d6b8c398e16ca36ee5a8947d2ff6c1d3d52"
 
diff --git a/meta/recipes-devtools/pseudo/pseudo_1.6.0.bb b/meta/recipes-devtools/pseudo/pseudo_1.6.0.bb
new file mode 100644
index 0000000..e92c4d7
--- /dev/null
+++ b/meta/recipes-devtools/pseudo/pseudo_1.6.0.bb
@@ -0,0 +1,10 @@ 
+require pseudo.inc
+
+SRC_URI = " \
+    http://www.yoctoproject.org/downloads/${BPN}/${BPN}-${PV}.tar.bz2 \
+"
+
+SRC_URI[md5sum] = "78c3f8aa8efe8cf15a2b21261174e3b6"
+SRC_URI[sha256sum] = "e24f526443b31c3292ec5ba04950d230b5388e8983c7e192e9e489c007f3dba3"
+
+PSEUDO_EXTRA_OPTS ?= "--enable-force-async"
diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb b/meta/recipes-devtools/pseudo/pseudo_git.bb
index 66fc85f..ef258fa 100644
--- a/meta/recipes-devtools/pseudo/pseudo_git.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
@@ -1,7 +1,7 @@ 
 require pseudo.inc
 
-SRCREV = "b9eb2b5633b5a23efe72c950494728d93c2b5823"
-PV = "1.5.1+git${SRCPV}"
+SRCREV = "512b84fb539c970464a93107995edf0e775d13fa"
+PV = "1.6.0+git${SRCPV}"
 
 DEFAULT_PREFERENCE = "-1"