Patchwork Try to make urandom more random using the proper seed.

login
register
mail settings
Submitter Abelenda Diego
Date July 11, 2014, 1:22 p.m.
Message ID <20140711152256.7c5ad7b8@Arika>
Download mbox | patch
Permalink /patch/75379/
State New
Headers show

Comments

Abelenda Diego - July 11, 2014, 1:22 p.m.
From 963a99512475b6bc402d2339fa4e4765960e4c26 Mon Sep 17 00:00:00 2001
From: Diego <diego.abelenda@domo-safety.com>
Date: Fri, 11 Jul 2014 14:30:56 +0200
Subject: [PATCH] Try to make urandom more random using the proper seed.

If we follow the syntax here we think that previously, at shutdown, the seed file was created after urandom was re-seeded with its state at boot. This might make the state of urandom pretty similar to its state at last reboot. Even if it might not be the case since the /etc/init.d/rc script tells us that it stops services in reboot and shutdown runlevels.

If this patch does not makes the initscript called with argument start at boot and stop at shutdown, it will at least make things less confusing and give the correct names for the /etc/rc?.d/ links. But from what I understand, the initscript will not be called at all at shutdown because of the double start pervention in /etc/init.d/rc.

---
 meta/recipes-core/initscripts/initscripts_1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Abelenda Diego - July 11, 2014, 2:24 p.m.
Sorry for the mess...

At least consider it as my way to tell that I think the iniscripts options
should be reviewed.

From what I see in /etc/init.d/rc, the script will not be started at runlevels
0 6 due to lines 146-161 :
	if [ $previous != N ] && [ $previous != S ]
	then
		#
		# Find start script in previous runlevel and
		# stop script in this runlevel.
		#
		suffix=${i#/etc/rc$runlevel.d/S[0-9][0-9]}
		stop=/etc/rc$runlevel.d/K[0-9][0-9]$suffix
		previous_start=/etc/rc$previous.d/S[0-9][0-9]$suffix
		#
		# If there is a start script in the previous level
		# and _no_ stop script in this level, we don't
		# have to re-start the service.
		#
		[ -f $previous_start ] && [ ! -f $stop ] && continue
	fi

If the script is still run please explain to me why, I do not understand...

Best regards,
Diego Abelenda

On Fri, 11 Jul 2014 15:22:56 +0200
Abelenda Diego <diego.abelenda@domo-safety.com> wrote:

> From 963a99512475b6bc402d2339fa4e4765960e4c26 Mon Sep 17 00:00:00 2001
> From: Diego <diego.abelenda@domo-safety.com>
> Date: Fri, 11 Jul 2014 14:30:56 +0200
> Subject: [PATCH] Try to make urandom more random using the proper seed.
> 
> If we follow the syntax here we think that previously, at shutdown, the seed
> file was created after urandom was re-seeded with its state at boot. This
> might make the state of urandom pretty similar to its state at last reboot.
> Even if it might not be the case since the /etc/init.d/rc script tells us
> that it stops services in reboot and shutdown runlevels.
> 
> If this patch does not makes the initscript called with argument start at
> boot and stop at shutdown, it will at least make things less confusing and
> give the correct names for the /etc/rc?.d/ links. But from what I understand,
> the initscript will not be called at all at shutdown because of the double
> start pervention in /etc/init.d/rc.
> 
> ---
>  meta/recipes-core/initscripts/initscripts_1.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb
> b/meta/recipes-core/initscripts/initscripts_1.0.  bb index 531b2b6..b266ba6
> 100644 --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
> @@ -104,7 +104,7 @@ do_install () {
>  #
>     update-rc.d -r ${D} rmnologin.sh start 99 2 3 4 5 . 
>     update-rc.d -r ${D} sendsigs start 20 0 6 . 
> -   update-rc.d -r ${D} urandom start 30 S 0 6 .
> +   update-rc.d -r ${D} urandom start 30 S . stop 30 0 6 .
>     update-rc.d -r ${D} umountnfs.sh start 31 0 6 . 
>     update-rc.d -r ${D} umountfs start 40 0 6 . 
>     update-rc.d -r ${D} reboot start 90 6 .

Patch

diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.  bb
index 531b2b6..b266ba6 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -104,7 +104,7 @@  do_install () {
 #
    update-rc.d -r ${D} rmnologin.sh start 99 2 3 4 5 . 
    update-rc.d -r ${D} sendsigs start 20 0 6 . 
-   update-rc.d -r ${D} urandom start 30 S 0 6 .
+   update-rc.d -r ${D} urandom start 30 S . stop 30 0 6 .
    update-rc.d -r ${D} umountnfs.sh start 31 0 6 . 
    update-rc.d -r ${D} umountfs start 40 0 6 . 
    update-rc.d -r ${D} reboot start 90 6 .