Patchwork [meta-fsl-ppc,10/12] add default setting for MKUBIFS_ARGS and UBINIZE_ARGS

login
register
mail settings
Submitter Ting Liu
Date July 11, 2014, 8:09 a.m.
Message ID <1405066162-30121-10-git-send-email-ting.liu@freescale.com>
Download mbox | patch
Permalink /patch/75351/
State Accepted
Delegated to: Zhenhua Luo
Headers show

Comments

Ting Liu - July 11, 2014, 8:09 a.m.
From: Ting Liu <b28495@freescale.com>

Signed-off-by: Ting Liu <b28495@freescale.com>
---
 conf/machine/include/qoriq-default-settings.inc |    3 +++
 1 file changed, 3 insertions(+)
Otavio Salvador - July 11, 2014, 5:09 p.m.
On Fri, Jul 11, 2014 at 5:09 AM,  <ting.liu@freescale.com> wrote:
> From: Ting Liu <b28495@freescale.com>
>
> Signed-off-by: Ting Liu <b28495@freescale.com>

I'd like to see a comment, like we did for imx28evk, where we describe
model and values. In either case, change is fine.

Acked-by: Otavio Salvador <otavio@ossystems.com.br>
Bob Cochran - July 18, 2014, 7:28 p.m.
On 07/11/2014 04:09 AM, ting.liu@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
>
> Signed-off-by: Ting Liu <b28495@freescale.com>
> ---
>   conf/machine/include/qoriq-default-settings.inc |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/conf/machine/include/qoriq-default-settings.inc b/conf/machine/include/qoriq-default-settings.inc
> index f808ac2..ef07b7d 100644
> --- a/conf/machine/include/qoriq-default-settings.inc
> +++ b/conf/machine/include/qoriq-default-settings.inc
> @@ -16,3 +16,6 @@ SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
>
>   USE_VT = "0"
>
> +MKUBIFS_ARGS ??= "-m 512 -e 15360 -c 3600"

Hi Ting,

Just an FYI: when building meta-fsl-ppc master with poky master 
alongside sdk1.6 meta-fsl-networking, I need to bump mkfs.ubifs 
max_leb_cnt (-c param) to avoid error when building image:

ERROR: Error: The image creation script 
'/build/yocto/t1040_master/tmp/work/t1040rdb_64b-fsl-linux/fsl-image-core/1.0-r0/temp/create_image.ubi' 
returned 255:
Error: max_leb_cnt too low (3701 needed)

I don't know if something is amiss somewhere else or if 3600 was tight 
to begin with.   In order to move forward, I'm bumping the value in 
qoriq-default-settings.inc and assigning it so it overrides the default 
also set in meta-fsl-networking.

I probably won't revisit the actual size of my FLASH image for awhile. 
Let me know if you want me to look into anything related to this.

Bob


> +UBINIZE_ARGS ??= "-m 512 -p 16KiB -s 512"

> +
>

Patch

diff --git a/conf/machine/include/qoriq-default-settings.inc b/conf/machine/include/qoriq-default-settings.inc
index f808ac2..ef07b7d 100644
--- a/conf/machine/include/qoriq-default-settings.inc
+++ b/conf/machine/include/qoriq-default-settings.inc
@@ -16,3 +16,6 @@  SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
 
 USE_VT = "0"
 
+MKUBIFS_ARGS ??= "-m 512 -e 15360 -c 3600"
+UBINIZE_ARGS ??= "-m 512 -p 16KiB -s 512"
+