Patchwork libomxil-0.9.3: Move .so files to main package.

login
register
mail settings
Submitter Drew Moseley
Date July 10, 2014, 7:18 p.m.
Message ID <1405019902-31691-1-git-send-email-drew_moseley@mentor.com>
Download mbox | patch
Permalink /patch/75327/
State New
Headers show

Comments

Drew Moseley - July 10, 2014, 7:18 p.m.
The omxregister-bellagio app scans the libdir for the '*.so'
files to get them properly registered.  Make sure they are
included in the base package rather than the dev.

Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
---
 meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Saul Wold - July 15, 2014, 12:03 a.m.
On 07/10/2014 12:18 PM, Drew Moseley wrote:
> The omxregister-bellagio app scans the libdir for the '*.so'
> files to get them properly registered.  Make sure they are
> included in the base package rather than the dev.
>
Would it be better to patch the register app to have a more generic 
search for .so*??

Something to check with the libomxil upstream?

I am not saying no to this, just want to check out options.

Thanks
	Sau!


> Signed-off-by: Drew Moseley <drew_moseley@mentor.com>
> ---
>   meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb b/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb
> index 103d789..e11febc 100644
> --- a/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb
> +++ b/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb
> @@ -24,12 +24,14 @@ inherit autotools
>   EXTRA_OECONF += "--disable-doc --disable-Werror"
>
>   FILES_${PN} += "${libdir}/bellagio/*${SOLIBS} \
> -                ${libdir}/omxloaders/*${SOLIBS}"
> +                ${libdir}/bellagio/*${SOLIBSDEV} \
> +                ${libdir}/omxloaders/*${SOLIBS} \
> +                ${libdir}/omxloaders/*${SOLIBSDEV}"
>   FILES_${PN}-staticdev += "${libdir}/bellagio/*.a \
>                             ${libdir}/omxloaders/*.a"
>   FILES_${PN}-dev += "${libdir}/bellagio/*.la \
> -                    ${libdir}/bellagio/*${SOLIBSDEV} \
> -                    ${libdir}/omxloaders/*.la \
> -                    ${libdir}/omxloaders/*${SOLIBSDEV}"
> +                    ${libdir}/omxloaders/*.la"
>   FILES_${PN}-dbg += "${libdir}/bellagio/.debug/ \
>                       ${libdir}/omxloaders/.debug/"
> +
> +INSANE_SKIP_${PN} += "dev-so"
>
Ross Burton - July 15, 2014, 8:46 a.m.
On 15 July 2014 01:03, Saul Wold <sgw@linux.intel.com> wrote:
> On 07/10/2014 12:18 PM, Drew Moseley wrote:
>>
>> The omxregister-bellagio app scans the libdir for the '*.so'
>> files to get them properly registered.  Make sure they are
>> included in the base package rather than the dev.
>>
> Would it be better to patch the register app to have a more generic search
> for .so*??

Searching for .so is fine if you're looking for loadable modules, but
as the package contains versioned real files and lots of symlinks
they're Doing It Wrong.  A better fix would be to fix the build so
that it installs unversioned loadable modules, and then ensure that
they're in the main package (a real .so file in $PN shoudn't kick a QA
error, either).

I think the magic libtool options are -avoid-version -module -shared.

Ross

Patch

diff --git a/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb b/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb
index 103d789..e11febc 100644
--- a/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb
+++ b/meta/recipes-multimedia/libomxil/libomxil_0.9.3.bb
@@ -24,12 +24,14 @@  inherit autotools
 EXTRA_OECONF += "--disable-doc --disable-Werror"
 
 FILES_${PN} += "${libdir}/bellagio/*${SOLIBS} \
-                ${libdir}/omxloaders/*${SOLIBS}"
+                ${libdir}/bellagio/*${SOLIBSDEV} \
+                ${libdir}/omxloaders/*${SOLIBS} \
+                ${libdir}/omxloaders/*${SOLIBSDEV}"
 FILES_${PN}-staticdev += "${libdir}/bellagio/*.a \
                           ${libdir}/omxloaders/*.a"
 FILES_${PN}-dev += "${libdir}/bellagio/*.la \
-                    ${libdir}/bellagio/*${SOLIBSDEV} \
-                    ${libdir}/omxloaders/*.la \
-                    ${libdir}/omxloaders/*${SOLIBSDEV}"
+                    ${libdir}/omxloaders/*.la"
 FILES_${PN}-dbg += "${libdir}/bellagio/.debug/ \
                     ${libdir}/omxloaders/.debug/"
+
+INSANE_SKIP_${PN} += "dev-so"